rust: improve grammar in commentary

[PATCH] rust: improve grammar in commentary

Posted by Tamir Duberstein 1 year, 4 months ago

Commit e26fa546042a ("rust: kbuild: auto generate helper exports")
added an errant "the" where one was not needed; remove it.

Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
 rust/exports.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/rust/exports.c b/rust/exports.c
index e5695f3b45b7..fd278e272751 100644
--- a/rust/exports.c
+++ b/rust/exports.c
@@ -3,9 +3,9 @@
  * A hack to export Rust symbols for loadable modules without having to redo
  * the entire `include/linux/export.h` logic in Rust.
  *
- * This requires the Rust's new/future `v0` mangling scheme because the default
- * one ("legacy") uses invalid characters for C identifiers (thus we cannot use
- * the `EXPORT_SYMBOL_*` macros).
+ * This requires Rust's new/future `v0` mangling scheme because the default one
+ * ("legacy") uses invalid characters for C identifiers (thus we cannot use the
+ * `EXPORT_SYMBOL_*` macros).
  *
  * All symbols are exported as GPL-only to guarantee no GPL-only feature is
  * accidentally exposed.
-- 
2.47.0

Re: [PATCH] rust: improve grammar in commentary

Posted by Miguel Ojeda 1 year, 3 months ago

On Wed, Oct 9, 2024 at 6:24 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> Commit e26fa546042a ("rust: kbuild: auto generate helper exports")
> added an errant "the" where one was not needed; remove it.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Applied to `rust-next` -- thanks everyone!

    [ Reworded title. - Miguel ]

Cheers,
Miguel

Re: [PATCH] rust: improve grammar in commentary

Posted by Andreas Hindborg 1 year, 4 months ago

"Tamir Duberstein" <tamird@gmail.com> writes:

> Commit e26fa546042a ("rust: kbuild: auto generate helper exports")
> added an errant "the" where one was not needed; remove it.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>


Reviewed-by: Andreas Hindborg <a.hindborg@kernel.org>

Re: [PATCH] rust: improve grammar in commentary

Posted by Alice Ryhl 1 year, 4 months ago

On Wed, Oct 9, 2024 at 6:24 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> Commit e26fa546042a ("rust: kbuild: auto generate helper exports")
> added an errant "the" where one was not needed; remove it.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

Re: [PATCH] rust: improve grammar in commentary

Posted by Dirk Behme 1 year, 4 months ago

Am 09.10.24 um 18:23 schrieb Tamir Duberstein:
> Commit e26fa546042a ("rust: kbuild: auto generate helper exports")
> added an errant "the" where one was not needed; remove it.
> 
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Reviewed-by: Dirk Behme <dirk.behme@gmail.com>

Thanks

Dirk

> ---
>   rust/exports.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/rust/exports.c b/rust/exports.c
> index e5695f3b45b7..fd278e272751 100644
> --- a/rust/exports.c
> +++ b/rust/exports.c
> @@ -3,9 +3,9 @@
>    * A hack to export Rust symbols for loadable modules without having to redo
>    * the entire `include/linux/export.h` logic in Rust.
>    *
> - * This requires the Rust's new/future `v0` mangling scheme because the default
> - * one ("legacy") uses invalid characters for C identifiers (thus we cannot use
> - * the `EXPORT_SYMBOL_*` macros).
> + * This requires Rust's new/future `v0` mangling scheme because the default one
> + * ("legacy") uses invalid characters for C identifiers (thus we cannot use the
> + * `EXPORT_SYMBOL_*` macros).
>    *
>    * All symbols are exported as GPL-only to guarantee no GPL-only feature is
>    * accidentally exposed.