[PATCH net-next 02/11] dt-bindings: net: add i.MX95 ENETC support

Wei Fang posted 11 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH net-next 02/11] dt-bindings: net: add i.MX95 ENETC support
Posted by Wei Fang 1 month, 2 weeks ago
The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor
ID and device ID have also changed, so add the new compatible strings
for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII
or RMII reference clock.

Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
 .../devicetree/bindings/net/fsl,enetc.yaml    | 23 +++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
index e152c93998fe..1a6685bb7230 100644
--- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
@@ -20,14 +20,29 @@ maintainers:
 
 properties:
   compatible:
-    items:
-      - enum:
-          - pci1957,e100
-      - const: fsl,enetc
+    oneOf:
+      - items:
+          - enum:
+              - pci1957,e100
+          - const: fsl,enetc
+      - items:
+          - const: pci1131,e101
+      - items:
+          - enum:
+              - nxp,imx95-enetc
+          - const: pci1131,e101
 
   reg:
     maxItems: 1
 
+  clocks:
+    items:
+      - description: MAC transmit/receiver reference clock
+
+  clock-names:
+    items:
+      - const: enet_ref_clk
+
   mdio:
     $ref: mdio.yaml
     unevaluatedProperties: false
-- 
2.34.1
Re: [PATCH net-next 02/11] dt-bindings: net: add i.MX95 ENETC support
Posted by Frank Li 1 month, 2 weeks ago
On Wed, Oct 09, 2024 at 05:51:07PM +0800, Wei Fang wrote:
> The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor
> ID and device ID have also changed, so add the new compatible strings
> for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII
> or RMII reference clock.
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
>  .../devicetree/bindings/net/fsl,enetc.yaml    | 23 +++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> index e152c93998fe..1a6685bb7230 100644
> --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> @@ -20,14 +20,29 @@ maintainers:
>
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - pci1957,e100
> -      - const: fsl,enetc
> +    oneOf:
> +      - items:
> +          - enum:
> +              - pci1957,e100
> +          - const: fsl,enetc
> +      - items:
> +          - const: pci1131,e101
> +      - items:
> +          - enum:
> +              - nxp,imx95-enetc
> +          - const: pci1131,e101

    oneOf:
      - items:
          - enum:
              - pci1957,e100
          - const: fsl,enetc
      - items:
          - const: pci1131,e101
          - enum:
              - nxp,imx95-enetc
          minItems: 1

keep consistent, pid/did as first one.

Frank

>
>    reg:
>      maxItems: 1
>
> +  clocks:
> +    items:
> +      - description: MAC transmit/receiver reference clock
> +
> +  clock-names:
> +    items:
> +      - const: enet_ref_clk
> +
>    mdio:
>      $ref: mdio.yaml
>      unevaluatedProperties: false
> --
> 2.34.1
>
Re: [PATCH net-next 02/11] dt-bindings: net: add i.MX95 ENETC support
Posted by Rob Herring 1 month, 2 weeks ago
On Wed, Oct 09, 2024 at 12:29:57PM -0400, Frank Li wrote:
> On Wed, Oct 09, 2024 at 05:51:07PM +0800, Wei Fang wrote:
> > The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor
> > ID and device ID have also changed, so add the new compatible strings
> > for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII
> > or RMII reference clock.
> >
> > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > ---
> >  .../devicetree/bindings/net/fsl,enetc.yaml    | 23 +++++++++++++++----
> >  1 file changed, 19 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > index e152c93998fe..1a6685bb7230 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > @@ -20,14 +20,29 @@ maintainers:
> >
> >  properties:
> >    compatible:
> > -    items:
> > -      - enum:
> > -          - pci1957,e100
> > -      - const: fsl,enetc
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - pci1957,e100
> > +          - const: fsl,enetc
> > +      - items:
> > +          - const: pci1131,e101
> > +      - items:
> > +          - enum:
> > +              - nxp,imx95-enetc
> > +          - const: pci1131,e101
> 
>     oneOf:
>       - items:
>           - enum:
>               - pci1957,e100
>           - const: fsl,enetc
>       - items:
>           - const: pci1131,e101
>           - enum:
>               - nxp,imx95-enetc

const.

Or maybe just drop it. Hopefully the PCI ID changes with each chip. If 
not, we kind of have the compatibles backwards.

>           minItems: 1

Then why have the fallback?