[v1] clocksource: Remove unused clocksource_change_rating

[PATCH] clocksource: Remove unused clocksource_change_rating

Posted by linux@treblig.org 1 year, 4 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

clocksource_change_rating() has been unused since 2017's commit
63ed4e0c67df ("Drivers: hv: vmbus: Consolidate all Hyper-V specific clocksource code")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 include/linux/clocksource.h |  1 -
 kernel/time/clocksource.c   | 21 ---------------------
 2 files changed, 22 deletions(-)

diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
index d35b677b08fe..ef1b16da6ad5 100644
--- a/include/linux/clocksource.h
+++ b/include/linux/clocksource.h
@@ -215,7 +215,6 @@ static inline s64 clocksource_cyc2ns(u64 cycles, u32 mult, u32 shift)
 
 extern int clocksource_unregister(struct clocksource*);
 extern void clocksource_touch_watchdog(void);
-extern void clocksource_change_rating(struct clocksource *cs, int rating);
 extern void clocksource_suspend(void);
 extern void clocksource_resume(void);
 extern struct clocksource * __init clocksource_default_clock(void);
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 23336eecb4f4..e041ba81c2f7 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -1262,27 +1262,6 @@ static void __clocksource_change_rating(struct clocksource *cs, int rating)
 	clocksource_enqueue(cs);
 }
 
-/**
- * clocksource_change_rating - Change the rating of a registered clocksource
- * @cs:		clocksource to be changed
- * @rating:	new rating
- */
-void clocksource_change_rating(struct clocksource *cs, int rating)
-{
-	unsigned long flags;
-
-	mutex_lock(&clocksource_mutex);
-	clocksource_watchdog_lock(&flags);
-	__clocksource_change_rating(cs, rating);
-	clocksource_watchdog_unlock(&flags);
-
-	clocksource_select();
-	clocksource_select_watchdog(false);
-	clocksource_suspend_select(false);
-	mutex_unlock(&clocksource_mutex);
-}
-EXPORT_SYMBOL(clocksource_change_rating);
-
 /*
  * Unbind clocksource @cs. Called with clocksource_mutex held
  */
-- 
2.46.2

Re: [PATCH] clocksource: Remove unused clocksource_change_rating

Posted by John Stultz 1 year, 4 months ago

On Tue, Oct 8, 2024 at 5:30 PM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> clocksource_change_rating() has been unused since 2017's commit
> 63ed4e0c67df ("Drivers: hv: vmbus: Consolidate all Hyper-V specific clocksource code")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Thanks for submitting this cleanup!

Untested, but
Acked-by: John Stultz <jstultz@google.com>

thanks
-john

Re: [PATCH] clocksource: Remove unused clocksource_change_rating

Posted by Dr. David Alan Gilbert 1 year, 4 months ago

* John Stultz (jstultz@google.com) wrote:
> On Tue, Oct 8, 2024 at 5:30 PM <linux@treblig.org> wrote:
> >
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > clocksource_change_rating() has been unused since 2017's commit
> > 63ed4e0c67df ("Drivers: hv: vmbus: Consolidate all Hyper-V specific clocksource code")
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> Thanks for submitting this cleanup!
> 
> Untested, but
> Acked-by: John Stultz <jstultz@google.com>

Hmm the test robot got an unused warning on __clocksource_change_rating
I think that's because it's an allnoconfig and that needs moving inside
the ifdef.

I'll look at it.

Dave
> thanks
> -john
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] clocksource: Remove unused clocksource_change_rating

Posted by Dr. David Alan Gilbert 1 year, 4 months ago

* Dr. David Alan Gilbert (linux@treblig.org) wrote:
> * John Stultz (jstultz@google.com) wrote:
> > On Tue, Oct 8, 2024 at 5:30 PM <linux@treblig.org> wrote:
> > >
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > >
> > > clocksource_change_rating() has been unused since 2017's commit
> > > 63ed4e0c67df ("Drivers: hv: vmbus: Consolidate all Hyper-V specific clocksource code")
> > >
> > > Remove it.
> > >
> > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > 
> > Thanks for submitting this cleanup!
> > 
> > Untested, but
> > Acked-by: John Stultz <jstultz@google.com>
> 
> Hmm the test robot got an unused warning on __clocksource_change_rating
> I think that's because it's an allnoconfig and that needs moving inside
> the ifdef.
> 
> I'll look at it.

v2 posted 20241010135446.213098-1-linux@treblig.org
I shuffled the __clocksource_change_rating inside the ifdef (I guess
I could have inlined it instead).

The failure the testbot found only happens on a non-x86 allnoconfig.

Dave

> 
> Dave
> > thanks
> > -john
> > 
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

[tip: timers/core] clocksource: Remove unused clocksource_change_rating

Posted by tip-bot2 for Dr. David Alan Gilbert 1 year, 4 months ago

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     5ce9bb4d5af2f5ef38f134e3cb400c873d357de7
Gitweb:        https://git.kernel.org/tip/5ce9bb4d5af2f5ef38f134e3cb400c873d357de7
Author:        Dr. David Alan Gilbert <linux@treblig.org>
AuthorDate:    Wed, 09 Oct 2024 01:30:32 +01:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 09 Oct 2024 11:14:29 +02:00

clocksource: Remove unused clocksource_change_rating

clocksource_change_rating() has been unused since 2017's commit
63ed4e0c67df ("Drivers: hv: vmbus: Consolidate all Hyper-V specific
clocksource code")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: John Stultz <jstultz@google.com>
Link: https://lore.kernel.org/all/20241009003032.254348-1-linux@treblig.org
---
 include/linux/clocksource.h |  1 -
 kernel/time/clocksource.c   | 21 ---------------------
 2 files changed, 22 deletions(-)

diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
index d35b677..ef1b16d 100644
--- a/include/linux/clocksource.h
+++ b/include/linux/clocksource.h
@@ -215,7 +215,6 @@ static inline s64 clocksource_cyc2ns(u64 cycles, u32 mult, u32 shift)
 
 extern int clocksource_unregister(struct clocksource*);
 extern void clocksource_touch_watchdog(void);
-extern void clocksource_change_rating(struct clocksource *cs, int rating);
 extern void clocksource_suspend(void);
 extern void clocksource_resume(void);
 extern struct clocksource * __init clocksource_default_clock(void);
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 23336ee..e041ba8 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -1262,27 +1262,6 @@ static void __clocksource_change_rating(struct clocksource *cs, int rating)
 	clocksource_enqueue(cs);
 }
 
-/**
- * clocksource_change_rating - Change the rating of a registered clocksource
- * @cs:		clocksource to be changed
- * @rating:	new rating
- */
-void clocksource_change_rating(struct clocksource *cs, int rating)
-{
-	unsigned long flags;
-
-	mutex_lock(&clocksource_mutex);
-	clocksource_watchdog_lock(&flags);
-	__clocksource_change_rating(cs, rating);
-	clocksource_watchdog_unlock(&flags);
-
-	clocksource_select();
-	clocksource_select_watchdog(false);
-	clocksource_suspend_select(false);
-	mutex_unlock(&clocksource_mutex);
-}
-EXPORT_SYMBOL(clocksource_change_rating);
-
 /*
  * Unbind clocksource @cs. Called with clocksource_mutex held
  */