[PATCH net-next v20 14/14] mm: page_frag: add an entry in MAINTAINERS for page_frag

Yunsheng Lin posted 14 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH net-next v20 14/14] mm: page_frag: add an entry in MAINTAINERS for page_frag
Posted by Yunsheng Lin 1 month, 2 weeks ago
After this patchset, page_frag is a small subsystem/library
on its own, so add an entry in MAINTAINERS to indicate the
new subsystem/library's maintainer, maillist, status and file
lists of page_frag.

Alexander is the original author of page_frag, add him in the
MAINTAINERS too.

CC: Alexander Duyck <alexander.duyck@gmail.com>
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
---
 MAINTAINERS | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index af635dc60cfe..05b45231454d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17496,6 +17496,18 @@ F:	mm/page-writeback.c
 F:	mm/readahead.c
 F:	mm/truncate.c
 
+PAGE FRAG
+M:	Alexander Duyck <alexander.duyck@gmail.com>
+M:	Yunsheng Lin <linyunsheng@huawei.com>
+L:	linux-mm@kvack.org
+L:	netdev@vger.kernel.org
+S:	Supported
+F:	Documentation/mm/page_frags.rst
+F:	include/linux/page_frag_cache.h
+F:	mm/page_frag_cache.c
+F:	tools/testing/selftests/mm/page_frag/
+F:	tools/testing/selftests/mm/test_page_frag.sh
+
 PAGE POOL
 M:	Jesper Dangaard Brouer <hawk@kernel.org>
 M:	Ilias Apalodimas <ilias.apalodimas@linaro.org>
-- 
2.33.0
Re: [PATCH net-next v20 14/14] mm: page_frag: add an entry in MAINTAINERS for page_frag
Posted by Jakub Kicinski 1 month, 2 weeks ago
On Tue, 8 Oct 2024 19:20:48 +0800 Yunsheng Lin wrote:
> +M:	Yunsheng Lin <linyunsheng@huawei.com>

The bar for maintaining core code is very high, if you'd 
like to be a maintainer please start small.
Re: [PATCH net-next v20 14/14] mm: page_frag: add an entry in MAINTAINERS for page_frag
Posted by Yunsheng Lin 1 month, 2 weeks ago
On 2024/10/9 8:43, Jakub Kicinski wrote:
> On Tue, 8 Oct 2024 19:20:48 +0800 Yunsheng Lin wrote:
>> +M:	Yunsheng Lin <linyunsheng@huawei.com>
> 
> The bar for maintaining core code is very high, if you'd 
> like to be a maintainer please start small.

I did start small with the page_pool case, as mentioned in
[1] of a similar comment, and the page_frag is a small
subsystem/library as mentioned in commit log.

I think I still might need a second opinion here.

1. https://lore.kernel.org/linux-kernel/dea82ac3-65fc-c941-685f-9d4655aa4a52@huawei.com/
Re: [PATCH net-next v20 14/14] mm: page_frag: add an entry in MAINTAINERS for page_frag
Posted by Paolo Abeni 1 month, 2 weeks ago
Hi,

On 10/9/24 06:01, Yunsheng Lin wrote:
> On 2024/10/9 8:43, Jakub Kicinski wrote:
>> On Tue, 8 Oct 2024 19:20:48 +0800 Yunsheng Lin wrote:
>>> +M:	Yunsheng Lin <linyunsheng@huawei.com>
>>
>> The bar for maintaining core code is very high, if you'd
>> like to be a maintainer please start small.
> 
> I did start small with the page_pool case, as mentioned in
> [1] of a similar comment, and the page_frag is a small
> subsystem/library as mentioned in commit log.
> 
> I think I still might need a second opinion here.
> 
> 1. https://lore.kernel.org/linux-kernel/dea82ac3-65fc-c941-685f-9d4655aa4a52@huawei.com/

Please note that the 'small' part here does not refer strictly to code 
size. Any core networking code has the bar significantly higher than 
i.e. NIC drivers - even if the latter could count order of magnitude 
more LoC.
AFAICS there is an unwritten convention that people are called to 
maintain core code, as opposed to people appointing themself to maintain 
driver code.

Cheers,

Paolo
Re: [PATCH net-next v20 14/14] mm: page_frag: add an entry in MAINTAINERS for page_frag
Posted by Yunsheng Lin 1 month, 2 weeks ago
On 2024/10/10 0:32, Paolo Abeni wrote:
> Hi,

Hi,

> 
> On 10/9/24 06:01, Yunsheng Lin wrote:
>> On 2024/10/9 8:43, Jakub Kicinski wrote:
>>> On Tue, 8 Oct 2024 19:20:48 +0800 Yunsheng Lin wrote:
>>>> +M:    Yunsheng Lin <linyunsheng@huawei.com>
>>>
>>> The bar for maintaining core code is very high, if you'd
>>> like to be a maintainer please start small.
>>
>> I did start small with the page_pool case, as mentioned in
>> [1] of a similar comment, and the page_frag is a small
>> subsystem/library as mentioned in commit log.
>>
>> I think I still might need a second opinion here.
>>
>> 1. https://lore.kernel.org/linux-kernel/dea82ac3-65fc-c941-685f-9d4655aa4a52@huawei.com/
> 
> Please note that the 'small' part here does not refer strictly to code size. Any core networking code has the bar significantly higher than i.e. NIC drivers - even if the latter could count order of magnitude more LoC.
> AFAICS there is an unwritten convention that people are called to maintain core code, as opposed to people appointing themself to maintain driver code.

Is there any discussion that is referring to above 'unwritten convention'?
As my pool community experience tells me the above 'unwritten
convention' is mainly referring to well-established subsystem that is
already in the MAINTAINERS, and page_frag is not really a subsystem or
library before this patchset, it seems common to me that someone being
willing and able to turn it into a subsystem or library might become the
co-maintainer if she/he is also willing to co-maintain it.

> 
> Cheers,
> 
> Paolo
> 
>