Addition of the stm32 csi controller driver
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
.../devicetree/bindings/media/st,stm32-csi.yaml | 129 +++++++++++++++++++++
1 file changed, 129 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/st,stm32-csi.yaml b/Documentation/devicetree/bindings/media/st,stm32-csi.yaml
new file mode 100644
index 000000000000..71e7c51be58c
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/st,stm32-csi.yaml
@@ -0,0 +1,129 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/st,stm32-csi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics STM32 CSI controller
+
+description:
+ The STM32 CSI controller allows connecting a CSI based
+ camera to the DCMIPP camera pipeline.
+
+maintainers:
+ - Alain Volmat <alain.volmat@foss.st.com>
+
+properties:
+ compatible:
+ enum:
+ - st,stm32mp25-csi
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 3
+
+ clock-names:
+ items:
+ - const: pclk
+ - const: txesc
+ - const: csi2phy
+
+ resets:
+ maxItems: 1
+
+ vdd-supply:
+ description: Digital core power supply (0.91V)
+
+ vdda18-supply:
+ description: System analog power supply (1.8V)
+
+ access-controllers:
+ minItems: 1
+ maxItems: 2
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description:
+ Input port node
+
+ properties:
+ endpoint:
+ $ref: video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ data-lanes:
+ description:
+ Indicate the number of data-lanes and their mapping.
+
+ items:
+ minItems: 1
+ items:
+ - const: 1
+ - const: 2
+
+ required:
+ - data-lanes
+
+ port@1:
+ $ref: /schemas/graph.yaml#/properties/port
+ description:
+ Output port node
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+ - resets
+ - ports
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/st,stm32mp25-rcc.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/media/video-interfaces.h>
+ #include <dt-bindings/reset/st,stm32mp25-rcc.h>
+ csi@48020000 {
+ compatible = "st,stm32mp25-csi";
+ reg = <0x48020000 0x2000>;
+ interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>;
+ resets = <&rcc CSI_R>;
+ clocks = <&rcc CK_KER_CSI>, <&rcc CK_KER_CSITXESC>, <&rcc CK_KER_CSIPHY>;
+ clock-names = "pclk", "txesc", "csi2phy";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ endpoint {
+ remote-endpoint = <&imx335_ep>;
+ data-lanes = <0 1>;
+ bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ endpoint {
+ remote-endpoint = <&dcmipp_0>;
+ };
+ };
+ };
+ };
+
+...
--
2.25.1On Tue, Oct 08, 2024 at 01:18:04PM +0200, Alain Volmat wrote: > Addition of the stm32 csi controller driver This is supposed to be about hardware, not driver. Missing full stop. > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> > --- > .../devicetree/bindings/media/st,stm32-csi.yaml | 129 +++++++++++++++++++++ Use compatible as filename. > 1 file changed, 129 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/st,stm32-csi.yaml b/Documentation/devicetree/bindings/media/st,stm32-csi.yaml > new file mode 100644 > index 000000000000..71e7c51be58c > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/st,stm32-csi.yaml > @@ -0,0 +1,129 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/st,stm32-csi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectronics STM32 CSI controller > + > +description: > + The STM32 CSI controller allows connecting a CSI based > + camera to the DCMIPP camera pipeline. > + > +maintainers: > + - Alain Volmat <alain.volmat@foss.st.com> > + > +properties: > + compatible: > + enum: > + - st,stm32mp25-csi > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 3 > + > + clock-names: > + items: > + - const: pclk > + - const: txesc > + - const: csi2phy > + > + resets: > + maxItems: 1 > + > + vdd-supply: > + description: Digital core power supply (0.91V) > + > + vdda18-supply: > + description: System analog power supply (1.8V) > + > + access-controllers: > + minItems: 1 > + maxItems: 2 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Input port node > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: > + Indicate the number of data-lanes and their mapping. > + > + items: Drop ... and test your patches. Mailing list is not the place to test them. Your machine is. > + minItems: 1 > + items: > + - const: 1 > + - const: 2 > + > + required: > + - data-lanes > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output port node > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - ports Best regards, Krzysztof
Hi Krzysztof, On Tue, Oct 08, 2024 at 03:23:10PM +0200, Krzysztof Kozlowski wrote: > On Tue, Oct 08, 2024 at 01:18:04PM +0200, Alain Volmat wrote: > > Addition of the stm32 csi controller driver > > This is supposed to be about hardware, not driver. Missing full stop. Ok, commit message corrected in the upcoming v2. > > > > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> > > --- > > .../devicetree/bindings/media/st,stm32-csi.yaml | 129 +++++++++++++++++++++ > > Use compatible as filename. Fixed > > > 1 file changed, 129 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/st,stm32-csi.yaml b/Documentation/devicetree/bindings/media/st,stm32-csi.yaml > > new file mode 100644 > > index 000000000000..71e7c51be58c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/st,stm32-csi.yaml > > @@ -0,0 +1,129 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/st,stm32-csi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: STMicroelectronics STM32 CSI controller > > + > > +description: > > + The STM32 CSI controller allows connecting a CSI based > > + camera to the DCMIPP camera pipeline. > > + > > +maintainers: > > + - Alain Volmat <alain.volmat@foss.st.com> > > + > > +properties: > > + compatible: > > + enum: > > + - st,stm32mp25-csi > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 3 > > + > > + clock-names: > > + items: > > + - const: pclk > > + - const: txesc > > + - const: csi2phy > > + > > + resets: > > + maxItems: 1 > > + > > + vdd-supply: > > + description: Digital core power supply (0.91V) > > + > > + vdda18-supply: > > + description: System analog power supply (1.8V) > > + > > + access-controllers: > > + minItems: 1 > > + maxItems: 2 > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: > > + Input port node > > + > > + properties: > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + description: > > + Indicate the number of data-lanes and their mapping. > > + > > + items: > > Drop Done > > ... and test your patches. Mailing list is not the place to test them. > Your machine is. I did, however my dtschema was too old hence not reporting the issue. Once updated I now got the error reported and fixed that. > > > + minItems: 1 > > + items: > > + - const: 1 > > + - const: 2 > > + > > + required: > > + - data-lanes > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Output port node > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - resets > > + - ports > > Best regards, > Krzysztof > Regards, Alain
On Tue, 08 Oct 2024 13:18:04 +0200, Alain Volmat wrote: > Addition of the stm32 csi controller driver > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> > --- > .../devicetree/bindings/media/st,stm32-csi.yaml | 129 +++++++++++++++++++++ > 1 file changed, 129 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/st,stm32-csi.example.dtb: csi@48020000: ports:port@0:endpoint:data-lanes:0: 0 is not of type 'array' from schema $id: http://devicetree.org/schemas/media/st,stm32-csi.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/st,stm32-csi.example.dtb: csi@48020000: ports:port@0:endpoint:data-lanes:1: 1 is not of type 'array' from schema $id: http://devicetree.org/schemas/media/st,stm32-csi.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241008-csi_dcmipp_mp25-v1-2-e3fd0ed54b31@foss.st.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
© 2016 - 2024 Red Hat, Inc.