1. Patchew
  2. linux
  3. [patch 00/25] debugobjects: Rework object handling
  4. View patch

[patch 09/25] debugobjects: Make debug_objects_enabled bool

Thomas Gleixner posted 25 patches 1 month, 3 weeks ago
[patch 09/25] debugobjects: Make debug_objects_enabled bool
Posted by Thomas Gleixner 1 month, 3 weeks ago 
Make it what it is.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 lib/debugobjects.c |   17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -82,7 +82,7 @@ static int __data_racy			debug_objects_m
 static int __data_racy __maybe_unused	debug_objects_maxchecked __read_mostly;
 static int __data_racy			debug_objects_fixups __read_mostly;
 static int __data_racy			debug_objects_warnings __read_mostly;
-static int __data_racy			debug_objects_enabled __read_mostly
+static bool __data_racy			debug_objects_enabled __read_mostly
 					= CONFIG_DEBUG_OBJECTS_ENABLE_DEFAULT;
 static int				debug_objects_pool_size __ro_after_init
 					= ODEBUG_POOL_SIZE;
@@ -103,17 +103,16 @@ static DECLARE_DELAYED_WORK(debug_obj_wo
 
 static int __init enable_object_debug(char *str)
 {
-	debug_objects_enabled = 1;
+	debug_objects_enabled = true;
 	return 0;
 }
+early_param("debug_objects", enable_object_debug);
 
 static int __init disable_object_debug(char *str)
 {
-	debug_objects_enabled = 0;
+	debug_objects_enabled = false;
 	return 0;
 }
-
-early_param("debug_objects", enable_object_debug);
 early_param("no_debug_objects", disable_object_debug);
 
 static const char *obj_states[ODEBUG_STATE_MAX] = {
@@ -592,7 +591,7 @@ static struct debug_obj *lookup_object_o
 	}
 
 	/* Out of memory. Do the cleanup outside of the locked region */
-	debug_objects_enabled = 0;
+	debug_objects_enabled = false;
 	return NULL;
 }
 
@@ -1194,7 +1193,7 @@ check_results(void *addr, enum debug_obj
 out:
 	raw_spin_unlock_irqrestore(&db->lock, flags);
 	if (res)
-		debug_objects_enabled = 0;
+		debug_objects_enabled = false;
 	return res;
 }
 
@@ -1278,7 +1277,7 @@ static bool __init debug_objects_selftes
 	descr_test = NULL;
 
 	local_irq_restore(flags);
-	return !!debug_objects_enabled;
+	return debug_objects_enabled;
 }
 #else
 static inline bool debug_objects_selftest(void) { return true; }
@@ -1372,7 +1371,7 @@ void __init debug_objects_mem_init(void)
 				  SLAB_DEBUG_OBJECTS | SLAB_NOLEAKTRACE, NULL);
 
 	if (!cache || !debug_objects_replace_static_objects(cache)) {
-		debug_objects_enabled = 0;
+		debug_objects_enabled = false;
 		pr_warn("Out of memory.\n");
 		return;
 	}
Re: [patch 09/25] debugobjects: Make debug_objects_enabled bool
Posted by Leizhen (ThunderTown) 1 month, 2 weeks ago 

On 2024/10/8 0:50, Thomas Gleixner wrote:
> Make it what it is.

Reviewed-by: Zhen Lei <thunder.leizhen@huawei.com>

> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  lib/debugobjects.c |   17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 
> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
> @@ -82,7 +82,7 @@ static int __data_racy			debug_objects_m
>  static int __data_racy __maybe_unused	debug_objects_maxchecked __read_mostly;
>  static int __data_racy			debug_objects_fixups __read_mostly;
>  static int __data_racy			debug_objects_warnings __read_mostly;
> -static int __data_racy			debug_objects_enabled __read_mostly
> +static bool __data_racy			debug_objects_enabled __read_mostly
>  					= CONFIG_DEBUG_OBJECTS_ENABLE_DEFAULT;
>  static int				debug_objects_pool_size __ro_after_init
>  					= ODEBUG_POOL_SIZE;
> @@ -103,17 +103,16 @@ static DECLARE_DELAYED_WORK(debug_obj_wo
>  
>  static int __init enable_object_debug(char *str)
>  {
> -	debug_objects_enabled = 1;
> +	debug_objects_enabled = true;
>  	return 0;
>  }
> +early_param("debug_objects", enable_object_debug);
>  
>  static int __init disable_object_debug(char *str)
>  {
> -	debug_objects_enabled = 0;
> +	debug_objects_enabled = false;
>  	return 0;
>  }
> -
> -early_param("debug_objects", enable_object_debug);
>  early_param("no_debug_objects", disable_object_debug);
>  
>  static const char *obj_states[ODEBUG_STATE_MAX] = {
> @@ -592,7 +591,7 @@ static struct debug_obj *lookup_object_o
>  	}
>  
>  	/* Out of memory. Do the cleanup outside of the locked region */
> -	debug_objects_enabled = 0;
> +	debug_objects_enabled = false;
>  	return NULL;
>  }
>  
> @@ -1194,7 +1193,7 @@ check_results(void *addr, enum debug_obj
>  out:
>  	raw_spin_unlock_irqrestore(&db->lock, flags);
>  	if (res)
> -		debug_objects_enabled = 0;
> +		debug_objects_enabled = false;
>  	return res;
>  }
>  
> @@ -1278,7 +1277,7 @@ static bool __init debug_objects_selftes
>  	descr_test = NULL;
>  
>  	local_irq_restore(flags);
> -	return !!debug_objects_enabled;
> +	return debug_objects_enabled;
>  }
>  #else
>  static inline bool debug_objects_selftest(void) { return true; }
> @@ -1372,7 +1371,7 @@ void __init debug_objects_mem_init(void)
>  				  SLAB_DEBUG_OBJECTS | SLAB_NOLEAKTRACE, NULL);
>  
>  	if (!cache || !debug_objects_replace_static_objects(cache)) {
> -		debug_objects_enabled = 0;
> +		debug_objects_enabled = false;
>  		pr_warn("Out of memory.\n");
>  		return;
>  	}
> 
> .
> 

-- 
Regards,
  Zhen Lei
[tip: core/debugobjects] debugobjects: Make debug_objects_enabled bool
Posted by tip-bot2 for Thomas Gleixner 1 month, 1 week ago 
The following commit has been merged into the core/debugobjects branch of tip:

Commit-ID:     661cc28b523d4616a322c8f82f06ec7880192060
Gitweb:        https://git.kernel.org/tip/661cc28b523d4616a322c8f82f06ec7880192060
Author:        Thomas Gleixner <tglx@linutronix.de>
AuthorDate:    Mon, 07 Oct 2024 18:50:02 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 15 Oct 2024 17:30:31 +02:00

debugobjects: Make debug_objects_enabled bool

Make it what it is.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/all/20241007164913.518175013@linutronix.de

---
 lib/debugobjects.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 6ccdfeb..0d69095 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -82,7 +82,7 @@ static int __data_racy			debug_objects_maxchain __read_mostly;
 static int __data_racy __maybe_unused	debug_objects_maxchecked __read_mostly;
 static int __data_racy			debug_objects_fixups __read_mostly;
 static int __data_racy			debug_objects_warnings __read_mostly;
-static int __data_racy			debug_objects_enabled __read_mostly
+static bool __data_racy			debug_objects_enabled __read_mostly
 					= CONFIG_DEBUG_OBJECTS_ENABLE_DEFAULT;
 static int				debug_objects_pool_size __ro_after_init
 					= ODEBUG_POOL_SIZE;
@@ -103,17 +103,16 @@ static DECLARE_DELAYED_WORK(debug_obj_work, free_obj_work);
 
 static int __init enable_object_debug(char *str)
 {
-	debug_objects_enabled = 1;
+	debug_objects_enabled = true;
 	return 0;
 }
+early_param("debug_objects", enable_object_debug);
 
 static int __init disable_object_debug(char *str)
 {
-	debug_objects_enabled = 0;
+	debug_objects_enabled = false;
 	return 0;
 }
-
-early_param("debug_objects", enable_object_debug);
 early_param("no_debug_objects", disable_object_debug);
 
 static const char *obj_states[ODEBUG_STATE_MAX] = {
@@ -592,7 +591,7 @@ static struct debug_obj *lookup_object_or_alloc(void *addr, struct debug_bucket 
 	}
 
 	/* Out of memory. Do the cleanup outside of the locked region */
-	debug_objects_enabled = 0;
+	debug_objects_enabled = false;
 	return NULL;
 }
 
@@ -1194,7 +1193,7 @@ check_results(void *addr, enum debug_obj_state state, int fixups, int warnings)
 out:
 	raw_spin_unlock_irqrestore(&db->lock, flags);
 	if (res)
-		debug_objects_enabled = 0;
+		debug_objects_enabled = false;
 	return res;
 }
 
@@ -1278,7 +1277,7 @@ out:
 	descr_test = NULL;
 
 	local_irq_restore(flags);
-	return !!debug_objects_enabled;
+	return debug_objects_enabled;
 }
 #else
 static inline bool debug_objects_selftest(void) { return true; }
@@ -1372,7 +1371,7 @@ void __init debug_objects_mem_init(void)
 				  SLAB_DEBUG_OBJECTS | SLAB_NOLEAKTRACE, NULL);
 
 	if (!cache || !debug_objects_replace_static_objects(cache)) {
-		debug_objects_enabled = 0;
+		debug_objects_enabled = false;
 		pr_warn("Out of memory.\n");
 		return;
 	}

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.