debugobjects: Rework object handling

[patch 07/25] debugobjects: Remove pointless debug printk

Posted by Thomas Gleixner 1 month, 3 weeks ago

It has zero value.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 lib/debugobjects.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -1303,7 +1303,7 @@ static bool __init debug_objects_replace
 	struct debug_obj *obj, *new;
 	struct hlist_node *tmp;
 	HLIST_HEAD(objects);
-	int i, cnt = 0;
+	int i;
 
 	for (i = 0; i < ODEBUG_POOL_SIZE; i++) {
 		obj = kmem_cache_zalloc(cache, GFP_KERNEL);
@@ -1330,11 +1330,8 @@ static bool __init debug_objects_replace
 			/* copy object data */
 			*new = *obj;
 			hlist_add_head(&new->node, &db->list);
-			cnt++;
 		}
 	}
-
-	pr_debug("%d of %d active objects replaced\n", cnt, obj_pool_used);
 	return true;
 free:
 	hlist_for_each_entry_safe(obj, tmp, &objects, node) {

Re: [patch 07/25] debugobjects: Remove pointless debug printk

Posted by Leizhen (ThunderTown) 1 month, 2 weeks ago


On 2024/10/8 0:49, Thomas Gleixner wrote:
> It has zero value.

Reviewed-by: Zhen Lei <thunder.leizhen@huawei.com>

> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  lib/debugobjects.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
> @@ -1303,7 +1303,7 @@ static bool __init debug_objects_replace
>  	struct debug_obj *obj, *new;
>  	struct hlist_node *tmp;
>  	HLIST_HEAD(objects);
> -	int i, cnt = 0;
> +	int i;
>  
>  	for (i = 0; i < ODEBUG_POOL_SIZE; i++) {
>  		obj = kmem_cache_zalloc(cache, GFP_KERNEL);
> @@ -1330,11 +1330,8 @@ static bool __init debug_objects_replace
>  			/* copy object data */
>  			*new = *obj;
>  			hlist_add_head(&new->node, &db->list);
> -			cnt++;
>  		}
>  	}
> -
> -	pr_debug("%d of %d active objects replaced\n", cnt, obj_pool_used);
>  	return true;
>  free:
>  	hlist_for_each_entry_safe(obj, tmp, &objects, node) {
> 
> .
> 

-- 
Regards,
  Zhen Lei

[tip: core/debugobjects] debugobjects: Remove pointless debug printk

Posted by tip-bot2 for Thomas Gleixner 1 month, 1 week ago

The following commit has been merged into the core/debugobjects branch of tip:

Commit-ID:     241463f4fdcc845fa4a174e63a23940305cb6691
Gitweb:        https://git.kernel.org/tip/241463f4fdcc845fa4a174e63a23940305cb6691
Author:        Thomas Gleixner <tglx@linutronix.de>
AuthorDate:    Mon, 07 Oct 2024 18:49:59 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 15 Oct 2024 17:30:31 +02:00

debugobjects: Remove pointless debug printk

It has zero value.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/all/20241007164913.390511021@linutronix.de

---
 lib/debugobjects.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 2c866d0..fc54115 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -1303,7 +1303,7 @@ static bool __init debug_objects_replace_static_objects(struct kmem_cache *cache
 	struct debug_obj *obj, *new;
 	struct hlist_node *tmp;
 	HLIST_HEAD(objects);
-	int i, cnt = 0;
+	int i;
 
 	for (i = 0; i < ODEBUG_POOL_SIZE; i++) {
 		obj = kmem_cache_zalloc(cache, GFP_KERNEL);
@@ -1330,11 +1330,8 @@ static bool __init debug_objects_replace_static_objects(struct kmem_cache *cache
 			/* copy object data */
 			*new = *obj;
 			hlist_add_head(&new->node, &db->list);
-			cnt++;
 		}
 	}
-
-	pr_debug("%d of %d active objects replaced\n", cnt, obj_pool_used);
 	return true;
 free:
 	hlist_for_each_entry_safe(obj, tmp, &objects, node) {