[v1] dt-bindings: leds: Document "rc-feedback" trigger

[PATCH] dt-bindings: leds: Document "rc-feedback" trigger

Posted by Heiko Stuebner 1 month, 3 weeks ago

Document the "rc-feedback" trigger which is used to control LEDs by
remote control device activity. This is an existing trigger used in
existing DTs, document it so validation of those DTs would pass.

It was originally introduced into the Linux kernel in 2013 with
commit 153a60bb0fac ("[media] rc: add feedback led trigger for rc keypresses")

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 Documentation/devicetree/bindings/leds/common.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index bf9a101e4d42..32f9116e03a2 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -119,6 +119,8 @@ properties:
             # if trigger is absent
           - none
             # LED indicates camera torch state
+          - rc-feedback
+            # LED indicates remote control feedback
           - torch
             # LED indicates USB gadget activity
           - usb-gadget
-- 
2.43.0

Re: [PATCH] dt-bindings: leds: Document "rc-feedback" trigger

Posted by Pavel Machek 1 month, 3 weeks ago

On Mon 2024-10-07 18:08:04, Heiko Stuebner wrote:
> Document the "rc-feedback" trigger which is used to control LEDs by
> remote control device activity. This is an existing trigger used in
> existing DTs, document it so validation of those DTs would pass.
> 
> It was originally introduced into the Linux kernel in 2013 with
> commit 153a60bb0fac ("[media] rc: add feedback led trigger for rc keypresses")

> index bf9a101e4d42..32f9116e03a2 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -119,6 +119,8 @@ properties:
>              # if trigger is absent
>            - none
>              # LED indicates camera torch state
> +          - rc-feedback
> +            # LED indicates remote control feedback
>            - torch
>              # LED indicates USB gadget activity
>            - usb-gadget

NAK. Wrongly placed comment.
							Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Re: [PATCH] dt-bindings: leds: Document "rc-feedback" trigger

Posted by Heiko Stübner 1 month, 2 weeks ago

Am Montag, 7. Oktober 2024, 20:01:27 CEST schrieb Pavel Machek:
> On Mon 2024-10-07 18:08:04, Heiko Stuebner wrote:
> > Document the "rc-feedback" trigger which is used to control LEDs by
> > remote control device activity. This is an existing trigger used in
> > existing DTs, document it so validation of those DTs would pass.
> > 
> > It was originally introduced into the Linux kernel in 2013 with
> > commit 153a60bb0fac ("[media] rc: add feedback led trigger for rc keypresses")
> 
> > index bf9a101e4d42..32f9116e03a2 100644
> > --- a/Documentation/devicetree/bindings/leds/common.yaml
> > +++ b/Documentation/devicetree/bindings/leds/common.yaml
> > @@ -119,6 +119,8 @@ properties:
> >              # if trigger is absent
> >            - none
> >              # LED indicates camera torch state
> > +          - rc-feedback
> > +            # LED indicates remote control feedback
> >            - torch
> >              # LED indicates USB gadget activity
> >            - usb-gadget
> 
> NAK. Wrongly placed comment.

you're right, and it even messed up the torch comment + entry
Will send a v2

Heiko