[v1] Add support for stm32mp25x RNG

[PATCH 4/4] arm64: dts: st: add RNG node on stm32mp251

Posted by Gatien Chevallier 1 month, 3 weeks ago

Update the device-tree stm32mp251.dtsi by adding the Random Number
Generator(RNG) node.

Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
---
 arch/arm64/boot/dts/st/stm32mp251.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
index 1167cf63d7e8..40b96353a803 100644
--- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
+++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
@@ -493,6 +493,16 @@ uart8: serial@40380000 {
 				status = "disabled";
 			};
 
+			rng: rng@42020000 {
+				compatible = "st,stm32mp25-rng";
+				reg = <0x42020000 0x400>;
+				clocks = <&clk_rcbsec>, <&rcc CK_BUS_RNG>;
+				clock-names = "rng_clk", "rng_hclk";
+				resets = <&rcc RNG_R>;
+				access-controllers = <&rifsc 92>;
+				status = "disabled";
+			};
+
 			spi8: spi@46020000 {
 				#address-cells = <1>;
 				#size-cells = <0>;
-- 
2.25.1

Re: [PATCH 4/4] arm64: dts: st: add RNG node on stm32mp251

Posted by Marek Vasut 1 month, 3 weeks ago

On 10/7/24 3:27 PM, Gatien Chevallier wrote:
> Update the device-tree stm32mp251.dtsi by adding the Random Number
> Generator(RNG) node.
> 
> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
> ---
>   arch/arm64/boot/dts/st/stm32mp251.dtsi | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> index 1167cf63d7e8..40b96353a803 100644
> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> @@ -493,6 +493,16 @@ uart8: serial@40380000 {
>   				status = "disabled";
>   			};
>   
> +			rng: rng@42020000 {
> +				compatible = "st,stm32mp25-rng";
> +				reg = <0x42020000 0x400>;
> +				clocks = <&clk_rcbsec>, <&rcc CK_BUS_RNG>;
> +				clock-names = "rng_clk", "rng_hclk";
> +				resets = <&rcc RNG_R>;
> +				access-controllers = <&rifsc 92>;
It would be good if someone finally sorted the access-controllers 
property in all the MP2 nodes alphabetically ; that's separate 
patch/series though.

Re: [PATCH 4/4] arm64: dts: st: add RNG node on stm32mp251

Posted by Gatien CHEVALLIER 1 month, 3 weeks ago


On 10/7/24 15:55, Marek Vasut wrote:
> On 10/7/24 3:27 PM, Gatien Chevallier wrote:
>> Update the device-tree stm32mp251.dtsi by adding the Random Number
>> Generator(RNG) node.
>>
>> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
>> ---
>>   arch/arm64/boot/dts/st/stm32mp251.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi 
>> b/arch/arm64/boot/dts/st/stm32mp251.dtsi
>> index 1167cf63d7e8..40b96353a803 100644
>> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
>> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
>> @@ -493,6 +493,16 @@ uart8: serial@40380000 {
>>                   status = "disabled";
>>               };
>> +            rng: rng@42020000 {
>> +                compatible = "st,stm32mp25-rng";
>> +                reg = <0x42020000 0x400>;
>> +                clocks = <&clk_rcbsec>, <&rcc CK_BUS_RNG>;
>> +                clock-names = "rng_clk", "rng_hclk";
>> +                resets = <&rcc RNG_R>;
>> +                access-controllers = <&rifsc 92>;
> It would be good if someone finally sorted the access-controllers 
> property in all the MP2 nodes alphabetically ; that's separate 
> patch/series though.

I'll pin your comment to take a look into that in the near future.

Gatien

Re: [PATCH 4/4] arm64: dts: st: add RNG node on stm32mp251

Posted by Marek Vasut 1 month, 3 weeks ago

On 10/7/24 4:59 PM, Gatien CHEVALLIER wrote:
> 
> 
> On 10/7/24 15:55, Marek Vasut wrote:
>> On 10/7/24 3:27 PM, Gatien Chevallier wrote:
>>> Update the device-tree stm32mp251.dtsi by adding the Random Number
>>> Generator(RNG) node.
>>>
>>> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
>>> ---
>>>   arch/arm64/boot/dts/st/stm32mp251.dtsi | 10 ++++++++++
>>>   1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/ 
>>> boot/dts/st/stm32mp251.dtsi
>>> index 1167cf63d7e8..40b96353a803 100644
>>> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
>>> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
>>> @@ -493,6 +493,16 @@ uart8: serial@40380000 {
>>>                   status = "disabled";
>>>               };
>>> +            rng: rng@42020000 {
>>> +                compatible = "st,stm32mp25-rng";
>>> +                reg = <0x42020000 0x400>;
>>> +                clocks = <&clk_rcbsec>, <&rcc CK_BUS_RNG>;
>>> +                clock-names = "rng_clk", "rng_hclk";
>>> +                resets = <&rcc RNG_R>;
>>> +                access-controllers = <&rifsc 92>;
>> It would be good if someone finally sorted the access-controllers 
>> property in all the MP2 nodes alphabetically ; that's separate patch/ 
>> series though.
> 
> I'll pin your comment to take a look into that in the near future.
Thank you !