1. Patchew
  2. linux
  3. [PATCH 0/3] iio: light: veml6030: add support for veml7700
  4. View patch

[PATCH 2/3] dt-bindings: iio: light: veml6030: add veml7700

Javier Carrasco posted 3 patches 1 month, 3 weeks ago
[PATCH 2/3] dt-bindings: iio: light: veml6030: add veml7700
Posted by Javier Carrasco 1 month, 3 weeks ago 
The veml7700 contains the same chip as the veml6030 in a different
package with no interrupt line and no pin to select the I2C address,
which makes it suitable to be supported by the same bindings.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 .../devicetree/bindings/iio/light/vishay,veml6030.yaml   | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
index 6218273b0e86..53b55575efd3 100644
--- a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
+++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
@@ -4,7 +4,7 @@
 $id: http://devicetree.org/schemas/iio/light/vishay,veml6030.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: VEML6030 and VEML6035 Ambient Light Sensors (ALS)
+title: VEML6030, VEML6035 and VEML7700 Ambient Light Sensors (ALS)
 
 maintainers:
   - Rishi Gupta <gupt21@gmail.com>
@@ -22,12 +22,14 @@ description: |
   Specifications about the sensors can be found at:
     https://www.vishay.com/docs/84366/veml6030.pdf
     https://www.vishay.com/docs/84889/veml6035.pdf
+    https://www.vishay.com/docs/84286/veml7700.pdf
 
 properties:
   compatible:
     enum:
       - vishay,veml6030
       - vishay,veml6035
+      - vishay,veml7700
 
   reg:
     maxItems: 1
@@ -70,6 +72,18 @@ allOf:
           enum:
             - 0x29
 
+  - if:
+      properties:
+        compatible:
+          enum:
+            - vishay,veml7700
+    then:
+      properties:
+        reg:
+          enum:
+            - 0x10
+        interrupts: false
+
 additionalProperties: false
 
 examples:

-- 
2.43.0
Re: [PATCH 2/3] dt-bindings: iio: light: veml6030: add veml7700
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago 
On Mon, Oct 07, 2024 at 10:36:37PM +0200, Javier Carrasco wrote:
> The veml7700 contains the same chip as the veml6030 in a different
> package with no interrupt line and no pin to select the I2C address,
> which makes it suitable to be supported by the same bindings.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
>  .../devicetree/bindings/iio/light/vishay,veml6030.yaml   | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH 2/3] dt-bindings: iio: light: veml6030: add veml7700
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago 
On Mon, Oct 07, 2024 at 10:36:37PM +0200, Javier Carrasco wrote:
> The veml7700 contains the same chip as the veml6030 in a different
> package with no interrupt line and no pin to select the I2C address,
> which makes it suitable to be supported by the same bindings.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
>  .../devicetree/bindings/iio/light/vishay,veml6030.yaml   | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
> index 6218273b0e86..53b55575efd3 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml

There is no such file in next.

Best regards,
Krzysztof
Re: [PATCH 2/3] dt-bindings: iio: light: veml6030: add veml7700
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago 
On 08/10/2024 09:56, Krzysztof Kozlowski wrote:
> On Mon, Oct 07, 2024 at 10:36:37PM +0200, Javier Carrasco wrote:
>> The veml7700 contains the same chip as the veml6030 in a different
>> package with no interrupt line and no pin to select the I2C address,
>> which makes it suitable to be supported by the same bindings.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
>> ---
>>  .../devicetree/bindings/iio/light/vishay,veml6030.yaml   | 16 +++++++++++++++-
>>  1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
>> index 6218273b0e86..53b55575efd3 100644
>> --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
>> +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
> 
> There is no such file in next.

There was no in next from 4th of October, but I found it now. However
the diff chunks still do not fit. It seems you are sending multiple,
related patches. Organize your entire work in one patchset, so big
picture will be visible and any dependencies will be clear.

Best regards,
Krzysztof
Re: [PATCH 2/3] dt-bindings: iio: light: veml6030: add veml7700
Posted by Javier Carrasco 1 month, 2 weeks ago 
On 08/10/2024 10:01, Krzysztof Kozlowski wrote:
> On 08/10/2024 09:56, Krzysztof Kozlowski wrote:
>> On Mon, Oct 07, 2024 at 10:36:37PM +0200, Javier Carrasco wrote:
>>> The veml7700 contains the same chip as the veml6030 in a different
>>> package with no interrupt line and no pin to select the I2C address,
>>> which makes it suitable to be supported by the same bindings.
>>>
>>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
>>> ---
>>>  .../devicetree/bindings/iio/light/vishay,veml6030.yaml   | 16 +++++++++++++++-
>>>  1 file changed, 15 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
>>> index 6218273b0e86..53b55575efd3 100644
>>> --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
>>> +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
>>
>> There is no such file in next.
> 
> There was no in next from 4th of October, but I found it now. However
> the diff chunks still do not fit. It seems you are sending multiple,
> related patches. Organize your entire work in one patchset, so big
> picture will be visible and any dependencies will be clear.
> 
> Best regards,
> Krzysztof
> 


Hi Krzysztof,

this series uses iio/testing as its base, as it requires patches that
were applied to that branch. Apparently, they are not available in next,
and that is the reason why the diff chunks don't fit.

b4 automatically provides the base-id in the cover later, but I
understand that you are not expecting a commit-id from the iio tree as
the base to apply this patch. Sorry for that, I will rebase onto next as
soon as the required patches are there as well.

Best regards,
Javier Carrasco

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.