[v2] pinctrl: th1520: Improve code quality

[PATCH v2 0/3] pinctrl: th1520: Improve code quality

Drew Fustini posted 3 patches 1 month, 3 weeks ago

Diff against v1 v3
Download series mbox

There is a newer version of this series

drivers/pinctrl/pinctrl-th1520.c | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)

Expand all Fold all

[PATCH v2 0/3] pinctrl: th1520: Improve code quality

Posted by Drew Fustini 1 month, 3 weeks ago

This series contains code quality improvements for the new TH1520
pinctrl driver [1]:

 - Fix smatch warning that the return value is not correctly set when an
   unknown pin error occurs
 - Linus suggested using guarded mutexs so I've converted the thp->mutex
   lock to that usage.
 - Linus also suggested using a scoped iterator for the DT for-each
   child node loop: for_each_available_child_of_node_scoped.

The series is based on the linusw devel branch [2].

[1] https://lore.kernel.org/lkml/CACRpkdavPAv2sPRREQhx_A7EtOj6Ld_n+NcO+vH0QCnfVedXKw@mail.gmail.com/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel

Changes since v1:
- Move the scoped iterator conversion to a separate patch and remove the
  child put operations as they are no longer needed
- Link: https://lore.kernel.org/lkml/20241005-th1520-pinctrl-fixes-v1-0-5c65dffa0d00@tenstorrent.com/

Signed-off-by: Drew Fustini <dfustini@tenstorrent.com>
---
Drew Fustini (3):
      pinctrl: th1520: Fix return value for unknown pin error
      pinctrl: th1520: Convert thp->mutex to guarded mutex
      pinctrl: th1520: Convert dt child node loop to scoped iterator

 drivers/pinctrl/pinctrl-th1520.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)
---
base-commit: 2694868880705e8f6bb61b24b1b25adc42a4a217
change-id: 20241005-th1520-pinctrl-fixes-d20db68387e6

Best regards,
-- 
Drew Fustini <dfustini@tenstorrent.com>