selftests: make kselftest-clean remove libynl outputs

[PATCH] selftests: make kselftest-clean remove libynl outputs

Posted by Greg Thelen 1 month, 3 weeks ago

Starting with 6.12 commit 85585b4bc8d8 ("selftests: add ncdevmem, netcat
for devmem TCP") kselftest-all creates additional outputs that
kselftest-clean does not cleanup:
  $ make defconfig
  $ make kselftest-all
  $ make kselftest-clean
  $ git clean -ndxf | grep tools/net
  Would remove tools/net/ynl/lib/__pycache__/
  Would remove tools/net/ynl/lib/ynl.a
  Would remove tools/net/ynl/lib/ynl.d
  Would remove tools/net/ynl/lib/ynl.o

Make kselftest-clean remove the newly added net/ynl outputs.

Fixes: 85585b4bc8d8 ("selftests: add ncdevmem, netcat for devmem TCP")
Signed-off-by: Greg Thelen <gthelen@google.com>
---
 tools/testing/selftests/net/ynl.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/net/ynl.mk b/tools/testing/selftests/net/ynl.mk
index 59cb26cf3f73..1ef24119def0 100644
--- a/tools/testing/selftests/net/ynl.mk
+++ b/tools/testing/selftests/net/ynl.mk
@@ -19,3 +19,7 @@ $(YNL_OUTPUTS): CFLAGS += \
 $(OUTPUT)/libynl.a:
 	$(Q)$(MAKE) -C $(top_srcdir)/tools/net/ynl GENS="$(YNL_GENS)" libynl.a
 	$(Q)cp $(top_srcdir)/tools/net/ynl/libynl.a $(OUTPUT)/libynl.a
+
+EXTRA_CLEAN += \
+	$(top_srcdir)/tools/net/ynl/lib/__pycache__ \
+	$(top_srcdir)/tools/net/ynl/lib/*.[ado]
-- 
2.47.0.rc0.187.ge670bccf7e-goog

Re: [PATCH] selftests: make kselftest-clean remove libynl outputs

Posted by Mina Almasry 1 month, 2 weeks ago

On Sat, Oct 5, 2024 at 2:56 PM Greg Thelen <gthelen@google.com> wrote:
>
> Starting with 6.12 commit 85585b4bc8d8 ("selftests: add ncdevmem, netcat
> for devmem TCP") kselftest-all creates additional outputs that
> kselftest-clean does not cleanup:
>   $ make defconfig
>   $ make kselftest-all
>   $ make kselftest-clean
>   $ git clean -ndxf | grep tools/net
>   Would remove tools/net/ynl/lib/__pycache__/
>   Would remove tools/net/ynl/lib/ynl.a
>   Would remove tools/net/ynl/lib/ynl.d
>   Would remove tools/net/ynl/lib/ynl.o
>
> Make kselftest-clean remove the newly added net/ynl outputs.
>
> Fixes: 85585b4bc8d8 ("selftests: add ncdevmem, netcat for devmem TCP")

Probably moot since this is merged already (sorry for the delay), but
likely it's:

Fixes: 07c3cc51a085 ("tools: net: package libynl for use in selftests")

The referenced patch doesn't touch ynl.mk, but adds a dependency on it

> Signed-off-by: Greg Thelen <gthelen@google.com>

Thank you Greg,

Reviewed-by: Mina Almasry <almasrymina@google.com>



-- 
Thanks,
Mina

Re: [PATCH] selftests: make kselftest-clean remove libynl outputs

Posted by Guenter Roeck 1 month, 2 weeks ago

On Sat, Oct 05, 2024 at 02:56:00PM -0700, Greg Thelen wrote:
> Starting with 6.12 commit 85585b4bc8d8 ("selftests: add ncdevmem, netcat
> for devmem TCP") kselftest-all creates additional outputs that
> kselftest-clean does not cleanup:
>   $ make defconfig
>   $ make kselftest-all
>   $ make kselftest-clean
>   $ git clean -ndxf | grep tools/net
>   Would remove tools/net/ynl/lib/__pycache__/
>   Would remove tools/net/ynl/lib/ynl.a
>   Would remove tools/net/ynl/lib/ynl.d
>   Would remove tools/net/ynl/lib/ynl.o
> 
> Make kselftest-clean remove the newly added net/ynl outputs.
> 
> Fixes: 85585b4bc8d8 ("selftests: add ncdevmem, netcat for devmem TCP")
> Signed-off-by: Greg Thelen <gthelen@google.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH] selftests: make kselftest-clean remove libynl outputs

Posted by Muhammad Usama Anjum 1 month, 3 weeks ago

On 10/6/24 2:56 AM, Greg Thelen wrote:
> Starting with 6.12 commit 85585b4bc8d8 ("selftests: add ncdevmem, netcat
> for devmem TCP") kselftest-all creates additional outputs that
> kselftest-clean does not cleanup:
>   $ make defconfig
>   $ make kselftest-all
>   $ make kselftest-clean
>   $ git clean -ndxf | grep tools/net
>   Would remove tools/net/ynl/lib/__pycache__/
>   Would remove tools/net/ynl/lib/ynl.a
>   Would remove tools/net/ynl/lib/ynl.d
>   Would remove tools/net/ynl/lib/ynl.o
> 
> Make kselftest-clean remove the newly added net/ynl outputs.
> 
> Fixes: 85585b4bc8d8 ("selftests: add ncdevmem, netcat for devmem TCP")
> Signed-off-by: Greg Thelen <gthelen@google.com>
> ---
>  tools/testing/selftests/net/ynl.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/ynl.mk b/tools/testing/selftests/net/ynl.mk
> index 59cb26cf3f73..1ef24119def0 100644
> --- a/tools/testing/selftests/net/ynl.mk
> +++ b/tools/testing/selftests/net/ynl.mk
> @@ -19,3 +19,7 @@ $(YNL_OUTPUTS): CFLAGS += \
>  $(OUTPUT)/libynl.a:
>  	$(Q)$(MAKE) -C $(top_srcdir)/tools/net/ynl GENS="$(YNL_GENS)" libynl.a
>  	$(Q)cp $(top_srcdir)/tools/net/ynl/libynl.a $(OUTPUT)/libynl.a
> +
> +EXTRA_CLEAN += \
> +	$(top_srcdir)/tools/net/ynl/lib/__pycache__ \
> +	$(top_srcdir)/tools/net/ynl/lib/*.[ado]
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

-- 
BR,
Muhammad Usama Anjum