drivers/dma: Fix unsigned compared against 0

[PATCH] drivers/dma: Fix unsigned compared against 0

Posted by Advait Dhamorikar 1 year, 4 months ago

An unsigned value can never be negative,
so this test will always evaluate the same way.
In ep93xx_dma_alloc_chan_resources: An unsigned dma_cfg.port's
value is checked against EP93XX_DMA_I2S1 which is 0.

Signed-off-by: Advait Dhamorikar <advaitdhamorikar@gmail.com>
---
 drivers/dma/ep93xx_dma.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
index 995427afe077..6d7f6bd12d76 100644
--- a/drivers/dma/ep93xx_dma.c
+++ b/drivers/dma/ep93xx_dma.c
@@ -929,8 +929,7 @@ static int ep93xx_dma_alloc_chan_resources(struct dma_chan *chan)
 
 	/* Sanity check the channel parameters */
 	if (!edmac->edma->m2m) {
-		if (edmac->dma_cfg.port < EP93XX_DMA_I2S1 ||
-		    edmac->dma_cfg.port > EP93XX_DMA_IRDA)
+		if (edmac->dma_cfg.port > EP93XX_DMA_IRDA)
 			return -EINVAL;
 		if (edmac->dma_cfg.dir != ep93xx_dma_chan_direction(chan))
 			return -EINVAL;
-- 
2.34.1

Re: [PATCH] drivers/dma: Fix unsigned compared against 0

Posted by Vinod Koul 1 year, 3 months ago

On Sat, 05 Oct 2024 15:04:36 +0530, Advait Dhamorikar wrote:
> An unsigned value can never be negative,
> so this test will always evaluate the same way.
> In ep93xx_dma_alloc_chan_resources: An unsigned dma_cfg.port's
> value is checked against EP93XX_DMA_I2S1 which is 0.
> 
> 

Applied, thanks!

[1/1] drivers/dma: Fix unsigned compared against 0
      commit: 0aa4523cdb9683e35af91ebdfae8d2fb4e6c3b8b

Best regards,
-- 
~Vinod

Re: [PATCH] drivers/dma: Fix unsigned compared against 0

Posted by Vinod Koul 1 year, 3 months ago

On 05-10-24, 15:04, Advait Dhamorikar wrote:
> An unsigned value can never be negative,
> so this test will always evaluate the same way.
> In ep93xx_dma_alloc_chan_resources: An unsigned dma_cfg.port's
> value is checked against EP93XX_DMA_I2S1 which is 0.

Please use subject line dmaengine: ... git log will tell you the tags to
use

I am fixing it up and applying

> 
> Signed-off-by: Advait Dhamorikar <advaitdhamorikar@gmail.com>
> ---
>  drivers/dma/ep93xx_dma.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index 995427afe077..6d7f6bd12d76 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -929,8 +929,7 @@ static int ep93xx_dma_alloc_chan_resources(struct dma_chan *chan)
>  
>  	/* Sanity check the channel parameters */
>  	if (!edmac->edma->m2m) {
> -		if (edmac->dma_cfg.port < EP93XX_DMA_I2S1 ||
> -		    edmac->dma_cfg.port > EP93XX_DMA_IRDA)
> +		if (edmac->dma_cfg.port > EP93XX_DMA_IRDA)
>  			return -EINVAL;
>  		if (edmac->dma_cfg.dir != ep93xx_dma_chan_direction(chan))
>  			return -EINVAL;
> -- 
> 2.34.1

-- 
~Vinod