[v3] platform/x86: dell-ddv: Fix typo in documentation

[PATCH v3] platform/x86: dell-ddv: Fix typo in documentation

Posted by Anaswara T Rajan 1 month, 3 weeks ago

Fix typo in word 'diagnostics' in documentation.

Signed-off-by: Anaswara T Rajan <anaswaratrajan@gmail.com>
---
Changes in v2:
  - Make the commit title and description more clearer.

Changes in v3:
  - Add missing full stop to commit description.

 Documentation/wmi/devices/dell-wmi-ddv.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/wmi/devices/dell-wmi-ddv.rst b/Documentation/wmi/devices/dell-wmi-ddv.rst
index 2fcdfcf03327..e0c20af30948 100644
--- a/Documentation/wmi/devices/dell-wmi-ddv.rst
+++ b/Documentation/wmi/devices/dell-wmi-ddv.rst
@@ -8,7 +8,7 @@ Introduction
 ============
 
 Many Dell notebooks made after ~2020 support a WMI-based interface for
-retrieving various system data like battery temperature, ePPID, diagostic data
+retrieving various system data like battery temperature, ePPID, diagnostic data
 and fan/thermal sensor data.
 
 This interface is likely used by the `Dell Data Vault` software on Windows,
@@ -277,7 +277,7 @@ Reverse-Engineering the DDV WMI interface
 4. Try to deduce the meaning of a certain WMI method by comparing the control
    flow with other ACPI methods (_BIX or _BIF for battery related methods
    for example).
-5. Use the built-in UEFI diagostics to view sensor types/values for fan/thermal
+5. Use the built-in UEFI diagnostics to view sensor types/values for fan/thermal
    related methods (sometimes overwriting static ACPI data fields can be used
    to test different sensor type values, since on some machines this data is
    not reinitialized upon a warm reset).
-- 
2.34.1

Re: [PATCH v3] platform/x86: dell-ddv: Fix typo in documentation

Posted by Hans de Goede 1 month, 3 weeks ago

Hi,

On 5-Oct-24 9:00 AM, Anaswara T Rajan wrote:
> Fix typo in word 'diagnostics' in documentation.
> 
> Signed-off-by: Anaswara T Rajan <anaswaratrajan@gmail.com>

Thank you for your patch/series, I've applied this patch
(series) to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in the pdx86 review-hans branch once I've
pushed my local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans




> ---
> Changes in v2:
>   - Make the commit title and description more clearer.
> 
> Changes in v3:
>   - Add missing full stop to commit description.
> 
>  Documentation/wmi/devices/dell-wmi-ddv.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/wmi/devices/dell-wmi-ddv.rst b/Documentation/wmi/devices/dell-wmi-ddv.rst
> index 2fcdfcf03327..e0c20af30948 100644
> --- a/Documentation/wmi/devices/dell-wmi-ddv.rst
> +++ b/Documentation/wmi/devices/dell-wmi-ddv.rst
> @@ -8,7 +8,7 @@ Introduction
>  ============
>  
>  Many Dell notebooks made after ~2020 support a WMI-based interface for
> -retrieving various system data like battery temperature, ePPID, diagostic data
> +retrieving various system data like battery temperature, ePPID, diagnostic data
>  and fan/thermal sensor data.
>  
>  This interface is likely used by the `Dell Data Vault` software on Windows,
> @@ -277,7 +277,7 @@ Reverse-Engineering the DDV WMI interface
>  4. Try to deduce the meaning of a certain WMI method by comparing the control
>     flow with other ACPI methods (_BIX or _BIF for battery related methods
>     for example).
> -5. Use the built-in UEFI diagostics to view sensor types/values for fan/thermal
> +5. Use the built-in UEFI diagnostics to view sensor types/values for fan/thermal
>     related methods (sometimes overwriting static ACPI data fields can be used
>     to test different sensor type values, since on some machines this data is
>     not reinitialized upon a warm reset).

Re: [PATCH v3] platform/x86: dell-ddv: Fix typo in documentation

Posted by Armin Wolf 1 month, 3 weeks ago

Am 05.10.24 um 09:00 schrieb Anaswara T Rajan:

> Fix typo in word 'diagnostics' in documentation.
>
> Signed-off-by: Anaswara T Rajan <anaswaratrajan@gmail.com>

Thanks, for the whole patch:

Reviewed-by: Armin Wolf <W_Armin@gmx.de>

> ---
> Changes in v2:
>    - Make the commit title and description more clearer.
>
> Changes in v3:
>    - Add missing full stop to commit description.
>
>   Documentation/wmi/devices/dell-wmi-ddv.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/wmi/devices/dell-wmi-ddv.rst b/Documentation/wmi/devices/dell-wmi-ddv.rst
> index 2fcdfcf03327..e0c20af30948 100644
> --- a/Documentation/wmi/devices/dell-wmi-ddv.rst
> +++ b/Documentation/wmi/devices/dell-wmi-ddv.rst
> @@ -8,7 +8,7 @@ Introduction
>   ============
>
>   Many Dell notebooks made after ~2020 support a WMI-based interface for
> -retrieving various system data like battery temperature, ePPID, diagostic data
> +retrieving various system data like battery temperature, ePPID, diagnostic data
>   and fan/thermal sensor data.
>
>   This interface is likely used by the `Dell Data Vault` software on Windows,
> @@ -277,7 +277,7 @@ Reverse-Engineering the DDV WMI interface
>   4. Try to deduce the meaning of a certain WMI method by comparing the control
>      flow with other ACPI methods (_BIX or _BIF for battery related methods
>      for example).
> -5. Use the built-in UEFI diagostics to view sensor types/values for fan/thermal
> +5. Use the built-in UEFI diagnostics to view sensor types/values for fan/thermal
>      related methods (sometimes overwriting static ACPI data fields can be used
>      to test different sensor type values, since on some machines this data is
>      not reinitialized upon a warm reset).

Re: [PATCH v3] platform/x86: dell-ddv: Fix typo in documentation

Posted by Armin Wolf 1 month, 3 weeks ago

Am 05.10.24 um 17:12 schrieb Armin Wolf:

> Am 05.10.24 um 09:00 schrieb Anaswara T Rajan:
>
>> Fix typo in word 'diagnostics' in documentation.
>>
>> Signed-off-by: Anaswara T Rajan <anaswaratrajan@gmail.com>
>
> Thanks, for the whole patch:
>
> Reviewed-by: Armin Wolf <W_Armin@gmx.de>
>
I just noticed that the x86 platform driver maintainer where not CCed,
please CC them next time so they get properly notified.
For now, i CCed them myself.

Thanks,
Armin Wolf

>> ---
>> Changes in v2:
>>    - Make the commit title and description more clearer.
>>
>> Changes in v3:
>>    - Add missing full stop to commit description.
>>
>>   Documentation/wmi/devices/dell-wmi-ddv.rst | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/wmi/devices/dell-wmi-ddv.rst
>> b/Documentation/wmi/devices/dell-wmi-ddv.rst
>> index 2fcdfcf03327..e0c20af30948 100644
>> --- a/Documentation/wmi/devices/dell-wmi-ddv.rst
>> +++ b/Documentation/wmi/devices/dell-wmi-ddv.rst
>> @@ -8,7 +8,7 @@ Introduction
>>   ============
>>
>>   Many Dell notebooks made after ~2020 support a WMI-based interface for
>> -retrieving various system data like battery temperature, ePPID,
>> diagostic data
>> +retrieving various system data like battery temperature, ePPID,
>> diagnostic data
>>   and fan/thermal sensor data.
>>
>>   This interface is likely used by the `Dell Data Vault` software on
>> Windows,
>> @@ -277,7 +277,7 @@ Reverse-Engineering the DDV WMI interface
>>   4. Try to deduce the meaning of a certain WMI method by comparing
>> the control
>>      flow with other ACPI methods (_BIX or _BIF for battery related
>> methods
>>      for example).
>> -5. Use the built-in UEFI diagostics to view sensor types/values for
>> fan/thermal
>> +5. Use the built-in UEFI diagnostics to view sensor types/values for
>> fan/thermal
>>      related methods (sometimes overwriting static ACPI data fields
>> can be used
>>      to test different sensor type values, since on some machines
>> this data is
>>      not reinitialized upon a warm reset).
>