bpf, lsm: Remove bpf_lsm_key_free hook

[PATCH] bpf, lsm: Remove bpf_lsm_key_free hook

Posted by Thomas Weißschuh 1 month, 3 weeks ago

The key_free LSM hook has been removed.
Remove the corresponding BPF hook.

Avoid warnings during the build:
  BTFIDS  vmlinux
WARN: resolve_btfids: unresolved symbol bpf_lsm_key_free

Fixes: 5f8d28f6d7d5 ("lsm: infrastructure management of the key security blob")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
I don't know much about LSMs, so please disregard if this is wrong.
---
 kernel/bpf/bpf_lsm.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/kernel/bpf/bpf_lsm.c b/kernel/bpf/bpf_lsm.c
index 6292ac5f9bd139dafb39ecd8bb180be46cd7c7fd..3bc61628ab251e05d7837eb27dabc3b62bcc4783 100644
--- a/kernel/bpf/bpf_lsm.c
+++ b/kernel/bpf/bpf_lsm.c
@@ -339,10 +339,6 @@ BTF_ID(func, bpf_lsm_path_chmod)
 BTF_ID(func, bpf_lsm_path_chown)
 #endif /* CONFIG_SECURITY_PATH */
 
-#ifdef CONFIG_KEYS
-BTF_ID(func, bpf_lsm_key_free)
-#endif /* CONFIG_KEYS */
-
 BTF_ID(func, bpf_lsm_mmap_file)
 BTF_ID(func, bpf_lsm_netlink_send)
 BTF_ID(func, bpf_lsm_path_notify)

---
base-commit: 0c559323bbaabee7346c12e74b497e283aaafef5
change-id: 20241005-lsm-key_free-b47445ee523d

Best regards,
-- 
Thomas Weißschuh <linux@weissschuh.net>

Re: [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook

Posted by Jiri Olsa 1 month, 3 weeks ago

On Sat, Oct 05, 2024 at 02:06:28AM +0200, Thomas Weißschuh wrote:
> The key_free LSM hook has been removed.
> Remove the corresponding BPF hook.
> 
> Avoid warnings during the build:
>   BTFIDS  vmlinux
> WARN: resolve_btfids: unresolved symbol bpf_lsm_key_free

nice, I was wondering about that, lgtm

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
> Fixes: 5f8d28f6d7d5 ("lsm: infrastructure management of the key security blob")
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> I don't know much about LSMs, so please disregard if this is wrong.
> ---
>  kernel/bpf/bpf_lsm.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/kernel/bpf/bpf_lsm.c b/kernel/bpf/bpf_lsm.c
> index 6292ac5f9bd139dafb39ecd8bb180be46cd7c7fd..3bc61628ab251e05d7837eb27dabc3b62bcc4783 100644
> --- a/kernel/bpf/bpf_lsm.c
> +++ b/kernel/bpf/bpf_lsm.c
> @@ -339,10 +339,6 @@ BTF_ID(func, bpf_lsm_path_chmod)
>  BTF_ID(func, bpf_lsm_path_chown)
>  #endif /* CONFIG_SECURITY_PATH */
>  
> -#ifdef CONFIG_KEYS
> -BTF_ID(func, bpf_lsm_key_free)
> -#endif /* CONFIG_KEYS */
> -
>  BTF_ID(func, bpf_lsm_mmap_file)
>  BTF_ID(func, bpf_lsm_netlink_send)
>  BTF_ID(func, bpf_lsm_path_notify)
> 
> ---
> base-commit: 0c559323bbaabee7346c12e74b497e283aaafef5
> change-id: 20241005-lsm-key_free-b47445ee523d
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@weissschuh.net>
>

Re: [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook

Posted by Song Liu 1 month, 3 weeks ago

On Fri, Oct 4, 2024 at 5:07 PM Thomas Weißschuh <linux@weissschuh.net> wrote:
>
> The key_free LSM hook has been removed.
> Remove the corresponding BPF hook.
>
> Avoid warnings during the build:
>   BTFIDS  vmlinux
> WARN: resolve_btfids: unresolved symbol bpf_lsm_key_free
>
> Fixes: 5f8d28f6d7d5 ("lsm: infrastructure management of the key security blob")
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

LGTM.

Acked-by: Song Liu <song@kernel.org>