Changes since v4?:
 * Dropped the percentage/mbps distinction, this can be future cleanup as I
   think the difference matters to user-space. These are both treated as a
   'range'.
 * Picked a pre-requisite cleanup patch from Christophe to make merging
   easier.
 * More of the __init/__exit stuff has consolodated in the patch that removes
   them from filesystem code.
 Regardless, changes are noted on each patch.

~

This is the final series that allows other architectures to implement resctrl.
The final patch to move the code has been omited, but can be generated using
the python script at the end of the series.
The final move is a bit of a monster. I don't expect that to get merged as part
of this series - we should wait for it to make less impact on other series.

Otherwise this series renames functions and moves code around. With the
exception of invalid configurations for the configurable-events, there should
be no changes in behaviour caused by this series.

The driving pattern is to make things like struct rdtgroup private to resctrl.
Features like pseudo-lock aren't going to work on arm64, the ability to disable
it at compile time is added.

After this, I can start posting the MPAM driver to make use of resctrl on arm64.
(What's MPAM? See the cover letter of the first series. [1])

This series is based on v6.12-rc1 and can be retrieved from:
https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/move_to_fs/v5

As ever - bugs welcome,
Thanks,

James

[v4] https://lore.kernel.org/all/20240802172853.22529-1-james.morse@arm.com/
[v3] https://lore.kernel.org/r/20240614150033.10454-1-james.morse@arm.com
[v2] https://lore.kernel.org/r/20240426150537.8094-1-Dave.Martin@arm.com
[v1] https://lore.kernel.org/r/20240321165106.31602-1-james.morse@arm.com
[1] https://lore.kernel.org/lkml/20201030161120.227225-1-james.morse@arm.com/




Christophe JAILLET (1):
  x86/resctrl: Slightly clean-up mbm_config_show()

James Morse (39):
  x86/resctrl: Fix allocation of cleanest CLOSID on platforms with no
    monitors
  x86/resctrl: Add a helper to avoid reaching into the arch code
    resource list
  x86/resctrl: Remove fflags from struct rdt_resource
  x86/resctrl: Use schema type to determine how to parse schema values
  x86/resctrl: Use schema type to determine the schema format string
  x86/resctrl: Remove data_width and the tabular format
  x86/resctrl: Add max_bw to struct resctrl_membw
  x86/resctrl: Generate default_ctrl instead of sharing it
  x86/resctrl: Add helper for setting CPU default properties
  x86/resctrl: Remove rdtgroup from update_cpu_closid_rmid()
  x86/resctrl: Export resctrl fs's init function
  x86/resctrl: Wrap resctrl_arch_find_domain() around rdt_find_domain()
  x86/resctrl: Move resctrl types to a separate header
  x86/resctrl: Add a resctrl helper to reset all the resources
  x86/resctrl: Move monitor exit work to a resctrl exit call
  x86/resctrl: Move monitor init work to a resctrl init call
  x86/resctrl: Rewrite and move the for_each_*_rdt_resource() walkers
  x86/resctrl: Export the is_mbm_*_enabled() helpers to asm/resctrl.h
  x86/resctrl: Add resctrl_arch_is_evt_configurable() to abstract BMEC
  x86/resctrl: Change mon_event_config_{read,write}() to be arch helpers
  x86/resctrl: Move mbm_cfg_mask to struct rdt_resource
  x86/resctrl: Add resctrl_arch_ prefix to pseudo lock functions
  x86/resctrl: Allow an architecture to disable pseudo lock
  x86/resctrl: Make prefetch_disable_bits belong to the arch code
  x86/resctrl: Make resctrl_arch_pseudo_lock_fn() take a plr
  x86/resctrl: Move thread_throttle_mode_init() to be managed by resctrl
  x86/resctrl: Move get_config_index() to a header
  x86/resctrl: Claim get_{mon,ctrl}_domain_from_cpu() helpers for
    resctrl
  x86/resctrl: Describe resctrl's bitmap size assumptions
  x86/resctrl: Rename resctrl_sched_in() to begin with "resctrl_arch_"
  x86/resctrl: resctrl_exit() teardown resctrl but leave the mount point
  x86/resctrl: Drop __init/__exit on assorted symbols
  x86/resctrl: Move is_mba_sc() out of core.c
  x86/resctrl: Add end-marker to the resctrl_event_id enum
  x86/resctrl: Remove a newline to avoid confusing the code move script
  x86/resctrl: Split trace.h
  fs/resctrl: Add boiler plate for external resctrl code
  x86/resctrl: Move the filesystem bits to headers visible to fs/resctrl
  x86/resctrl: Add python script to move resctrl code to /fs/resctrl

 MAINTAINERS                                   |   2 +
 arch/Kconfig                                  |   8 +
 arch/x86/Kconfig                              |  12 +-
 arch/x86/include/asm/resctrl.h                |  45 +-
 arch/x86/kernel/cpu/resctrl/Makefile          |   8 +-
 arch/x86/kernel/cpu/resctrl/core.c            | 170 ++--
 arch/x86/kernel/cpu/resctrl/ctrlmondata.c     |  67 +-
 arch/x86/kernel/cpu/resctrl/internal.h        | 217 ++---
 arch/x86/kernel/cpu/resctrl/monitor.c         | 104 ++-
 arch/x86/kernel/cpu/resctrl/monitor_trace.h   |  31 +
 arch/x86/kernel/cpu/resctrl/pseudo_lock.c     |  60 +-
 .../resctrl/{trace.h => pseudo_lock_trace.h}  |  24 +-
 arch/x86/kernel/cpu/resctrl/rdtgroup.c        | 268 ++++--
 arch/x86/kernel/process_32.c                  |   2 +-
 arch/x86/kernel/process_64.c                  |   2 +-
 fs/Kconfig                                    |   1 +
 fs/Makefile                                   |   1 +
 fs/resctrl/Kconfig                            |  37 +
 fs/resctrl/Makefile                           |   6 +
 fs/resctrl/ctrlmondata.c                      |   0
 fs/resctrl/internal.h                         |   0
 fs/resctrl/monitor.c                          |   0
 fs/resctrl/monitor_trace.h                    |   0
 fs/resctrl/pseudo_lock.c                      |   0
 fs/resctrl/pseudo_lock_trace.h                |   0
 fs/resctrl/rdtgroup.c                         |   0
 include/linux/resctrl.h                       | 239 +++++-
 include/linux/resctrl_types.h                 |  59 ++
 resctrl_copy_pasta.py                         | 779 ++++++++++++++++++
 29 files changed, 1638 insertions(+), 504 deletions(-)
 create mode 100644 arch/x86/kernel/cpu/resctrl/monitor_trace.h
 rename arch/x86/kernel/cpu/resctrl/{trace.h => pseudo_lock_trace.h} (56%)
 create mode 100644 fs/resctrl/Kconfig
 create mode 100644 fs/resctrl/Makefile
 create mode 100644 fs/resctrl/ctrlmondata.c
 create mode 100644 fs/resctrl/internal.h
 create mode 100644 fs/resctrl/monitor.c
 create mode 100644 fs/resctrl/monitor_trace.h
 create mode 100644 fs/resctrl/pseudo_lock.c
 create mode 100644 fs/resctrl/pseudo_lock_trace.h
 create mode 100644 fs/resctrl/rdtgroup.c
 create mode 100644 include/linux/resctrl_types.h
 create mode 100644 resctrl_copy_pasta.py

-- 
2.39.2

Summary of my comments:

0002 - fragile, but simple fix
0004 - drop the helper function, or add NULL check?
0007 - needs rebase against tip x86/cache
0011 - fix commit comment
0020 - already in tip x86/cache, drop from series
0030 - Use new RESCTRL_MAX_CLOSID to replace hard coded constant
0038 - duplicate #include

So nothing major.

Reviewed-by: Tony Luck <tony.luck@intel.com>

-Tony

On Fri, Oct 04, 2024 at 06:03:07PM +0000, James Morse wrote:
> Changes since v4?:
>  * Dropped the percentage/mbps distinction, this can be future cleanup as I
>    think the difference matters to user-space. These are both treated as a
>    'range'.
>  * Picked a pre-requisite cleanup patch from Christophe to make merging
>    easier.
>  * More of the __init/__exit stuff has consolodated in the patch that removes
>    them from filesystem code.
>  Regardless, changes are noted on each patch.
> 
> ~
> 
> This is the final series that allows other architectures to implement resctrl.
> The final patch to move the code has been omited, but can be generated using
> the python script at the end of the series.
> The final move is a bit of a monster. I don't expect that to get merged as part
> of this series - we should wait for it to make less impact on other series.

I've been playing around with this series (after running the python
script to get the full effect of where the code is headed).

Things seem to look pretty good. I haven't noticed anything failing
(but I haven't done extensive testing).

I've skimmed over the patches and posted some nitpicks on a couple
of them. I'll try to find time to make a proper review pass.

Just to see whether I still understand the new layout I took my
patches for mba_MBps[1] and applied them on top of all of this.
The process was pretty simple, most functions that were changed
just moved to fs/resctrl. Just a few places where I needed to
tweak things to fit on top of the changes (like using the
new resctrl_arch_get_resource() to lookup rdt_resources
instead of indexing into the rdt_resources_all[] array,
of function names changed to add "_arch").

Overall it looks pretty good.

-Tony

[1] https://lore.kernel.org/all/20241003191228.67541-1-tony.luck@intel.com/

Hi James,

While you wait for folks to consider these changes, could you please take a look
at [1] from an Arm/MPAM perspective? My understanding is that Arm/MPAM also
requires assigning counters to do monitoring and [1] aims to create
a generic interface to do so. Is [1] something that Arm/MPAM can build on
or are there some changes that can be made before its inclusion to help 
with future MPAM support?

Thank you

Reinette

[1] https://lore.kernel.org/all/cover.1725488488.git.babu.moger@amd.com/

Hi Reinette,

On 04/10/2024 22:18, Reinette Chatre wrote:
> While you wait for folks to consider these changes, could you please take a look
> at [1] from an Arm/MPAM perspective? My understanding is that Arm/MPAM also
> requires assigning counters to do monitoring and [1] aims to create
> a generic interface to do so. Is [1] something that Arm/MPAM can build on
> or are there some changes that can be made before its inclusion to help 
> with future MPAM support?

Yup, this is on my list to get back into this week.

I did rebase the MPAM tree over Babu's v6, but haven't had the chance to test it [0].
This is my previous feedback on where the arch/fs split needed to be came form.


Thanks,

James

[0] https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/log/?h=mpam/abmc/v6