[PATCH v3 0/8] tracing: Allow system call tracepoints to handle page faults

Mathieu Desnoyers posted 8 patches 1 month, 3 weeks ago
There is a newer version of this series
include/linux/tracepoint.h      | 65 +++++++++++++++++++++++++--------
include/trace/bpf_probe.h       | 13 +++++++
include/trace/define_trace.h    |  5 +++
include/trace/events/syscalls.h |  4 +-
include/trace/perf.h            | 43 ++++++++++++++++++++--
include/trace/trace_events.h    | 61 +++++++++++++++++++++++++++++--
init/Kconfig                    |  1 +
kernel/trace/trace_syscalls.c   | 28 ++++++++++++++
8 files changed, 196 insertions(+), 24 deletions(-)
[PATCH v3 0/8] tracing: Allow system call tracepoints to handle page faults
Posted by Mathieu Desnoyers 1 month, 3 weeks ago
Wire up the system call tracepoints with Tasks Trace RCU to allow
the ftrace, perf, and eBPF tracers to handle page faults.

This series does the initial wire-up allowing tracers to handle page
faults, but leaves out the actual handling of said page faults as future
work.

This series was compile and runtime tested with ftrace and perf syscall
tracing and raw syscall tracing, adding a WARN_ON_ONCE() in the
generated code to validate that the intended probes are used for raw
syscall tracing. The might_fault() added within those probes validate
that they are called from a context where handling a page fault is OK.

The eBPF people have been needing this feature for quite a while:
https://lore.kernel.org/lkml/c323bce9-a04e-b1c3-580a-783fde259d60@fb.com/

This series replaces the "Faultable Tracepoints v6" series found at [1].

This has been rebased on v6.12-rc1 on top of two patches from Steven:

tracing: Remove definition of trace_*_rcuidle()
tracepoint: Remove SRCU protection

The main change since v2 is removal of remapping from
trace_sys_enter/exit to trace_syscall_sys_enter/exit (likewise for
register/unregister), which caused arch-specific code churn needlessly.

Thanks,

Mathieu

Link: https://lore.kernel.org/lkml/20240828144153.829582-1-mathieu.desnoyers@efficios.com/ # [1]
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Yonghong Song <yhs@fb.com>
Cc: Paul E. McKenney <paulmck@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf@vger.kernel.org
Cc: Joel Fernandes <joel@joelfernandes.org>
Cc: linux-trace-kernel@vger.kernel.org

Mathieu Desnoyers (8):
  tracing: Declare system call tracepoints with TRACE_EVENT_SYSCALL
  tracing/ftrace: guard syscall probe with preempt_notrace
  tracing/perf: guard syscall probe with preempt_notrace
  tracing/bpf: guard syscall probe with preempt_notrace
  tracing: Allow system call tracepoints to handle page faults
  tracing/ftrace: Add might_fault check to syscall probes
  tracing/perf: Add might_fault check to syscall probes
  tracing/bpf: Add might_fault check to syscall probes

 include/linux/tracepoint.h      | 65 +++++++++++++++++++++++++--------
 include/trace/bpf_probe.h       | 13 +++++++
 include/trace/define_trace.h    |  5 +++
 include/trace/events/syscalls.h |  4 +-
 include/trace/perf.h            | 43 ++++++++++++++++++++--
 include/trace/trace_events.h    | 61 +++++++++++++++++++++++++++++--
 init/Kconfig                    |  1 +
 kernel/trace/trace_syscalls.c   | 28 ++++++++++++++
 8 files changed, 196 insertions(+), 24 deletions(-)

-- 
2.39.2
Re: [PATCH v3 0/8] tracing: Allow system call tracepoints to handle page faults
Posted by Steven Rostedt 1 month, 2 weeks ago
On Fri,  4 Oct 2024 10:58:10 -0400
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> Wire up the system call tracepoints with Tasks Trace RCU to allow
> the ftrace, perf, and eBPF tracers to handle page faults.

Hi Mathieu,

Looks good besides the little nits I mentioned.

Could you fix them up and rebase on top of:

  git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git

  branch: trace/core

The biggest difference is that I added Josh's patch to not use the obsolete
static_key_false() anymore. I fixed up your patch before applying it by
basically just doing a:

  s/static_key_false/static_branch_unlikely/

And then removing the extra tabs at the end. That allowed it to apply
without more tweaks.

If you can send a v4 with those updates, I'll apply it and start testing it.

-- Steve