dt-bindings: power: mediatek: Refine multiple level power domain nodes

[PATCH] dt-bindings: power: mediatek: Refine multiple level power domain nodes

Posted by Macpaul Lin 1 year, 4 months ago

Extract duplicated properties and support more levels of power
domain nodes.

This change fix following error when do dtbs_check,
  mt8390-genio-700-evk.dtb:
    power-controller: power-domain@15:power-domain@16:power-domain@29:power-domain@30:
    Unevaluated properties are not allowed ('power-domain@31', 'power-domain@32'
    were unexpected)

Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
 .../devicetree/bindings/power/mediatek,power-controller.yaml  | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
index 8985e2df8a56..a7df4041b745 100644
--- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
+++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
@@ -54,6 +54,10 @@ patternProperties:
             patternProperties:
               "^power-domain@[0-9a-f]+$":
                 $ref: "#/$defs/power-domain-node"
+                patternProperties:
+                  "^power-domain@[0-9a-f]+$":
+                    $ref: "#/$defs/power-domain-node"
+                    unevaluatedProperties: false
                 unevaluatedProperties: false
             unevaluatedProperties: false
         unevaluatedProperties: false
-- 
2.45.2

Re: [PATCH] dt-bindings: power: mediatek: Refine multiple level power domain nodes

Posted by Fei Shao 1 year, 4 months ago

On Fri, Oct 4, 2024 at 3:53 PM Macpaul Lin <macpaul.lin@mediatek.com> wrote:
>
> Extract duplicated properties and support more levels of power
> domain nodes.
>
> This change fix following error when do dtbs_check,
>   mt8390-genio-700-evk.dtb:
>     power-controller: power-domain@15:power-domain@16:power-domain@29:power-domain@30:
>     Unevaluated properties are not allowed ('power-domain@31', 'power-domain@32'
>     were unexpected)
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
>  .../devicetree/bindings/power/mediatek,power-controller.yaml  | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> index 8985e2df8a56..a7df4041b745 100644
> --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> @@ -54,6 +54,10 @@ patternProperties:
>              patternProperties:
>                "^power-domain@[0-9a-f]+$":
>                  $ref: "#/$defs/power-domain-node"
> +                patternProperties:
> +                  "^power-domain@[0-9a-f]+$":
> +                    $ref: "#/$defs/power-domain-node"
> +                    unevaluatedProperties: false
>                  unevaluatedProperties: false
>              unevaluatedProperties: false
>          unevaluatedProperties: false

For reference, I sent the exact same patch and it's been acked:
https://lore.kernel.org/all/20241001113052.3124869-2-fshao@chromium.org/

Regards,
Fei

Re: [PATCH] dt-bindings: power: mediatek: Refine multiple level power domain nodes

Posted by Macpaul Lin 1 year, 4 months ago


On 10/4/24 16:24, Fei Shao wrote:
> 	
> 
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
> 
> On Fri, Oct 4, 2024 at 3:53 PM Macpaul Lin <macpaul.lin@mediatek.com> wrote:
>>
>> Extract duplicated properties and support more levels of power
>> domain nodes.
>>
>> This change fix following error when do dtbs_check,
>>   mt8390-genio-700-evk.dtb:
>>     power-controller: power-domain@15:power-domain@16:power-domain@29:power-domain@30:
>>     Unevaluated properties are not allowed ('power-domain@31', 'power-domain@32'
>>     were unexpected)
>>
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>>  .../devicetree/bindings/power/mediatek,power-controller.yaml  | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
>> index 8985e2df8a56..a7df4041b745 100644
>> --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
>> +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
>> @@ -54,6 +54,10 @@ patternProperties:
>>              patternProperties:
>>                "^power-domain@[0-9a-f]+$":
>>                  $ref: "#/$defs/power-domain-node"
>> +                patternProperties:
>> +                  "^power-domain@[0-9a-f]+$":
>> +                    $ref: "#/$defs/power-domain-node"
>> +                    unevaluatedProperties: false
>>                  unevaluatedProperties: false
>>              unevaluatedProperties: false
>>          unevaluatedProperties: false
> 
> For reference, I sent the exact same patch and it's been acked:
> https://lore.kernel.org/all/20241001113052.3124869-2-fshao@chromium.org/
> 
> Regards,
> Fei
> 

Thanks for the reminder.
This patch could be dropped by duplicate works.

Regards,
Macpaul Lin