ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY ID

[PATCH] ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY ID

Posted by Nobuhiro Iwamatsu 1 month, 3 weeks ago

From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>

On SoCFPGA/Sodia board, mdio bus cannot be probed, so the PHY cannot be
found and the network device does not work.

```
stmmaceth ff702000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19)
```

To probe the mdio bus, add "snps,dwmac-mdio" as compatible string of the
mdio bus. Also the PHY ID connected to this board is 4. Therefore, change
to 4.

Fixes: 8fbc10b995a5 ("net: stmmac: check fwnode for phy device before scanning for phy")
Cc: stable@vger.kernel.org # 6.3+
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
 arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
index ce0d6514eeb571..e4794ccb8e413f 100644
--- a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
+++ b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
@@ -66,8 +66,10 @@ &gmac1 {
 	mdio0 {
 		#address-cells = <1>;
 		#size-cells = <0>;
-		phy0: ethernet-phy@0 {
-			reg = <0>;
+		compatible = "snps,dwmac-mdio";
+
+		phy0: ethernet-phy@4 {
+			reg = <4>;
 			rxd0-skew-ps = <0>;
 			rxd1-skew-ps = <0>;
 			rxd2-skew-ps = <0>;
-- 
2.45.2

Re: [PATCH] ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY ID

Posted by Nobuhiro Iwamatsu 1 week, 3 days ago

Hi Dinh,

Please check and apply this patch?

Thanks,
  Nobuhiro

2024年10月4日(金) 15:16 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>:
>
> From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>
> On SoCFPGA/Sodia board, mdio bus cannot be probed, so the PHY cannot be
> found and the network device does not work.
>
> ```
> stmmaceth ff702000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19)
> ```
>
> To probe the mdio bus, add "snps,dwmac-mdio" as compatible string of the
> mdio bus. Also the PHY ID connected to this board is 4. Therefore, change
> to 4.
>
> Fixes: 8fbc10b995a5 ("net: stmmac: check fwnode for phy device before scanning for phy")
> Cc: stable@vger.kernel.org # 6.3+
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
>  arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
> index ce0d6514eeb571..e4794ccb8e413f 100644
> --- a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
> +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts
> @@ -66,8 +66,10 @@ &gmac1 {
>         mdio0 {
>                 #address-cells = <1>;
>                 #size-cells = <0>;
> -               phy0: ethernet-phy@0 {
> -                       reg = <0>;
> +               compatible = "snps,dwmac-mdio";
> +
> +               phy0: ethernet-phy@4 {
> +                       reg = <4>;
>                         rxd0-skew-ps = <0>;
>                         rxd1-skew-ps = <0>;
>                         rxd2-skew-ps = <0>;
> --
> 2.45.2
>


-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org / kernel.org}
   GPG ID: 32247FBB40AD1FA6

Re: [PATCH] ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY ID

Posted by Andrew Lunn 1 week, 3 days ago

On Sun, Nov 17, 2024 at 05:53:51PM +0900, Nobuhiro Iwamatsu wrote:
> Hi Dinh,
> 
> Please check and apply this patch?
> 
> Thanks,
>   Nobuhiro
> 
> 2024年10月4日(金) 15:16 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>:
> >
> > From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> >
> > On SoCFPGA/Sodia board, mdio bus cannot be probed, so the PHY cannot be
> > found and the network device does not work.
> >
> > ```
> > stmmaceth ff702000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19)
> > ```
> >
> > To probe the mdio bus, add "snps,dwmac-mdio" as compatible string of the
> > mdio bus. Also the PHY ID connected to this board is 4. Therefore, change
> > to 4.

It is the address which is 4, not the ID.

	Andrew

Re: [PATCH] ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY ID

Posted by Nobuhiro Iwamatsu 6 days, 20 hours ago

Hi Andrew,

Thanks for your review.

2024年11月18日(月) 5:06 Andrew Lunn <andrew@lunn.ch>:
>
> On Sun, Nov 17, 2024 at 05:53:51PM +0900, Nobuhiro Iwamatsu wrote:
> > Hi Dinh,
> >
> > Please check and apply this patch?
> >
> > Thanks,
> >   Nobuhiro
> >
> > 2024年10月4日(金) 15:16 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>:
> > >
> > > From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> > >
> > > On SoCFPGA/Sodia board, mdio bus cannot be probed, so the PHY cannot be
> > > found and the network device does not work.
> > >
> > > ```
> > > stmmaceth ff702000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19)
> > > ```
> > >
> > > To probe the mdio bus, add "snps,dwmac-mdio" as compatible string of the
> > > mdio bus. Also the PHY ID connected to this board is 4. Therefore, change
> > > to 4.
>
> It is the address which is 4, not the ID.

Thanks, I will fix it.

>
>         Andrew

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org / kernel.org}
   GPG ID: 32247FBB40AD1FA6