1. Patchew
  2. linux
  3. [PATCH RFC net 0/2] MAINTAINERS: Networking file coverage updates
  4. View patch

[PATCH RFC net 1/2] MAINTAINERS: consistently exclude wireless files from NETWORKING [GENERAL]

Simon Horman posted 2 patches 1 month, 3 weeks ago
There is a newer version of this series
[PATCH RFC net 1/2] MAINTAINERS: consistently exclude wireless files from NETWORKING [GENERAL]
Posted by Simon Horman 1 month, 3 weeks ago 
We already exclude wireless drivers from the netdev@ traffic, to
delegate it to linux-wireless@, and avoid overwhelming netdev@.

Many of the following wireless-related sections MAINTAINERS
are already not included in the NETWORKING [GENERAL] section.
For consistency, exclude those that are.

* 802.11 (including CFG80211/NL80211)
* MAC80211
* RFKILL

Signed-off-by: Simon Horman <horms@kernel.org>
---
 MAINTAINERS | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index c27f3190737f..ea3ea2c0d3fa 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16197,8 +16197,19 @@ F:	lib/random32.c
 F:	net/
 F:	tools/net/
 F:	tools/testing/selftests/net/
+X:	Documentation/networking/mac80211-injection.rst
+X:	Documentation/networking/mac80211_hwsim/
+X:	Documentation/networking/regulatory.rst
+X:	include/net/cfg80211.h
+X:	include/net/ieee80211_radiotap.h
+X:	include/net/iw_handler.h
+X:	include/net/mac80211.h
+X:	include/net/wext.h
 X:	net/9p/
 X:	net/bluetooth/
+X:	net/mac80211/
+X:	net/rfkill/
+X:	net/wireless/
 
 NETWORKING [IPSEC]
 M:	Steffen Klassert <steffen.klassert@secunet.com>

-- 
2.45.2
Re: [PATCH RFC net 1/2] MAINTAINERS: consistently exclude wireless files from NETWORKING [GENERAL]
Posted by Kalle Valo 1 month, 3 weeks ago 
Simon Horman <horms@kernel.org> writes:

> We already exclude wireless drivers from the netdev@ traffic, to
> delegate it to linux-wireless@, and avoid overwhelming netdev@.
>
> Many of the following wireless-related sections MAINTAINERS
> are already not included in the NETWORKING [GENERAL] section.
> For consistency, exclude those that are.
>
> * 802.11 (including CFG80211/NL80211)
> * MAC80211
> * RFKILL
>
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---
>  MAINTAINERS | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c27f3190737f..ea3ea2c0d3fa 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16197,8 +16197,19 @@ F:	lib/random32.c
>  F:	net/
>  F:	tools/net/
>  F:	tools/testing/selftests/net/
> +X:	Documentation/networking/mac80211-injection.rst
> +X:	Documentation/networking/mac80211_hwsim/
> +X:	Documentation/networking/regulatory.rst
> +X:	include/net/cfg80211.h
> +X:	include/net/ieee80211_radiotap.h
> +X:	include/net/iw_handler.h
> +X:	include/net/mac80211.h
> +X:	include/net/wext.h

Should we add also lib80211.h?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH RFC net 1/2] MAINTAINERS: consistently exclude wireless files from NETWORKING [GENERAL]
Posted by Simon Horman 1 month, 3 weeks ago 
On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote:
> Simon Horman <horms@kernel.org> writes:
> 
> > We already exclude wireless drivers from the netdev@ traffic, to
> > delegate it to linux-wireless@, and avoid overwhelming netdev@.
> >
> > Many of the following wireless-related sections MAINTAINERS
> > are already not included in the NETWORKING [GENERAL] section.
> > For consistency, exclude those that are.
> >
> > * 802.11 (including CFG80211/NL80211)
> > * MAC80211
> > * RFKILL
> >
> > Signed-off-by: Simon Horman <horms@kernel.org>
> > ---
> >  MAINTAINERS | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index c27f3190737f..ea3ea2c0d3fa 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16197,8 +16197,19 @@ F:	lib/random32.c
> >  F:	net/
> >  F:	tools/net/
> >  F:	tools/testing/selftests/net/
> > +X:	Documentation/networking/mac80211-injection.rst
> > +X:	Documentation/networking/mac80211_hwsim/
> > +X:	Documentation/networking/regulatory.rst
> > +X:	include/net/cfg80211.h
> > +X:	include/net/ieee80211_radiotap.h
> > +X:	include/net/iw_handler.h
> > +X:	include/net/mac80211.h
> > +X:	include/net/wext.h
> 
> Should we add also lib80211.h?

Thanks, I missed that one. Perhaps it should have:

* An F: entry in the MAC80211
* An X: entry in the NETWORKING [GENERAL]

If so, perhaps I can just add that to a v2 of this patch.
Let me know what you think.
Re: [PATCH RFC net 1/2] MAINTAINERS: consistently exclude wireless files from NETWORKING [GENERAL]
Posted by Kalle Valo 1 month, 3 weeks ago 
Simon Horman <horms@kernel.org> writes:

> On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote:
>
>> Simon Horman <horms@kernel.org> writes:
>> 
>> > We already exclude wireless drivers from the netdev@ traffic, to
>> > delegate it to linux-wireless@, and avoid overwhelming netdev@.
>> >
>> > Many of the following wireless-related sections MAINTAINERS
>> > are already not included in the NETWORKING [GENERAL] section.
>> > For consistency, exclude those that are.
>> >
>> > * 802.11 (including CFG80211/NL80211)
>> > * MAC80211
>> > * RFKILL
>> >
>> > Signed-off-by: Simon Horman <horms@kernel.org>
>> > ---
>> >  MAINTAINERS | 11 +++++++++++
>> >  1 file changed, 11 insertions(+)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index c27f3190737f..ea3ea2c0d3fa 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -16197,8 +16197,19 @@ F:	lib/random32.c
>> >  F:	net/
>> >  F:	tools/net/
>> >  F:	tools/testing/selftests/net/
>> > +X:	Documentation/networking/mac80211-injection.rst
>> > +X:	Documentation/networking/mac80211_hwsim/
>> > +X:	Documentation/networking/regulatory.rst
>> > +X:	include/net/cfg80211.h
>> > +X:	include/net/ieee80211_radiotap.h
>> > +X:	include/net/iw_handler.h
>> > +X:	include/net/mac80211.h
>> > +X:	include/net/wext.h
>> 
>> Should we add also lib80211.h?
>
> Thanks, I missed that one. Perhaps it should have:
>
> * An F: entry in the MAC80211
> * An X: entry in the NETWORKING [GENERAL]
>
> If so, perhaps I can just add that to a v2 of this patch.
> Let me know what you think.

Like Johannes said, the cfg80211 entry is more approriate but otherwise
sounds like a good plan, thanks!

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH RFC net 1/2] MAINTAINERS: consistently exclude wireless files from NETWORKING [GENERAL]
Posted by Johannes Berg 1 month, 3 weeks ago 
On Mon, 2024-10-07 at 20:41 +0300, Kalle Valo wrote:
> Simon Horman <horms@kernel.org> writes:
> 
> > On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote:
> > 
> > > Simon Horman <horms@kernel.org> writes:
> > > 
> > > > We already exclude wireless drivers from the netdev@ traffic, to
> > > > delegate it to linux-wireless@, and avoid overwhelming netdev@.
> > > > 
> > > > Many of the following wireless-related sections MAINTAINERS
> > > > are already not included in the NETWORKING [GENERAL] section.
> > > > For consistency, exclude those that are.
> > > > 
> > > > * 802.11 (including CFG80211/NL80211)
> > > > * MAC80211
> > > > * RFKILL
> > > > 
> > > > Signed-off-by: Simon Horman <horms@kernel.org>
> > > > ---
> > > >  MAINTAINERS | 11 +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > > 
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index c27f3190737f..ea3ea2c0d3fa 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -16197,8 +16197,19 @@ F:	lib/random32.c
> > > >  F:	net/
> > > >  F:	tools/net/
> > > >  F:	tools/testing/selftests/net/
> > > > +X:	Documentation/networking/mac80211-injection.rst
> > > > +X:	Documentation/networking/mac80211_hwsim/
> > > > +X:	Documentation/networking/regulatory.rst
> > > > +X:	include/net/cfg80211.h
> > > > +X:	include/net/ieee80211_radiotap.h
> > > > +X:	include/net/iw_handler.h
> > > > +X:	include/net/mac80211.h
> > > > +X:	include/net/wext.h
> > > 
> > > Should we add also lib80211.h?
> > 
> > Thanks, I missed that one. Perhaps it should have:
> > 
> > * An F: entry in the MAC80211
> > * An X: entry in the NETWORKING [GENERAL]
> > 
> > If so, perhaps I can just add that to a v2 of this patch.
> > Let me know what you think.
> 
> Like Johannes said, the cfg80211 entry is more approriate but otherwise
> sounds like a good plan, thanks!

Actually scratch that, please just ignore it. I'm going to remove that
header file entirely and move the functionality into libipw in the
ipw2x00 drivers.

johannes
Re: [PATCH RFC net 1/2] MAINTAINERS: consistently exclude wireless files from NETWORKING [GENERAL]
Posted by Simon Horman 1 month, 2 weeks ago 
On Mon, Oct 07, 2024 at 08:03:22PM +0200, Johannes Berg wrote:
> On Mon, 2024-10-07 at 20:41 +0300, Kalle Valo wrote:
> > Simon Horman <horms@kernel.org> writes:
> > 
> > > On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote:
> > > 
> > > > Simon Horman <horms@kernel.org> writes:
> > > > 
> > > > > We already exclude wireless drivers from the netdev@ traffic, to
> > > > > delegate it to linux-wireless@, and avoid overwhelming netdev@.
> > > > > 
> > > > > Many of the following wireless-related sections MAINTAINERS
> > > > > are already not included in the NETWORKING [GENERAL] section.
> > > > > For consistency, exclude those that are.
> > > > > 
> > > > > * 802.11 (including CFG80211/NL80211)
> > > > > * MAC80211
> > > > > * RFKILL
> > > > > 
> > > > > Signed-off-by: Simon Horman <horms@kernel.org>
> > > > > ---
> > > > >  MAINTAINERS | 11 +++++++++++
> > > > >  1 file changed, 11 insertions(+)
> > > > > 
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index c27f3190737f..ea3ea2c0d3fa 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -16197,8 +16197,19 @@ F:	lib/random32.c
> > > > >  F:	net/
> > > > >  F:	tools/net/
> > > > >  F:	tools/testing/selftests/net/
> > > > > +X:	Documentation/networking/mac80211-injection.rst
> > > > > +X:	Documentation/networking/mac80211_hwsim/
> > > > > +X:	Documentation/networking/regulatory.rst
> > > > > +X:	include/net/cfg80211.h
> > > > > +X:	include/net/ieee80211_radiotap.h
> > > > > +X:	include/net/iw_handler.h
> > > > > +X:	include/net/mac80211.h
> > > > > +X:	include/net/wext.h
> > > > 
> > > > Should we add also lib80211.h?
> > > 
> > > Thanks, I missed that one. Perhaps it should have:
> > > 
> > > * An F: entry in the MAC80211
> > > * An X: entry in the NETWORKING [GENERAL]
> > > 
> > > If so, perhaps I can just add that to a v2 of this patch.
> > > Let me know what you think.
> > 
> > Like Johannes said, the cfg80211 entry is more approriate but otherwise
> > sounds like a good plan, thanks!
> 
> Actually scratch that, please just ignore it. I'm going to remove that
> header file entirely and move the functionality into libipw in the
> ipw2x00 drivers.

Thanks,

In that case I'll post a v2 without any code changes.
Rather, bumping it to non-RFC and accumulating tags.
Re: [PATCH RFC net 1/2] MAINTAINERS: consistently exclude wireless files from NETWORKING [GENERAL]
Posted by Johannes Berg 1 month, 3 weeks ago 
On Mon, 2024-10-07 at 15:13 +0100, Simon Horman wrote:
> On Fri, Oct 04, 2024 at 06:27:38PM +0300, Kalle Valo wrote:
> > Simon Horman <horms@kernel.org> writes:
> > 
> > > We already exclude wireless drivers from the netdev@ traffic, to
> > > delegate it to linux-wireless@, and avoid overwhelming netdev@.
> > > 
> > > Many of the following wireless-related sections MAINTAINERS
> > > are already not included in the NETWORKING [GENERAL] section.
> > > For consistency, exclude those that are.
> > > 
> > > * 802.11 (including CFG80211/NL80211)
> > > * MAC80211
> > > * RFKILL
> > > 
> > > Signed-off-by: Simon Horman <horms@kernel.org>
> > > ---
> > >  MAINTAINERS | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index c27f3190737f..ea3ea2c0d3fa 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -16197,8 +16197,19 @@ F:	lib/random32.c
> > >  F:	net/
> > >  F:	tools/net/
> > >  F:	tools/testing/selftests/net/
> > > +X:	Documentation/networking/mac80211-injection.rst
> > > +X:	Documentation/networking/mac80211_hwsim/
> > > +X:	Documentation/networking/regulatory.rst
> > > +X:	include/net/cfg80211.h
> > > +X:	include/net/ieee80211_radiotap.h
> > > +X:	include/net/iw_handler.h
> > > +X:	include/net/mac80211.h
> > > +X:	include/net/wext.h
> > 
> > Should we add also lib80211.h?
> 
> Thanks, I missed that one. Perhaps it should have:
> 
> * An F: entry in the MAC80211

I suppose it should rather be in the 802.11 entry rather than the
MAC80211 one. I don't like the code anyway, but it's there for now :)

johannes
Re: [PATCH RFC net 1/2] MAINTAINERS: consistently exclude wireless files from NETWORKING [GENERAL]
Posted by Johannes Berg 1 month, 3 weeks ago 
On Fri, 2024-10-04 at 11:03 +0100, Simon Horman wrote:
> We already exclude wireless drivers from the netdev@ traffic, to
> delegate it to linux-wireless@, and avoid overwhelming netdev@.
> 
> Many of the following wireless-related sections MAINTAINERS
> are already not included in the NETWORKING [GENERAL] section.
> For consistency, exclude those that are.
> 
> * 802.11 (including CFG80211/NL80211)
> * MAC80211
> * RFKILL
> 
> Signed-off-by: Simon Horman <horms@kernel.org>

Makes sense to me!

Acked-by: Johannes Berg <johannes@sipsolutions.net>

johannes

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.