[PATCH 4/5] net: dsa: b53: allow lower MTUs on BCM5325/5365

Jonas Gorski posted 5 patches 1 month, 3 weeks ago
[PATCH 4/5] net: dsa: b53: allow lower MTUs on BCM5325/5365
Posted by Jonas Gorski 1 month, 3 weeks ago
While BCM5325/5365 do not support jumbo frames, they do support slightly
oversized frames, so do not error out if requesting a supported MTU for
them.

Fixes: 6ae5834b983a ("net: dsa: b53: add MTU configuration support")
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---
 drivers/net/dsa/b53/b53_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
index e8b20bfa8b83ea7ac643bd5d005e2983747bd478..5b83f9b6cdac3de6c5e6e2164c78146d694674cd 100644
--- a/drivers/net/dsa/b53/b53_common.c
+++ b/drivers/net/dsa/b53/b53_common.c
@@ -2258,7 +2258,7 @@ static int b53_change_mtu(struct dsa_switch *ds, int port, int mtu)
 	bool allow_10_100;
 
 	if (is5325(dev) || is5365(dev))
-		return -EOPNOTSUPP;
+		return 0;
 
 	if (!dsa_is_cpu_port(ds, port))
 		return 0;

-- 
2.43.0
Re: [PATCH 4/5] net: dsa: b53: allow lower MTUs on BCM5325/5365
Posted by Florian Fainelli 1 month, 3 weeks ago

On 10/4/2024 1:47 AM, Jonas Gorski wrote:
> While BCM5325/5365 do not support jumbo frames, they do support slightly
> oversized frames, so do not error out if requesting a supported MTU for
> them.
> 
> Fixes: 6ae5834b983a ("net: dsa: b53: add MTU configuration support")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>

Could be squashed with the previous commit, though no strong opinion 
either way.
-- 
Florian