1. Patchew
  2. linux
  3. [PATCH v4 0/3] X1E Dell XPS 9345 support
  4. View patch

[PATCH v4 1/3] dt-bindings: arm: qcom: Add Dell XPS 13 9345

Aleksandrs Vinarskis posted 3 patches 1 month, 3 weeks ago
[PATCH v4 1/3] dt-bindings: arm: qcom: Add Dell XPS 13 9345
Posted by Aleksandrs Vinarskis 1 month, 3 weeks ago 
Document the X1E80100-based Dell XPS 13 9345 laptop, platform
codenamed 'Tributo'/'Tributo R'.

Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 5cb54d69af0b..7c01fe30dabc 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1058,6 +1058,7 @@ properties:
       - items:
           - enum:
               - asus,vivobook-s15
+              - dell,xps13-9345
               - lenovo,yoga-slim7x
               - microsoft,romulus13
               - microsoft,romulus15
-- 
2.43.0
Re: [PATCH v4 1/3] dt-bindings: arm: qcom: Add Dell XPS 13 9345
Posted by Stefan Schmidt 1 month, 2 weeks ago 
Hello Aleksandrs,

[Again in plain text]

On Thu, 3 Oct 2024 at 23:12, Aleksandrs Vinarskis
<alex.vinarskis@gmail.com> wrote:
>
> Document the X1E80100-based Dell XPS 13 9345 laptop, platform
> codenamed 'Tributo'/'Tributo R'.
>
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 5cb54d69af0b..7c01fe30dabc 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1058,6 +1058,7 @@ properties:
>        - items:
>            - enum:
>                - asus,vivobook-s15
> +              - dell,xps13-9345
>                - lenovo,yoga-slim7x
>                - microsoft,romulus13
>                - microsoft,romulus15
> --
> 2.43.0

Tested-by: Stefan Schmidt <stefan.schmidt@linaro.org>

regards
Stefan Schmidt
Re: [PATCH v4 1/3] dt-bindings: arm: qcom: Add Dell XPS 13 9345
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago 
On 08/10/2024 23:07, Stefan Schmidt wrote:
> Hello Aleksandrs,
> 
> [Again in plain text]
> 
> On Thu, 3 Oct 2024 at 23:12, Aleksandrs Vinarskis
> <alex.vinarskis@gmail.com> wrote:
>>
>> Document the X1E80100-based Dell XPS 13 9345 laptop, platform
>> codenamed 'Tributo'/'Tributo R'.
>>
>> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 5cb54d69af0b..7c01fe30dabc 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -1058,6 +1058,7 @@ properties:
>>        - items:
>>            - enum:
>>                - asus,vivobook-s15
>> +              - dell,xps13-9345
>>                - lenovo,yoga-slim7x
>>                - microsoft,romulus13
>>                - microsoft,romulus15
>> --
>> 2.43.0
> 
> Tested-by: Stefan Schmidt <stefan.schmidt@linaro.org>

How do you test bindings? Running static checks in kernel tree is the
same as compiling software and adding tested-by.

Best regards,
Krzysztof
Re: [PATCH v4 1/3] dt-bindings: arm: qcom: Add Dell XPS 13 9345
Posted by Stefan Schmidt 1 month, 2 weeks ago 
Hello,

On Wed, 9 Oct 2024 at 08:55, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 08/10/2024 23:07, Stefan Schmidt wrote:
> > Hello Aleksandrs,
> >
> > [Again in plain text]
> >
> > On Thu, 3 Oct 2024 at 23:12, Aleksandrs Vinarskis
> > <alex.vinarskis@gmail.com> wrote:
> >>
> >> Document the X1E80100-based Dell XPS 13 9345 laptop, platform
> >> codenamed 'Tributo'/'Tributo R'.
> >>
> >> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> >> index 5cb54d69af0b..7c01fe30dabc 100644
> >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> >> @@ -1058,6 +1058,7 @@ properties:
> >>        - items:
> >>            - enum:
> >>                - asus,vivobook-s15
> >> +              - dell,xps13-9345
> >>                - lenovo,yoga-slim7x
> >>                - microsoft,romulus13
> >>                - microsoft,romulus15
> >> --
> >> 2.43.0
> >
> > Tested-by: Stefan Schmidt <stefan.schmidt@linaro.org>
>
> How do you test bindings? Running static checks in kernel tree is the
> same as compiling software and adding tested-by.

I took the whole patchset in when testing it on the actual hardware,
so I gave the tested-by for the whole series as well.
That being said, the binding patch here does indeed not benefit from
any on device testing. Feel free to drop it.

regards
Stefan Schmidt

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.