[PATCH 0/4] nfs: kobject: use generic helpers and ownership

Alexander Aring posted 4 patches 1 month, 3 weeks ago
fs/nfs/sysfs.c          | 30 +++----------------
include/linux/kobject.h | 10 +++++--
lib/kobject.c           | 65 ++++++++++++++++++++++++++++++-----------
3 files changed, 60 insertions(+), 45 deletions(-)
[PATCH 0/4] nfs: kobject: use generic helpers and ownership
Posted by Alexander Aring 1 month, 3 weeks ago
Hi,

I currently have pending patches for fs/dlm (Distributed Lock Manager)
subsystem to introduce some helpers to udev. However, it seems it takes
more time that I can bring those changes upstream. I put those out now
and already figured out that nfs can also take advantage of those changes.

With this patch-series I try to try to reduce my patch-series for DLM
and already bring part of it upstream and nfs will be a user of it.

The ownership callback, I think it should be set as the
kset_create_and_add() sets this callback as default. I never had any
issues with it, but there might be container corner cases that requires
those changes?

- Alex

Alexander Aring (4):
  kobject: add kset_type_create_and_add() helper
  kobject: export generic helper ops
  nfs: sysfs: use kset_type_create_and_add()
  nfs: sysfs: use default get_ownership() callback

 fs/nfs/sysfs.c          | 30 +++----------------
 include/linux/kobject.h | 10 +++++--
 lib/kobject.c           | 65 ++++++++++++++++++++++++++++++-----------
 3 files changed, 60 insertions(+), 45 deletions(-)

-- 
2.43.0
Re: [PATCH 0/4] nfs: kobject: use generic helpers and ownership
Posted by Benjamin Coddington 1 month, 2 weeks ago
On 3 Oct 2024, at 11:14, Alexander Aring wrote:

> Hi,
>
> I currently have pending patches for fs/dlm (Distributed Lock Manager)
> subsystem to introduce some helpers to udev. However, it seems it takes
> more time that I can bring those changes upstream. I put those out now
> and already figured out that nfs can also take advantage of those changes.
>
> With this patch-series I try to try to reduce my patch-series for DLM
> and already bring part of it upstream and nfs will be a user of it.
>
> The ownership callback, I think it should be set as the
> kset_create_and_add() sets this callback as default. I never had any
> issues with it, but there might be container corner cases that requires
> those changes?
>
> - Alex
>
> Alexander Aring (4):
>   kobject: add kset_type_create_and_add() helper
>   kobject: export generic helper ops
>   nfs: sysfs: use kset_type_create_and_add()
>   nfs: sysfs: use default get_ownership() callback
>
>  fs/nfs/sysfs.c          | 30 +++----------------
>  include/linux/kobject.h | 10 +++++--
>  lib/kobject.c           | 65 ++++++++++++++++++++++++++++++-----------
>  3 files changed, 60 insertions(+), 45 deletions(-)
>
> -- 
> 2.43.0

These look good to me, though patch 4/4 seems superfluous, I responded there.

For the series:
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>

Ben
Re: [PATCH 0/4] nfs: kobject: use generic helpers and ownership
Posted by Anna Schumaker 1 month, 2 weeks ago

On 10/8/24 4:12 PM, Benjamin Coddington wrote:
> On 3 Oct 2024, at 11:14, Alexander Aring wrote:
> 
>> Hi,
>>
>> I currently have pending patches for fs/dlm (Distributed Lock Manager)
>> subsystem to introduce some helpers to udev. However, it seems it takes
>> more time that I can bring those changes upstream. I put those out now
>> and already figured out that nfs can also take advantage of those changes.
>>
>> With this patch-series I try to try to reduce my patch-series for DLM
>> and already bring part of it upstream and nfs will be a user of it.
>>
>> The ownership callback, I think it should be set as the
>> kset_create_and_add() sets this callback as default. I never had any
>> issues with it, but there might be container corner cases that requires
>> those changes?
>>
>> - Alex
>>
>> Alexander Aring (4):
>>   kobject: add kset_type_create_and_add() helper
>>   kobject: export generic helper ops
>>   nfs: sysfs: use kset_type_create_and_add()
>>   nfs: sysfs: use default get_ownership() callback
>>
>>  fs/nfs/sysfs.c          | 30 +++----------------
>>  include/linux/kobject.h | 10 +++++--
>>  lib/kobject.c           | 65 ++++++++++++++++++++++++++++++-----------
>>  3 files changed, 60 insertions(+), 45 deletions(-)
>>
>> -- 
>> 2.43.0
> 
> These look good to me, though patch 4/4 seems superfluous, I responded there.

They look good to me, too. They're not really a bugfix, so they'll probably go in through v6.13 (assuming Trond has no objections, it's his turn to do the merge) and not v6.12-rc.

Anna

> 
> For the series:
> Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
> 
> Ben
>
Re: [PATCH 0/4] nfs: kobject: use generic helpers and ownership
Posted by Alexander Aring 1 month, 2 weeks ago
Dear nfs tree maintainers,

On Thu, Oct 3, 2024 at 11:15 AM Alexander Aring <aahringo@redhat.com> wrote:
>
> Hi,
>
> I currently have pending patches for fs/dlm (Distributed Lock Manager)
> subsystem to introduce some helpers to udev. However, it seems it takes
> more time that I can bring those changes upstream. I put those out now
> and already figured out that nfs can also take advantage of those changes.
>
> With this patch-series I try to try to reduce my patch-series for DLM
> and already bring part of it upstream and nfs will be a user of it.
>
> The ownership callback, I think it should be set as the
> kset_create_and_add() sets this callback as default. I never had any
> issues with it, but there might be container corner cases that requires
> those changes?
>
> - Alex
>

Can we have those patches applied to the nfs tree? According to the
udev/kobject maintainer it is fine to take this in any tree that it
needs to go through. [0]
I made nfs as a first user of these new udev helpers functionality, so
it should go through the nfs tree if there are no other issues with
this series?

Thanks.

- Alex

[0] https://lore.kernel.org/gfs2/2024081519-caddy-monstrous-b37d@gregkh/