iio: add missing select REMAP_SPI, IIO_BUFFER, and IIO_TRIGGERED_BUFFER

[PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig

Posted by Javier Carrasco 1 month, 3 weeks ago

This driver makes use of triggered buffers, but does not select the
required modules.

Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.

Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/iio/pressure/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
index df65438c771e..d2cb8c871f6a 100644
--- a/drivers/iio/pressure/Kconfig
+++ b/drivers/iio/pressure/Kconfig
@@ -19,6 +19,9 @@ config ABP060MG
 config ROHM_BM1390
 	tristate "ROHM BM1390GLV-Z pressure sensor driver"
 	depends on I2C
+	select REGMAP_I2C
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Support for the ROHM BM1390 pressure sensor. The BM1390GLV-Z
 	  can measure pressures ranging from 300 hPa to 1300 hPa with

-- 
2.43.0

Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig

Posted by Jonathan Cameron 1 month, 3 weeks ago

On Thu, 03 Oct 2024 23:04:58 +0200
Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:

> This driver makes use of triggered buffers, but does not select the
> required modules.
> 
> Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
> 
> Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the
patch description to refer to the bm1390 which seems to be the right
name and add a note on this as it looks suspect otherwise.

> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
>  drivers/iio/pressure/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
> index df65438c771e..d2cb8c871f6a 100644
> --- a/drivers/iio/pressure/Kconfig
> +++ b/drivers/iio/pressure/Kconfig
> @@ -19,6 +19,9 @@ config ABP060MG
>  config ROHM_BM1390
>  	tristate "ROHM BM1390GLV-Z pressure sensor driver"
>  	depends on I2C
> +	select REGMAP_I2C
> +	select IIO_BUFFER
> +	select IIO_TRIGGERED_BUFFER
>  	help
>  	  Support for the ROHM BM1390 pressure sensor. The BM1390GLV-Z
>  	  can measure pressures ranging from 300 hPa to 1300 hPa with
>

Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig

Posted by Andy Shevchenko 1 month, 2 weeks ago

On Sat, Oct 05, 2024 at 07:01:47PM +0100, Jonathan Cameron wrote:
> On Thu, 03 Oct 2024 23:04:58 +0200
> Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:

...

> > Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
> Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the
> patch description to refer to the bm1390 which seems to be the right
> name and add a note on this as it looks suspect otherwise.

Fixes tag shouldn't be mangled, even if it has a typo.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig

Posted by Jonathan Cameron 1 month, 2 weeks ago

On Thu, 10 Oct 2024 16:46:19 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Sat, Oct 05, 2024 at 07:01:47PM +0100, Jonathan Cameron wrote:
> > On Thu, 03 Oct 2024 23:04:58 +0200
> > Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:  
> 
> ...
> 
> > > Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")  
> > Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the
> > patch description to refer to the bm1390 which seems to be the right
> > name and add a note on this as it looks suspect otherwise.  
> 
> Fixes tag shouldn't be mangled, even if it has a typo.
> 
Agreed. I added a note above it and modified name of this patch
to reflect the correct driver.

Jonathan

Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig

Posted by Javier Carrasco 1 month, 3 weeks ago

On 05/10/2024 20:01, Jonathan Cameron wrote:
> On Thu, 03 Oct 2024 23:04:58 +0200
> Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:
> 
>> This driver makes use of triggered buffers, but does not select the
>> required modules.
>>
>> Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
>>
>> Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
> Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the
> patch description to refer to the bm1390 which seems to be the right
> name and add a note on this as it looks suspect otherwise.
> 

Yes, it seems that there was a typo in the title of the patch that added
the driver (The "Fixes:" is therefore right as it is), and I propagated
it in the title of this patch as well. But you are right, the driver's
name is indeed bm1390.

>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
>> ---
>>  drivers/iio/pressure/Kconfig | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
>> index df65438c771e..d2cb8c871f6a 100644
>> --- a/drivers/iio/pressure/Kconfig
>> +++ b/drivers/iio/pressure/Kconfig
>> @@ -19,6 +19,9 @@ config ABP060MG
>>  config ROHM_BM1390
>>  	tristate "ROHM BM1390GLV-Z pressure sensor driver"
>>  	depends on I2C
>> +	select REGMAP_I2C
>> +	select IIO_BUFFER
>> +	select IIO_TRIGGERED_BUFFER
>>  	help
>>  	  Support for the ROHM BM1390 pressure sensor. The BM1390GLV-Z
>>  	  can measure pressures ranging from 300 hPa to 1300 hPa with
>>
>

Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig

Posted by Matti Vaittinen 1 month, 3 weeks ago

On 05/10/2024 21:12, Javier Carrasco wrote:
> On 05/10/2024 20:01, Jonathan Cameron wrote:
>> On Thu, 03 Oct 2024 23:04:58 +0200
>> Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:
>>
>>> This driver makes use of triggered buffers, but does not select the
>>> required modules.
>>>
>>> Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
>>>
>>> Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
>> Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the
>> patch description to refer to the bm1390 which seems to be the right
>> name and add a note on this as it looks suspect otherwise.
>>
> Yes, it seems that there was a typo in the title of the patch that added
> the driver (The "Fixes:" is therefore right as it is), and I propagated
> it in the title of this patch as well. But you are right, the driver's
> name is indeed bm1390.

Yep. I typoed the original patch. The correct sensor model is 
BM1390GLV-Z. I got things mixed up in my head as I was simultaneously 
writing drivers the BU270xx light sensors, a BD71851 power management IC 
and BU18xxxx video serializer and deserializer. All the B?<bunch of 
numbers> part IDs got better of me :)

Yours,
	-- Matti

Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig

Posted by Matti Vaittinen 1 month, 3 weeks ago

On 04/10/2024 00:04, Javier Carrasco wrote:
> This driver makes use of triggered buffers, but does not select the
> required modules.
> 
> Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
> 
> Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>