[PATCH] xfs: fix a typo

Andrew Kreimer posted 1 patch 1 month, 3 weeks ago
fs/xfs/xfs_log_recover.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] xfs: fix a typo
Posted by Andrew Kreimer 1 month, 3 weeks ago
Fix a typo in comments.

Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
 fs/xfs/xfs_log_recover.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index ec766b4bc853..a13bf53fea49 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -1849,7 +1849,7 @@ xlog_find_item_ops(
  *	   from the transaction. However, we can't do that until after we've
  *	   replayed all the other items because they may be dependent on the
  *	   cancelled buffer and replaying the cancelled buffer can remove it
- *	   form the cancelled buffer table. Hence they have tobe done last.
+ *	   form the cancelled buffer table. Hence they have to be done last.
  *
  *	3. Inode allocation buffers must be replayed before inode items that
  *	   read the buffer and replay changes into it. For filesystems using the
-- 
2.39.5
Re: [PATCH] xfs: fix a typo
Posted by Dan Carpenter 1 month, 3 weeks ago
On Thu, Oct 03, 2024 at 12:19:48AM +0300, Andrew Kreimer wrote:
> Fix a typo in comments.
> 

Could you explain what the typos are in the commit message so that we can spot
it more easily?  It saves a little review time.

regards,
dan carpenter
Re: [PATCH] xfs: fix a typo
Posted by Andrew Kreimer 1 month, 3 weeks ago
On Thu, Oct 03, 2024 at 08:59:42AM +0300, Dan Carpenter wrote:
> On Thu, Oct 03, 2024 at 12:19:48AM +0300, Andrew Kreimer wrote:
> > Fix a typo in comments.
> > 
> 
> Could you explain what the typos are in the commit message so that we can spot
> it more easily?  It saves a little review time.

Noted, thank you.
Re: [PATCH] xfs: fix a typo
Posted by Darrick J. Wong 1 month, 3 weeks ago
On Thu, Oct 03, 2024 at 12:19:48AM +0300, Andrew Kreimer wrote:
> Fix a typo in comments.
> 
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>

Looks good,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_log_recover.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> index ec766b4bc853..a13bf53fea49 100644
> --- a/fs/xfs/xfs_log_recover.c
> +++ b/fs/xfs/xfs_log_recover.c
> @@ -1849,7 +1849,7 @@ xlog_find_item_ops(
>   *	   from the transaction. However, we can't do that until after we've
>   *	   replayed all the other items because they may be dependent on the
>   *	   cancelled buffer and replaying the cancelled buffer can remove it
> - *	   form the cancelled buffer table. Hence they have tobe done last.
> + *	   form the cancelled buffer table. Hence they have to be done last.
>   *
>   *	3. Inode allocation buffers must be replayed before inode items that
>   *	   read the buffer and replay changes into it. For filesystems using the
> -- 
> 2.39.5
> 
>