1. Patchew
  2. linux
  3. View series

[PATCH v2] PM: QoS: Export dev_pm_qos_read_value

Markus Schneider-Pargmann posted 1 patch 1 month, 3 weeks ago 
drivers/base/power/qos.c | 1 +
1 file changed, 1 insertion(+)
[PATCH v2] PM: QoS: Export dev_pm_qos_read_value
Posted by Markus Schneider-Pargmann 1 month, 3 weeks ago 
Export the function dev_pm_qos_read_value(). Most other functions
mentioned in Documentation/power/pm_qos_interface.rst are already
exported, so export this one as well.

This function will be used to read the resume latency in a driver that
can also be compiled as a module.

Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
---

Notes:
    Changes in v2:
     - Rephrase the commit message
     - Move the patch out of the series
       'firmware: ti_sci: Introduce system suspend support'
    
    Previous versions:
     ti_sci v12 https://lore.kernel.org/lkml/20240904194229.109886-1-msp@baylibre.com/

 drivers/base/power/qos.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/base/power/qos.c b/drivers/base/power/qos.c
index bd77f6734f14..ff393cba7649 100644
--- a/drivers/base/power/qos.c
+++ b/drivers/base/power/qos.c
@@ -137,6 +137,7 @@ s32 dev_pm_qos_read_value(struct device *dev, enum dev_pm_qos_req_type type)
 
 	return ret;
 }
+EXPORT_SYMBOL_GPL(dev_pm_qos_read_value);
 
 /**
  * apply_constraint - Add/modify/remove device PM QoS request.
-- 
2.45.2
Re: [PATCH v2] PM: QoS: Export dev_pm_qos_read_value
Posted by Greg Kroah-Hartman 1 month, 3 weeks ago 
On Wed, Oct 02, 2024 at 09:44:46PM +0200, Markus Schneider-Pargmann wrote:
> Export the function dev_pm_qos_read_value(). Most other functions
> mentioned in Documentation/power/pm_qos_interface.rst are already
> exported, so export this one as well.
> 
> This function will be used to read the resume latency in a driver that
> can also be compiled as a module.

We don't add exports for no in-kernel users, sorry.  Send this as part
of a series that requires it.

> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> Reviewed-by: Dhruva Gole <d-gole@ti.com>
> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
> Tested-by: Kevin Hilman <khilman@baylibre.com>
> ---
> 
> Notes:
>     Changes in v2:
>      - Rephrase the commit message
>      - Move the patch out of the series
>        'firmware: ti_sci: Introduce system suspend support'

Odd, why did you do that?

thanks,

greg k-h
Re: [PATCH v2] PM: QoS: Export dev_pm_qos_read_value
Posted by Markus Schneider-Pargmann 1 month, 3 weeks ago 
On Thu, Oct 03, 2024 at 08:02:04AM GMT, Greg Kroah-Hartman wrote:
> On Wed, Oct 02, 2024 at 09:44:46PM +0200, Markus Schneider-Pargmann wrote:
> > Export the function dev_pm_qos_read_value(). Most other functions
> > mentioned in Documentation/power/pm_qos_interface.rst are already
> > exported, so export this one as well.
> > 
> > This function will be used to read the resume latency in a driver that
> > can also be compiled as a module.
> 
> We don't add exports for no in-kernel users, sorry.  Send this as part
> of a series that requires it.

Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that
can be built as a module. When built as a module it can't use this
function if it is not exported.

> 
> > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> > Reviewed-by: Dhruva Gole <d-gole@ti.com>
> > Reviewed-by: Kevin Hilman <khilman@baylibre.com>
> > Tested-by: Kevin Hilman <khilman@baylibre.com>
> > ---
> > 
> > Notes:
> >     Changes in v2:
> >      - Rephrase the commit message
> >      - Move the patch out of the series
> >        'firmware: ti_sci: Introduce system suspend support'
> 
> Odd, why did you do that?

It was suggested to me off-list that it may be better or easier to send
this separately.

Best
Markus
Re: [PATCH v2] PM: QoS: Export dev_pm_qos_read_value
Posted by Greg Kroah-Hartman 1 month, 3 weeks ago 
On Thu, Oct 03, 2024 at 08:28:12AM +0200, Markus Schneider-Pargmann wrote:
> On Thu, Oct 03, 2024 at 08:02:04AM GMT, Greg Kroah-Hartman wrote:
> > On Wed, Oct 02, 2024 at 09:44:46PM +0200, Markus Schneider-Pargmann wrote:
> > > Export the function dev_pm_qos_read_value(). Most other functions
> > > mentioned in Documentation/power/pm_qos_interface.rst are already
> > > exported, so export this one as well.
> > > 
> > > This function will be used to read the resume latency in a driver that
> > > can also be compiled as a module.
> > 
> > We don't add exports for no in-kernel users, sorry.  Send this as part
> > of a series that requires it.
> 
> Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that
> can be built as a module. When built as a module it can't use this
> function if it is not exported.

So the current kernel build is broken?  If so, please add a "Fixes:" tag
and say this in the changelog.

If not, again, just make it part of the series where it is needed.

thanks,

greg k-h
Re: [PATCH v2] PM: QoS: Export dev_pm_qos_read_value
Posted by Nishanth Menon 1 month ago 
On 08:49-20241003, Greg Kroah-Hartman wrote:
> On Thu, Oct 03, 2024 at 08:28:12AM +0200, Markus Schneider-Pargmann wrote:
> > On Thu, Oct 03, 2024 at 08:02:04AM GMT, Greg Kroah-Hartman wrote:
> > > On Wed, Oct 02, 2024 at 09:44:46PM +0200, Markus Schneider-Pargmann wrote:
> > > > Export the function dev_pm_qos_read_value(). Most other functions
> > > > mentioned in Documentation/power/pm_qos_interface.rst are already
> > > > exported, so export this one as well.
> > > > 
> > > > This function will be used to read the resume latency in a driver that
> > > > can also be compiled as a module.
> > > 
> > > We don't add exports for no in-kernel users, sorry.  Send this as part
> > > of a series that requires it.
> > 
> > Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that
> > can be built as a module. When built as a module it can't use this
> > function if it is not exported.
> 
> So the current kernel build is broken?  If so, please add a "Fixes:" tag
> and say this in the changelog.
> 
> If not, again, just make it part of the series where it is needed.
> 

Greg, Rafael, How do you wish to route this patch in?

This patch is a dependency of [1] which goes through my tree.
If  you can provide an ack, I can pick up the patch through my tree,
else we will end up with dependency issue here.

[1] https://lore.kernel.org/all/20241007-tisci-syssuspendresume-v13-0-ed54cd659a49@baylibre.com/

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
Re: [PATCH v2] PM: QoS: Export dev_pm_qos_read_value
Posted by Rafael J. Wysocki 1 month ago 
On Fri, Oct 25, 2024 at 3:15 PM Nishanth Menon <nm@ti.com> wrote:
>
> On 08:49-20241003, Greg Kroah-Hartman wrote:
> > On Thu, Oct 03, 2024 at 08:28:12AM +0200, Markus Schneider-Pargmann wrote:
> > > On Thu, Oct 03, 2024 at 08:02:04AM GMT, Greg Kroah-Hartman wrote:
> > > > On Wed, Oct 02, 2024 at 09:44:46PM +0200, Markus Schneider-Pargmann wrote:
> > > > > Export the function dev_pm_qos_read_value(). Most other functions
> > > > > mentioned in Documentation/power/pm_qos_interface.rst are already
> > > > > exported, so export this one as well.
> > > > >
> > > > > This function will be used to read the resume latency in a driver that
> > > > > can also be compiled as a module.
> > > >
> > > > We don't add exports for no in-kernel users, sorry.  Send this as part
> > > > of a series that requires it.
> > >
> > > Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that
> > > can be built as a module. When built as a module it can't use this
> > > function if it is not exported.
> >
> > So the current kernel build is broken?  If so, please add a "Fixes:" tag
> > and say this in the changelog.
> >
> > If not, again, just make it part of the series where it is needed.
> >
>
> Greg, Rafael, How do you wish to route this patch in?
>
> This patch is a dependency of [1] which goes through my tree.
> If  you can provide an ack, I can pick up the patch through my tree,
> else we will end up with dependency issue here.
>
> [1] https://lore.kernel.org/all/20241007-tisci-syssuspendresume-v13-0-ed54cd659a49@baylibre.com/

Sure, please feel free to add

Acked-by: Rafael J. Wysocki <rafael@kernel.org>

to it.

Thanks!
Re: [PATCH v2] PM: QoS: Export dev_pm_qos_read_value
Posted by Nishanth Menon 1 month ago 
On 16:50-20241025, Rafael J. Wysocki wrote:
[...]

> > Greg, Rafael, How do you wish to route this patch in?
> >
> > This patch is a dependency of [1] which goes through my tree.
> > If  you can provide an ack, I can pick up the patch through my tree,
> > else we will end up with dependency issue here.
> >
> > [1] https://lore.kernel.org/all/20241007-tisci-syssuspendresume-v13-0-ed54cd659a49@baylibre.com/
> 
> Sure, please feel free to add
> 
> Acked-by: Rafael J. Wysocki <rafael@kernel.org>
> 
> to it.
> 
> Thanks!

Thanks for the ack, will queue things up.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
Re: [PATCH v2] PM: QoS: Export dev_pm_qos_read_value
Posted by Markus Schneider-Pargmann 1 month, 3 weeks ago 
On Thu, Oct 03, 2024 at 08:49:48AM GMT, Greg Kroah-Hartman wrote:
> On Thu, Oct 03, 2024 at 08:28:12AM +0200, Markus Schneider-Pargmann wrote:
> > On Thu, Oct 03, 2024 at 08:02:04AM GMT, Greg Kroah-Hartman wrote:
> > > On Wed, Oct 02, 2024 at 09:44:46PM +0200, Markus Schneider-Pargmann wrote:
> > > > Export the function dev_pm_qos_read_value(). Most other functions
> > > > mentioned in Documentation/power/pm_qos_interface.rst are already
> > > > exported, so export this one as well.
> > > > 
> > > > This function will be used to read the resume latency in a driver that
> > > > can also be compiled as a module.
> > > 
> > > We don't add exports for no in-kernel users, sorry.  Send this as part
> > > of a series that requires it.
> > 
> > Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that
> > can be built as a module. When built as a module it can't use this
> > function if it is not exported.
> 
> So the current kernel build is broken?  If so, please add a "Fixes:" tag
> and say this in the changelog.
> 
> If not, again, just make it part of the series where it is needed.

It is not a fix, I will reintegrate it with the series that needs it.

Thanks!

Best
Markus

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.