This patch series addresses coding style improvements in
the Nubus subsystem, specifically in `nubus.c`. These changes
aim to enhance readability and maintainability of the code.

These coding style inconsistencies were found using checkpatch.pl

Changes include:
 1. Improved comment block formatting by aligning `*` in
    multi-line comments.
 2. Fixing assignments inside conditional statements to improve clarity.
 3. Correcting the use of tabs for indentation in specific functions.

Each commit focuses on a specific aspect, as detailed below.


Sayyad Abid (3):
  Fix use of tabs in nubus_get_vendorinfo and nubus_add_board
  Fix use of assignment in if condition in nubus_add_board()
  Fix use of * in comment block in nubus.c

 drivers/nubus/nubus.c | 94 ++++++++++++++++++++++++-------------------
 1 file changed, 53 insertions(+), 41 deletions(-)

--
2.39.5

Hello sayyad.abid16@gmail.com

Thanks for taking the trouble to send e-mail messages to so many people by 
use of a free e-mail account.

With regards to kernel patches, can I request that you --

1. Don't run checkpatch on existing code
2. Don't send patches that break the build
3. Don't claim to be improving code style by sending patches that violate 
   code style rules
4. Read the mailing lists and study the development process before trying 
   to contribute

Thanks for your consideration.

Regards
Finn

On Wed, 2 Oct 2024, Sayyad Abid wrote:

> This patch series addresses coding style improvements in
> the Nubus subsystem, specifically in `nubus.c`. These changes
> aim to enhance readability and maintainability of the code.
> 
> These coding style inconsistencies were found using checkpatch.pl
> 
> Changes include:
>  1. Improved comment block formatting by aligning `*` in
>     multi-line comments.
>  2. Fixing assignments inside conditional statements to improve clarity.
>  3. Correcting the use of tabs for indentation in specific functions.
> 
> Each commit focuses on a specific aspect, as detailed below.
> 
> 
> Sayyad Abid (3):
>   Fix use of tabs in nubus_get_vendorinfo and nubus_add_board
>   Fix use of assignment in if condition in nubus_add_board()
>   Fix use of * in comment block in nubus.c
> 
>  drivers/nubus/nubus.c | 94 ++++++++++++++++++++++++-------------------
>  1 file changed, 53 insertions(+), 41 deletions(-)
> 
> --
> 2.39.5
> 
>

On Thu, Oct 3, 2024 at 4:25 AM Finn Thain <fthain@linux-m68k.org> wrote:
>
>
> Hello sayyad.abid16@gmail.com
>
> Thanks for taking the trouble to send e-mail messages to so many people by
> use of a free e-mail account.
>
> With regards to kernel patches, can I request that you --
>
> 1. Don't run checkpatch on existing code
> 2. Don't send patches that break the build
> 3. Don't claim to be improving code style by sending patches that violate
>    code style rules
> 4. Read the mailing lists and study the development process before trying
>    to contribute
>
> Thanks for your consideration.
>
> Regards
> Finn
>
> On Wed, 2 Oct 2024, Sayyad Abid wrote:
>
> > This patch series addresses coding style improvements in
> > the Nubus subsystem, specifically in `nubus.c`. These changes
> > aim to enhance readability and maintainability of the code.
> >
> > These coding style inconsistencies were found using checkpatch.pl
> >
> > Changes include:
> >  1. Improved comment block formatting by aligning `*` in
> >     multi-line comments.
> >  2. Fixing assignments inside conditional statements to improve clarity.
> >  3. Correcting the use of tabs for indentation in specific functions.
> >
> > Each commit focuses on a specific aspect, as detailed below.
> >
> >
> > Sayyad Abid (3):
> >   Fix use of tabs in nubus_get_vendorinfo and nubus_add_board
> >   Fix use of assignment in if condition in nubus_add_board()
> >   Fix use of * in comment block in nubus.c
> >
> >  drivers/nubus/nubus.c | 94 ++++++++++++++++++++++++-------------------
> >  1 file changed, 53 insertions(+), 41 deletions(-)
> >
> > --
> > 2.39.5
> >
> >
My sincere apologies for causing the trouble,
I overlooked a few things there,
I will keep a note of your points and make sure
that it is not repeated again.

Thank You!

-- 
Abid

On 10/2/24 07:28, Sayyad Abid wrote:
> This patch series addresses coding style improvements in
> the Nubus subsystem, specifically in `nubus.c`. These changes
> aim to enhance readability and maintainability of the code.
> 
> These coding style inconsistencies were found using checkpatch.pl
> 
> Changes include:
>   1. Improved comment block formatting by aligning `*` in
>      multi-line comments.
>   2. Fixing assignments inside conditional statements to improve clarity.
>   3. Correcting the use of tabs for indentation in specific functions.
> 
> Each commit focuses on a specific aspect, as detailed below.
> 
> 
> Sayyad Abid (3):
>    Fix use of tabs in nubus_get_vendorinfo and nubus_add_board
>    Fix use of assignment in if condition in nubus_add_board()
>    Fix use of * in comment block in nubus.c
> 
>   drivers/nubus/nubus.c | 94 ++++++++++++++++++++++++-------------------
>   1 file changed, 53 insertions(+), 41 deletions(-)
> 
> --
> 2.39.5
> 

Why are you sending 3 patches for these changes in one single
file?

thanks,
-- Shuah