[PATCH] gpio: gpio-davinci: Fix condition for irqchip registration

Vignesh Raghavendra posted 1 patch 1 month, 3 weeks ago
drivers/gpio/gpio-davinci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] gpio: gpio-davinci: Fix condition for irqchip registration
Posted by Vignesh Raghavendra 1 month, 3 weeks ago
Since commit d29e741cad3f ("gpio: davinci: drop platform data support"),
irqchip is no longer being registered on platforms what don't use
unbanked gpios. Fix this.

Reported-by: Sabeeh Khan <sabeeh-khan@ti.com>
Fixes: d29e741cad3f ("gpio: davinci: drop platform data support")
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 drivers/gpio/gpio-davinci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 790595f3b949..76b58c70b257 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -472,7 +472,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
 		return PTR_ERR(clk);
 	}
 
-	if (chips->gpio_unbanked) {
+	if (!chips->gpio_unbanked) {
 		irq = devm_irq_alloc_descs(dev, -1, 0, ngpio, 0);
 		if (irq < 0) {
 			dev_err(dev, "Couldn't allocate IRQ numbers\n");
-- 
2.46.2
Re: [PATCH] gpio: gpio-davinci: Fix condition for irqchip registration
Posted by Bartosz Golaszewski 1 month, 3 weeks ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 02 Oct 2024 12:49:01 +0530, Vignesh Raghavendra wrote:
> Since commit d29e741cad3f ("gpio: davinci: drop platform data support"),
> irqchip is no longer being registered on platforms what don't use
> unbanked gpios. Fix this.
> 
> 

My bad, thanks for spotting this.

Applied, thanks!

[1/1] gpio: gpio-davinci: Fix condition for irqchip registration
      commit: 69e40c3ef27998105b3002434ee640800d376668

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>