drm: Fix up and error handling after fbdev changes

[PATCH 0/2] drm: Fix up and error handling after fbdev changes

Dave Stevenson posted 2 patches 1 month, 3 weeks ago

Download series mbox

drivers/gpu/drm/drm_fb_helper.c | 2 ++
drivers/gpu/drm/vc4/vc4_drv.c   | 1 +
2 files changed, 3 insertions(+)

Expand all Fold all

[PATCH 0/2] drm: Fix up and error handling after fbdev changes

Posted by Dave Stevenson 1 month, 3 weeks ago

I was trying dri-misc-next on Pi4 and getting a NULL deref as vc4
started. The cause was having missed adding DRM_FBDEV_DMA_DRIVER_OPS
to the 2711 struct drm_driver, but also showed up that the handling
in drm_fb_helper_single_fb_probe could fail to call any fbdev_probe
function, and hence the NULL deref.

These two patches fix up vc4, but also throw an error if neither
driver->fbdev_probe nor funcs->fb_probe are defined.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
Dave Stevenson (2):
      drm/vc4: Run default client setup for all variants.
      drm/fbdev: Ensure that one of the probe functions is defined

 drivers/gpu/drm/drm_fb_helper.c | 2 ++
 drivers/gpu/drm/vc4/vc4_drv.c   | 1 +
 2 files changed, 3 insertions(+)
---
base-commit: 86fdd6b9b1e98cfd26249505e8ce72f4fc0de37f
change-id: 20241002-vc4_fbdev_fix-f4c8b11928cd

Best regards,
-- 
Dave Stevenson <dave.stevenson@raspberrypi.com>