Input: hideep - add missing dependency on REGMAP_I2C

[PATCH] Input: hideep - add missing dependency on REGMAP_I2C

Posted by Javier Carrasco 1 month, 3 weeks ago

hideep makes use of regmap_i2c, and it has to be selected within its
Kconfig entry to compile successfully.

Fixes: 842ff286166e ("Input: add support for HiDeep touchscreen")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Building this module will fail at least with gcc-12/13 and a simple
.config that does not include REGMAP.
---
 drivers/input/touchscreen/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 1ac26fc2e3eb..601fa7ec2e8a 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -420,6 +420,7 @@ config TOUCHSCREEN_GOODIX_BERLIN_SPI
 config TOUCHSCREEN_HIDEEP
 	tristate "HiDeep Touch IC"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  Say Y here if you have a touchscreen using HiDeep.
 

---
base-commit: fe21733536749bb1b31c9c84e0b8d2ab8d82ce13
change-id: 20241002-input-hideep-select-remap-i2c-d785b9d677db

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>

Re: [PATCH] Input: hideep - add missing dependency on REGMAP_I2C

Posted by Dmitry Torokhov 1 month, 3 weeks ago

On Wed, Oct 02, 2024 at 10:42:30PM +0200, Javier Carrasco wrote:
> hideep makes use of regmap_i2c, and it has to be selected within its
> Kconfig entry to compile successfully.
> 
> Fixes: 842ff286166e ("Input: add support for HiDeep touchscreen")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

Applied, thank you.

-- 
Dmitry