ARM: dts: nuvoton: Add OHCI node

[PATCH] ARM: dts: nuvoton: Add OHCI node

Posted by William A. Kennington III 1 month, 4 weeks ago

From: "William A. Kennington III" <wak@google.com>

The EHCI peripheral already exists in the devicetree, but the hardware
also supports a discrete OHCI unit on the same USB PHY. Generic OHCI
works fine for this device already and has been tested on real hardware.

Signed-off-by: William A. Kennington III <wak@google.com>
---
 arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
index 358b52894ac0..5aeb5009a5d7 100644
--- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
+++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
@@ -142,6 +142,13 @@ gmac0: eth@f0802000 {
 			status = "disabled";
 		};
 
+		ohci1: ohci@f0807000 {
+			compatible = "generic-ohci";
+			reg = <0xf0807000 0x1000>;
+			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
 		ehci1: usb@f0806000 {
 			compatible = "nuvoton,npcm750-ehci";
 			reg = <0xf0806000 0x1000>;
-- 
2.46.1.824.gd892dcdcdd-goog

Re: [PATCH] ARM: dts: nuvoton: Add OHCI node

Posted by Andrew Jeffery 1 month, 3 weeks ago

Hi William,

On Mon, 2024-09-30 at 14:43 -0700, William A. Kennington III wrote:
> From: "William A. Kennington III" <wak@google.com>
> 
> The EHCI peripheral already exists in the devicetree, but the hardware
> also supports a discrete OHCI unit on the same USB PHY. Generic OHCI
> works fine for this device already and has been tested on real hardware.
> 
> Signed-off-by: William A. Kennington III <wak@google.com>
> ---
>  arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> index 358b52894ac0..5aeb5009a5d7 100644
> --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> @@ -142,6 +142,13 @@ gmac0: eth@f0802000 {
>  			status = "disabled";
>  		};
>  
> +		ohci1: ohci@f0807000 {

I got an additional warning here too:

+/home/andrew/src/kernel.org/linux/origin/build.multi_v5/arch/arm/boot/dts/nuvoton/nuvoton-npcm750-evb.dtb: ohci@f0807000: $nodename:0: 'ohci@f0807000' does not match '^usb(@.*)?'
+       from schema $id: http://devicetree.org/schemas/usb/generic-ohci.yaml#

Andrew

> +			compatible = "generic-ohci";
> +			reg = <0xf0807000 0x1000>;
> +			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
> +			status = "disabled";
> +		};
> +
>  		ehci1: usb@f0806000 {
>  			compatible = "nuvoton,npcm750-ehci";
>  			reg = <0xf0806000 0x1000>;