1. Patchew
  2. linux
  3. [PATCH 0/4] ARM: dts: omap: omap4-epson-embt2ws: misc gpio definitions
  4. View patch

[PATCH 2/4] ARM: dts: omap: omap4-epson-embt2ws: wire up regulators

Andreas Kemnade posted 4 patches 1 month, 4 weeks ago
There is a newer version of this series
[PATCH 2/4] ARM: dts: omap: omap4-epson-embt2ws: wire up regulators
Posted by Andreas Kemnade 1 month, 4 weeks ago 
Wire up the regulators where usage is plausible. Do not
wire them if purpose/usage is unclear like 5V for
many things requiring lower voltages.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
index d6b0abba19f6..cc1b6080bf95 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
+++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
@@ -20,13 +20,13 @@ memory@80000000 {
 	backlight-left {
 		compatible = "pwm-backlight";
 		pwms = <&twl_pwm 1 7812500>;
-		power-supply = <&unknown_supply>;
+		power-supply = <&lb_v50>;
 	};
 
 	backlight-right {
 		compatible = "pwm-backlight";
 		pwms = <&twl_pwm 0 7812500>;
-		power-supply = <&unknown_supply>;
+		power-supply = <&lb_v50>;
 	};
 
 	cb_v18: cb-v18 {
@@ -95,11 +95,6 @@ lb_v50: lb-v50 {
 		enable-active-high;
 	};
 
-	unknown_supply: unknown-supply {
-		compatible = "regulator-fixed";
-		regulator-name = "unknown";
-	};
-
 	wl12xx_pwrseq: wl12xx-pwrseq {
 		compatible = "mmc-pwrseq-simple";
 		clocks = <&twl 1>;
@@ -308,6 +303,8 @@ mpu9150: imu@68 {
 		pinctrl-0 = <&mpu9150_pins>;
 		interrupt-parent = <&gpio2>;
 		interrupt = <7 IRQ_TYPE_LEVEL_HIGH>;
+		vddio-supply = <&cb_v18>;
+		vdd-supply = <&cb_v33>;
 		invensense,level-shifter;
 	};
 };
-- 
2.39.5
Re: [PATCH 2/4] ARM: dts: omap: omap4-epson-embt2ws: wire up regulators
Posted by Roger Quadros 1 month, 3 weeks ago 

On 01/10/2024 00:30, Andreas Kemnade wrote:
> Wire up the regulators where usage is plausible. Do not
> wire them if purpose/usage is unclear like 5V for
> many things requiring lower voltages.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> index d6b0abba19f6..cc1b6080bf95 100644
> --- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> +++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> @@ -20,13 +20,13 @@ memory@80000000 {
>  	backlight-left {
>  		compatible = "pwm-backlight";
>  		pwms = <&twl_pwm 1 7812500>;
> -		power-supply = <&unknown_supply>;
> +		power-supply = <&lb_v50>;

This is probably wrong. I noticed this while reviewing patch 3.

you probably want to wire this to blc_l?

>  	};
>  
>  	backlight-right {
>  		compatible = "pwm-backlight";
>  		pwms = <&twl_pwm 0 7812500>;
> -		power-supply = <&unknown_supply>;
> +		power-supply = <&lb_v50>;

this one should be wired to blc_r?

>  	};
>  
>  	cb_v18: cb-v18 {
> @@ -95,11 +95,6 @@ lb_v50: lb-v50 {
>  		enable-active-high;
>  	};
>  
> -	unknown_supply: unknown-supply {
> -		compatible = "regulator-fixed";
> -		regulator-name = "unknown";
> -	};
> -
>  	wl12xx_pwrseq: wl12xx-pwrseq {
>  		compatible = "mmc-pwrseq-simple";
>  		clocks = <&twl 1>;
> @@ -308,6 +303,8 @@ mpu9150: imu@68 {
>  		pinctrl-0 = <&mpu9150_pins>;
>  		interrupt-parent = <&gpio2>;
>  		interrupt = <7 IRQ_TYPE_LEVEL_HIGH>;
> +		vddio-supply = <&cb_v18>;
> +		vdd-supply = <&cb_v33>;
>  		invensense,level-shifter;
>  	};
>  };

-- 
cheers,
-roger
Re: [PATCH 2/4] ARM: dts: omap: omap4-epson-embt2ws: wire up regulators
Posted by Andreas Kemnade 1 month, 3 weeks ago 
Am Fri, 4 Oct 2024 10:38:22 +0300
schrieb Roger Quadros <rogerq@kernel.org>:

> On 01/10/2024 00:30, Andreas Kemnade wrote:
> > Wire up the regulators where usage is plausible. Do not
> > wire them if purpose/usage is unclear like 5V for
> > many things requiring lower voltages.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> >  arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 11 ++++-------
> >  1 file changed, 4 insertions(+), 7 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> > b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts index
> > d6b0abba19f6..cc1b6080bf95 100644 ---
> > a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +++
> > b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts @@ -20,13
> > +20,13 @@ memory@80000000 { backlight-left {
> >  		compatible = "pwm-backlight";
> >  		pwms = <&twl_pwm 1 7812500>;
> > -		power-supply = <&unknown_supply>;
> > +		power-supply = <&lb_v50>;  
> 
> This is probably wrong. I noticed this while reviewing patch 3.
> 
> you probably want to wire this to blc_l?
> 
No idea was blc_l is. I did not find any code handling blc_l.
looking at the vendor kernel:

$ grep -R BLC_L_GPIO *
arch/arm/mach-omap2/board-bt2ws.c:#define BLC_L_GPIO
16	/* LB LED GPIO */ arch/arm/mach-omap2/board-bt2ws.c:
{BLC_L_GPIO,   GPIOF_OUT_INIT_LOW,  "gpio_blc_l"   },
arch/arm/mach-omap2/board-bt2ws.c:	gpio_export(BLC_L_GPIO, 0);
arch/arm/mach-omap2/board-bt2ts.c:#define BLC_L_GPIO
16	/* LB LED GPIO */ arch/arm/mach-omap2/board-bt2ts.c:
{BLC_L_GPIO,   GPIOF_OUT_INIT_LOW,  "gpio_blc_l"   },
arch/arm/mach-omap2/board-bt2ts.c:	gpio_export(BLC_L_GPIO, 0);

These two gpios are exported. But they seem not to influence
backlight in any way. I just tested again to make sure. Maybe it is just
a leftover from earlier board revisions.

> >  	};
> >  
> >  	backlight-right {
> >  		compatible = "pwm-backlight";
> >  		pwms = <&twl_pwm 0 7812500>;
> > -		power-supply = <&unknown_supply>;
> > +		power-supply = <&lb_v50>;  
> 
> this one should be wired to blc_r?
>
Same as with blc_l.
$ grep -R BLC_R_GPIO *
arch/arm/mach-omap2/board-bt2ws.c:#define BLC_R_GPIO
17	/* LB LED GPIO */ arch/arm/mach-omap2/board-bt2ws.c:
{BLC_R_GPIO,   GPIOF_OUT_INIT_LOW,  "gpio_blc_r"   },
arch/arm/mach-omap2/board-bt2ws.c:	gpio_export(BLC_R_GPIO, 0);
arch/arm/mach-omap2/board-bt2ts.c:#define BLC_R_GPIO
17	/* LB LED GPIO */ arch/arm/mach-omap2/board-bt2ts.c:
{BLC_R_GPIO,   GPIOF_OUT_INIT_LOW,  "gpio_blc_r"   },
arch/arm/mach-omap2/board-bt2ts.c:	gpio_export(BLC_R_GPIO, 0);

Regards,
Andreas
Re: [PATCH 2/4] ARM: dts: omap: omap4-epson-embt2ws: wire up regulators
Posted by Roger Quadros 1 month, 3 weeks ago 

On 04/10/2024 12:01, Andreas Kemnade wrote:
> Am Fri, 4 Oct 2024 10:38:22 +0300
> schrieb Roger Quadros <rogerq@kernel.org>:
> 
>> On 01/10/2024 00:30, Andreas Kemnade wrote:
>>> Wire up the regulators where usage is plausible. Do not
>>> wire them if purpose/usage is unclear like 5V for
>>> many things requiring lower voltages.
>>>
>>> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
>>> ---
>>>  arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 11 ++++-------
>>>  1 file changed, 4 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
>>> b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts index
>>> d6b0abba19f6..cc1b6080bf95 100644 ---
>>> a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +++
>>> b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts @@ -20,13
>>> +20,13 @@ memory@80000000 { backlight-left {
>>>  		compatible = "pwm-backlight";
>>>  		pwms = <&twl_pwm 1 7812500>;
>>> -		power-supply = <&unknown_supply>;
>>> +		power-supply = <&lb_v50>;  
>>
>> This is probably wrong. I noticed this while reviewing patch 3.
>>
>> you probably want to wire this to blc_l?
>>
> No idea was blc_l is. I did not find any code handling blc_l.
> looking at the vendor kernel:
> 
> $ grep -R BLC_L_GPIO *
> arch/arm/mach-omap2/board-bt2ws.c:#define BLC_L_GPIO
> 16	/* LB LED GPIO */ arch/arm/mach-omap2/board-bt2ws.c:
> {BLC_L_GPIO,   GPIOF_OUT_INIT_LOW,  "gpio_blc_l"   },
> arch/arm/mach-omap2/board-bt2ws.c:	gpio_export(BLC_L_GPIO, 0);
> arch/arm/mach-omap2/board-bt2ts.c:#define BLC_L_GPIO
> 16	/* LB LED GPIO */ arch/arm/mach-omap2/board-bt2ts.c:
> {BLC_L_GPIO,   GPIOF_OUT_INIT_LOW,  "gpio_blc_l"   },
> arch/arm/mach-omap2/board-bt2ts.c:	gpio_export(BLC_L_GPIO, 0);
> 
> These two gpios are exported. But they seem not to influence
> backlight in any way. I just tested again to make sure. Maybe it is just
> a leftover from earlier board revisions.

OK. you could then leave it as it is now.

> 
>>>  	};
>>>  
>>>  	backlight-right {
>>>  		compatible = "pwm-backlight";
>>>  		pwms = <&twl_pwm 0 7812500>;
>>> -		power-supply = <&unknown_supply>;
>>> +		power-supply = <&lb_v50>;  
>>
>> this one should be wired to blc_r?
>>
> Same as with blc_l.
> $ grep -R BLC_R_GPIO *
> arch/arm/mach-omap2/board-bt2ws.c:#define BLC_R_GPIO
> 17	/* LB LED GPIO */ arch/arm/mach-omap2/board-bt2ws.c:
> {BLC_R_GPIO,   GPIOF_OUT_INIT_LOW,  "gpio_blc_r"   },
> arch/arm/mach-omap2/board-bt2ws.c:	gpio_export(BLC_R_GPIO, 0);
> arch/arm/mach-omap2/board-bt2ts.c:#define BLC_R_GPIO
> 17	/* LB LED GPIO */ arch/arm/mach-omap2/board-bt2ts.c:
> {BLC_R_GPIO,   GPIOF_OUT_INIT_LOW,  "gpio_blc_r"   },
> arch/arm/mach-omap2/board-bt2ts.c:	gpio_export(BLC_R_GPIO, 0);
> 
> Regards,
> Andreas

-- 
cheers,
-roger
Re: [PATCH 2/4] ARM: dts: omap: omap4-epson-embt2ws: wire up regulators
Posted by Roger Quadros 1 month, 3 weeks ago 

On 01/10/2024 00:30, Andreas Kemnade wrote:
> Wire up the regulators where usage is plausible. Do not
> wire them if purpose/usage is unclear like 5V for
> many things requiring lower voltages.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Reviewed-by: Roger Quadros <rogerq@kernel.org>

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.