[PATCH v2 2/3] dt-bindings: mfd: twl: add charger node also for TWL603x

Andreas Kemnade posted 3 patches 1 month, 4 weeks ago
There is a newer version of this series
[PATCH v2 2/3] dt-bindings: mfd: twl: add charger node also for TWL603x
Posted by Andreas Kemnade 1 month, 4 weeks ago
Also the TWL603X devices have a charger, so allow to specify it here.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 .../devicetree/bindings/mfd/ti,twl.yaml       | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
index e94b0fd7af0f8..488d419b211d1 100644
--- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
@@ -105,6 +105,12 @@ allOf:
             regulator-initial-mode: false
 
       properties:
+        charger:
+          type: object
+          additionalProperties: true
+          properties:
+            compatible:
+              const: ti,twl6030-charger
         gpadc:
           type: object
           properties:
@@ -136,6 +142,14 @@ allOf:
             regulator-initial-mode: false
 
       properties:
+        charger:
+          type: object
+          additionalProperties: true
+          properties:
+            compatible:
+              items:
+                - const: ti,twl6032-charger
+                - const: ti,twl6030-charger
         gpadc:
           type: object
           properties:
@@ -222,6 +236,14 @@ examples:
         interrupt-controller;
         #interrupt-cells = <1>;
 
+        charger {
+          compatible = "ti,twl6030-charger";
+          interrupts = <2>, <5>;
+          io-channels = <&gpadc 10>;
+          io-channel-names = "vusb";
+          monitored-battery = <&bat>;
+        };
+
         gpadc {
           compatible = "ti,twl6030-gpadc";
           interrupts = <6>;
-- 
2.39.2
Re: [PATCH v2 2/3] dt-bindings: mfd: twl: add charger node also for TWL603x
Posted by Krzysztof Kozlowski 1 month, 4 weeks ago
On Mon, Sep 30, 2024 at 05:54:03PM +0200, Andreas Kemnade wrote:
> Also the TWL603X devices have a charger, so allow to specify it here.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  .../devicetree/bindings/mfd/ti,twl.yaml       | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> index e94b0fd7af0f8..488d419b211d1 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> @@ -105,6 +105,12 @@ allOf:
>              regulator-initial-mode: false
>  
>        properties:
> +        charger:

Properties should be defined in top-level, mot in allOf. You can
disallow them for certain variants.

Best regards,
Krzysztof