Reorganize kerneldoc parameter names to match the parameter
order in the function header.

Problems identified using Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c |    2 +-
 drivers/gpu/drm/radeon/radeon_ib.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 6005280f5f38..ad4fdd4d4d82 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -2773,11 +2773,11 @@ int amdgpu_vm_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
  * amdgpu_vm_handle_fault - graceful handling of VM faults.
  * @adev: amdgpu device pointer
  * @pasid: PASID of the VM
- * @ts: Timestamp of the fault
  * @vmid: VMID, only used for GFX 9.4.3.
  * @node_id: Node_id received in IH cookie. Only applicable for
  *           GFX 9.4.3.
  * @addr: Address of the fault
+ * @ts: Timestamp of the fault
  * @write_fault: true is write fault, false is read fault
  *
  * Try to gracefully handle a VM fault. Return true if the fault was handled and
diff --git a/drivers/gpu/drm/radeon/radeon_ib.c b/drivers/gpu/drm/radeon/radeon_ib.c
index 1aa41cc3f991..8611a27dfb3d 100644
--- a/drivers/gpu/drm/radeon/radeon_ib.c
+++ b/drivers/gpu/drm/radeon/radeon_ib.c
@@ -49,8 +49,8 @@ static void radeon_debugfs_sa_init(struct radeon_device *rdev);
  *
  * @rdev: radeon_device pointer
  * @ring: ring index the IB is associated with
- * @vm: requested vm
  * @ib: IB object returned
+ * @vm: requested vm
  * @size: requested IB size
  *
  * Request an IB (all asics).  IBs are allocated using the

Am 30.09.24 um 13:21 schrieb Julia Lawall:
> Reorganize kerneldoc parameter names to match the parameter
> order in the function header.

Please split that up by driver, apart from that looks good to me.

Christian.

>
> Problems identified using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c |    2 +-
>   drivers/gpu/drm/radeon/radeon_ib.c     |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 6005280f5f38..ad4fdd4d4d82 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2773,11 +2773,11 @@ int amdgpu_vm_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
>    * amdgpu_vm_handle_fault - graceful handling of VM faults.
>    * @adev: amdgpu device pointer
>    * @pasid: PASID of the VM
> - * @ts: Timestamp of the fault
>    * @vmid: VMID, only used for GFX 9.4.3.
>    * @node_id: Node_id received in IH cookie. Only applicable for
>    *           GFX 9.4.3.
>    * @addr: Address of the fault
> + * @ts: Timestamp of the fault
>    * @write_fault: true is write fault, false is read fault
>    *
>    * Try to gracefully handle a VM fault. Return true if the fault was handled and
> diff --git a/drivers/gpu/drm/radeon/radeon_ib.c b/drivers/gpu/drm/radeon/radeon_ib.c
> index 1aa41cc3f991..8611a27dfb3d 100644
> --- a/drivers/gpu/drm/radeon/radeon_ib.c
> +++ b/drivers/gpu/drm/radeon/radeon_ib.c
> @@ -49,8 +49,8 @@ static void radeon_debugfs_sa_init(struct radeon_device *rdev);
>    *
>    * @rdev: radeon_device pointer
>    * @ring: ring index the IB is associated with
> - * @vm: requested vm
>    * @ib: IB object returned
> + * @vm: requested vm
>    * @size: requested IB size
>    *
>    * Request an IB (all asics).  IBs are allocated using the
>

On Mon, 30 Sep 2024, Christian König wrote:

> Am 30.09.24 um 13:21 schrieb Julia Lawall:
> > Reorganize kerneldoc parameter names to match the parameter
> > order in the function header.
>
> Please split that up by driver, apart from that looks good to me.

Thanks for the feedback.  I will wait a bit for any other feedback and the
resend.

julia

>
> Christian.
>
> >
> > Problems identified using Coccinelle.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> >
> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c |    2 +-
> >   drivers/gpu/drm/radeon/radeon_ib.c     |    2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> > index 6005280f5f38..ad4fdd4d4d82 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> > @@ -2773,11 +2773,11 @@ int amdgpu_vm_ioctl(struct drm_device *dev, void
> > *data, struct drm_file *filp)
> >    * amdgpu_vm_handle_fault - graceful handling of VM faults.
> >    * @adev: amdgpu device pointer
> >    * @pasid: PASID of the VM
> > - * @ts: Timestamp of the fault
> >    * @vmid: VMID, only used for GFX 9.4.3.
> >    * @node_id: Node_id received in IH cookie. Only applicable for
> >    *           GFX 9.4.3.
> >    * @addr: Address of the fault
> > + * @ts: Timestamp of the fault
> >    * @write_fault: true is write fault, false is read fault
> >    *
> >    * Try to gracefully handle a VM fault. Return true if the fault was
> > handled and
> > diff --git a/drivers/gpu/drm/radeon/radeon_ib.c
> > b/drivers/gpu/drm/radeon/radeon_ib.c
> > index 1aa41cc3f991..8611a27dfb3d 100644
> > --- a/drivers/gpu/drm/radeon/radeon_ib.c
> > +++ b/drivers/gpu/drm/radeon/radeon_ib.c
> > @@ -49,8 +49,8 @@ static void radeon_debugfs_sa_init(struct radeon_device
> > *rdev);
> >    *
> >    * @rdev: radeon_device pointer
> >    * @ring: ring index the IB is associated with
> > - * @vm: requested vm
> >    * @ib: IB object returned
> > + * @vm: requested vm
> >    * @size: requested IB size
> >    *
> >    * Request an IB (all asics).  IBs are allocated using the
> >
>
>