ps3: Correct some typos in comments

[PATCH v1] ps3: Correct some typos in comments

Posted by Shen Lichuan 1 month, 4 weeks ago

Fixed some confusing typos that were currently identified with codespell,
the details are as follows:

-in the code comments:
drivers/ps3/ps3-lpm.c:94: rigths ==> rights
drivers/ps3/ps3-sys-manager.c:365: acnowledge ==> acknowledge
drivers/ps3/ps3-vuart.c:470: remaning ==> remaining
drivers/ps3/ps3-vuart.c:471: transmision ==> transmission
drivers/ps3/sys-manager-core.c:15: Staticly ==> Statically

Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
---
 drivers/ps3/ps3-lpm.c          | 2 +-
 drivers/ps3/ps3-sys-manager.c  | 2 +-
 drivers/ps3/ps3-vuart.c        | 4 ++--
 drivers/ps3/sys-manager-core.c | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/ps3/ps3-lpm.c b/drivers/ps3/ps3-lpm.c
index 200ad8751860..188ae2572674 100644
--- a/drivers/ps3/ps3-lpm.c
+++ b/drivers/ps3/ps3-lpm.c
@@ -91,7 +91,7 @@ struct ps3_lpm_shadow_regs {
  * struct ps3_lpm_priv - Private lpm device data.
  *
  * @open: An atomic variable indicating the lpm driver has been opened.
- * @rights: The lpm rigths granted by the system policy module.  A logical
+ * @rights: The lpm rights granted by the system policy module.  A logical
  *  OR of enum ps3_lpm_rights.
  * @node_id: The node id of a BE processor whose performance monitor this
  *  lpar has the right to use.
diff --git a/drivers/ps3/ps3-sys-manager.c b/drivers/ps3/ps3-sys-manager.c
index ad8ef59dea34..ab798b52910e 100644
--- a/drivers/ps3/ps3-sys-manager.c
+++ b/drivers/ps3/ps3-sys-manager.c
@@ -362,7 +362,7 @@ static int ps3_sys_manager_send_request_shutdown(
  * ps3_sys_manager_send_response - Send a 'response' to the system manager.
  * @status: zero = success, others fail.
  *
- * The guest sends this message to the system manager to acnowledge success or
+ * The guest sends this message to the system manager to acknowledge success or
  * failure of a command sent by the system manager.
  */
 
diff --git a/drivers/ps3/ps3-vuart.c b/drivers/ps3/ps3-vuart.c
index 6328abd51ffa..5cb92535a4a1 100644
--- a/drivers/ps3/ps3-vuart.c
+++ b/drivers/ps3/ps3-vuart.c
@@ -467,8 +467,8 @@ struct list_buffer {
  *
  * If the port is idle on entry as much of the incoming data is written to
  * the port as the port will accept.  Otherwise a list buffer is created
- * and any remaning incoming data is copied to that buffer.  The buffer is
- * then enqueued for transmision via the transmit interrupt.
+ * and any remaining incoming data is copied to that buffer.  The buffer is
+ * then enqueued for transmission via the transmit interrupt.
  */
 
 int ps3_vuart_write(struct ps3_system_bus_device *dev, const void *buf,
diff --git a/drivers/ps3/sys-manager-core.c b/drivers/ps3/sys-manager-core.c
index e061b7d0632b..f50032ad9702 100644
--- a/drivers/ps3/sys-manager-core.c
+++ b/drivers/ps3/sys-manager-core.c
@@ -12,7 +12,7 @@
 #include <asm/ps3.h>
 
 /**
- * Staticly linked routines that allow late binding of a loaded sys-manager
+ * Statically linked routines that allow late binding of a loaded sys-manager
  * module.
  */
 
-- 
2.17.1

Re: [PATCH v1] ps3: Correct some typos in comments

Posted by Michael Ellerman 1 week, 4 days ago

On Mon, 30 Sep 2024 10:32:34 +0800, Shen Lichuan wrote:
> Fixed some confusing typos that were currently identified with codespell,
> the details are as follows:
> 
> -in the code comments:
> drivers/ps3/ps3-lpm.c:94: rigths ==> rights
> drivers/ps3/ps3-sys-manager.c:365: acnowledge ==> acknowledge
> drivers/ps3/ps3-vuart.c:470: remaning ==> remaining
> drivers/ps3/ps3-vuart.c:471: transmision ==> transmission
> drivers/ps3/sys-manager-core.c:15: Staticly ==> Statically
> 
> [...]

Applied to powerpc/next.

[1/1] ps3: Correct some typos in comments
      https://git.kernel.org/powerpc/c/e9d3270007b13acd34de4256970ffe457efc6c65

cheers

Re: [PATCH v1] ps3: Correct some typos in comments

Posted by Christophe Leroy 1 month, 3 weeks ago


Le 30/09/2024 à 04:32, Shen Lichuan a écrit :
> [Vous ne recevez pas souvent de courriers de shenlichuan@vivo.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> Fixed some confusing typos that were currently identified with codespell,
> the details are as follows:

What is confusing in those typos ? Sure they are typos but I can't see 
any confusing meaning behind. There is no ambiguity.

I would agree if for instance you had "live" instead of "leave", but 
here I can't see any alternative meaning.

> 
> -in the code comments:
> drivers/ps3/ps3-lpm.c:94: rigths ==> rights
> drivers/ps3/ps3-sys-manager.c:365: acnowledge ==> acknowledge
> drivers/ps3/ps3-vuart.c:470: remaning ==> remaining
> drivers/ps3/ps3-vuart.c:471: transmision ==> transmission
> drivers/ps3/sys-manager-core.c:15: Staticly ==> Statically
> 
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
> ---
>   drivers/ps3/ps3-lpm.c          | 2 +-
>   drivers/ps3/ps3-sys-manager.c  | 2 +-
>   drivers/ps3/ps3-vuart.c        | 4 ++--
>   drivers/ps3/sys-manager-core.c | 2 +-
>   4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/ps3/ps3-lpm.c b/drivers/ps3/ps3-lpm.c
> index 200ad8751860..188ae2572674 100644
> --- a/drivers/ps3/ps3-lpm.c
> +++ b/drivers/ps3/ps3-lpm.c
> @@ -91,7 +91,7 @@ struct ps3_lpm_shadow_regs {
>    * struct ps3_lpm_priv - Private lpm device data.
>    *
>    * @open: An atomic variable indicating the lpm driver has been opened.
> - * @rights: The lpm rigths granted by the system policy module.  A logical
> + * @rights: The lpm rights granted by the system policy module.  A logical
>    *  OR of enum ps3_lpm_rights.
>    * @node_id: The node id of a BE processor whose performance monitor this
>    *  lpar has the right to use.
> diff --git a/drivers/ps3/ps3-sys-manager.c b/drivers/ps3/ps3-sys-manager.c
> index ad8ef59dea34..ab798b52910e 100644
> --- a/drivers/ps3/ps3-sys-manager.c
> +++ b/drivers/ps3/ps3-sys-manager.c
> @@ -362,7 +362,7 @@ static int ps3_sys_manager_send_request_shutdown(
>    * ps3_sys_manager_send_response - Send a 'response' to the system manager.
>    * @status: zero = success, others fail.
>    *
> - * The guest sends this message to the system manager to acnowledge success or
> + * The guest sends this message to the system manager to acknowledge success or
>    * failure of a command sent by the system manager.
>    */
> 
> diff --git a/drivers/ps3/ps3-vuart.c b/drivers/ps3/ps3-vuart.c
> index 6328abd51ffa..5cb92535a4a1 100644
> --- a/drivers/ps3/ps3-vuart.c
> +++ b/drivers/ps3/ps3-vuart.c
> @@ -467,8 +467,8 @@ struct list_buffer {
>    *
>    * If the port is idle on entry as much of the incoming data is written to
>    * the port as the port will accept.  Otherwise a list buffer is created
> - * and any remaning incoming data is copied to that buffer.  The buffer is
> - * then enqueued for transmision via the transmit interrupt.
> + * and any remaining incoming data is copied to that buffer.  The buffer is
> + * then enqueued for transmission via the transmit interrupt.
>    */
> 
>   int ps3_vuart_write(struct ps3_system_bus_device *dev, const void *buf,
> diff --git a/drivers/ps3/sys-manager-core.c b/drivers/ps3/sys-manager-core.c
> index e061b7d0632b..f50032ad9702 100644
> --- a/drivers/ps3/sys-manager-core.c
> +++ b/drivers/ps3/sys-manager-core.c
> @@ -12,7 +12,7 @@
>   #include <asm/ps3.h>
> 
>   /**
> - * Staticly linked routines that allow late binding of a loaded sys-manager
> + * Statically linked routines that allow late binding of a loaded sys-manager
>    * module.
>    */
> 
> --
> 2.17.1
>

Re: [PATCH v1] ps3: Correct some typos in comments

Posted by Geoff Levand 1 month, 3 weeks ago

On 9/30/24 11:32, Shen Lichuan wrote:
> Fixed some confusing typos that were currently identified with codespell,
> the details are as follows:
> 
> -in the code comments:
> drivers/ps3/ps3-lpm.c:94: rigths ==> rights
> drivers/ps3/ps3-sys-manager.c:365: acnowledge ==> acknowledge
> drivers/ps3/ps3-vuart.c:470: remaning ==> remaining
> drivers/ps3/ps3-vuart.c:471: transmision ==> transmission
> drivers/ps3/sys-manager-core.c:15: Staticly ==> Statically
> 
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>

Looks good. Thanks for your fixes.

Acked-by: Geoff Levand <geoff@infradead.org>