[PATCH 0/2] net: switch to scoped device_for_each_child_node()

Javier Carrasco posted 2 patches 1 month, 4 weeks ago
There is a newer version of this series
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 10 +++-------
drivers/net/mdio/mdio-thunder.c                   |  4 +---
2 files changed, 4 insertions(+), 10 deletions(-)
[PATCH 0/2] net: switch to scoped device_for_each_child_node()
Posted by Javier Carrasco 1 month, 4 weeks ago
This series switches from the device_for_each_child_node() macro to its
scoped variant. This makes the code more robust if new early exits are
added to the loops, because there is no need for explicit calls to
fwnode_handle_put(), which also simplifies existing code.

The non-scoped macros to walk over nodes turn error-prone as soon as
the loop contains early exits (break, goto, return), and patches to
fix them show up regularly, sometimes due to new error paths in an
existing loop [1].

Note that the child node is now declared in the macro, and therefore the
explicit declaration is no longer required.

The general functionality should not be affected by this modification.
If functional changes are found, please report them back as errors.

Link:
https://lore.kernel.org/all/20240901160829.709296395@linuxfoundation.org/
[1]

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Javier Carrasco (2):
      net: mdio: switch to scoped device_for_each_child_node()
      net: hns: switch to scoped device_for_each_child_node()

 drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 10 +++-------
 drivers/net/mdio/mdio-thunder.c                   |  4 +---
 2 files changed, 4 insertions(+), 10 deletions(-)
---
base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
change-id: 20240930-net-device_for_each_child_node_scoped-ebe62f742847

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>