[PATCH] fixup! i2c: Add driver for the RTL9300 I2C controller

Chris Packham posted 1 patch 1 month, 4 weeks ago
There is a newer version of this series
drivers/i2c/busses/i2c-rtl9300.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] fixup! i2c: Add driver for the RTL9300 I2C controller
Posted by Chris Packham 1 month, 4 weeks ago
Hi Andi,

This is a fixup for the spare complaint from the kernel test robot
https://lore.kernel.org/lkml/202409291025.P4M4O1F2-lkp@intel.com/#t

Not sure if you want to fold this into what is already in
andi-shyti/i2c/i2c-host or if you want me to send it as a new patch.
---
 drivers/i2c/busses/i2c-rtl9300.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-rtl9300.c b/drivers/i2c/busses/i2c-rtl9300.c
index ed9a45a9d803..f0bb0ede79ce 100644
--- a/drivers/i2c/busses/i2c-rtl9300.c
+++ b/drivers/i2c/busses/i2c-rtl9300.c
@@ -318,7 +318,7 @@ static const struct i2c_algorithm rtl9300_i2c_algo = {
 	.functionality	= rtl9300_i2c_func,
 };
 
-struct i2c_adapter_quirks rtl9300_i2c_quirks = {
+static struct i2c_adapter_quirks rtl9300_i2c_quirks = {
 	.flags		= I2C_AQ_NO_CLK_STRETCH,
 	.max_read_len	= 16,
 	.max_write_len	= 16,
-- 
2.46.2
Re: [PATCH] fixup! i2c: Add driver for the RTL9300 I2C controller
Posted by Andi Shyti 1 month, 3 weeks ago
Hi Chris,

On Mon, Sep 30, 2024 at 09:09:34AM GMT, Chris Packham wrote:
> Hi Andi,
> 
> This is a fixup for the spare complaint from the kernel test robot
> https://lore.kernel.org/lkml/202409291025.P4M4O1F2-lkp@intel.com/#t
> 
> Not sure if you want to fold this into what is already in
> andi-shyti/i2c/i2c-host or if you want me to send it as a new patch.

no worries, I can take care of it.

Andi

> ---
>  drivers/i2c/busses/i2c-rtl9300.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-rtl9300.c b/drivers/i2c/busses/i2c-rtl9300.c
> index ed9a45a9d803..f0bb0ede79ce 100644
> --- a/drivers/i2c/busses/i2c-rtl9300.c
> +++ b/drivers/i2c/busses/i2c-rtl9300.c
> @@ -318,7 +318,7 @@ static const struct i2c_algorithm rtl9300_i2c_algo = {
>  	.functionality	= rtl9300_i2c_func,
>  };
>  
> -struct i2c_adapter_quirks rtl9300_i2c_quirks = {
> +static struct i2c_adapter_quirks rtl9300_i2c_quirks = {
>  	.flags		= I2C_AQ_NO_CLK_STRETCH,
>  	.max_read_len	= 16,
>  	.max_write_len	= 16,
> -- 
> 2.46.2
>
Re: [PATCH] fixup! i2c: Add driver for the RTL9300 I2C controller
Posted by Chris Packham 1 month, 2 weeks ago
Hi Andi,

On 2/10/24 23:57, Andi Shyti wrote:
> Hi Chris,
>
> On Mon, Sep 30, 2024 at 09:09:34AM GMT, Chris Packham wrote:
>> Hi Andi,
>>
>> This is a fixup for the spare complaint from the kernel test robot
>> https://scanmail.trustwave.com/?c=20988&d=8Kn95gKUGD1_OL8d257ypj3kPxHsjXG_y2-BvWXRiQ&u=https%3a%2f%2flore%2ekernel%2eorg%2flkml%2f202409291025%2eP4M4O1F2-lkp%40intel%2ecom%2f%23t
>>
>> Not sure if you want to fold this into what is already in
>> andi-shyti/i2c/i2c-host or if you want me to send it as a new patch.
> no worries, I can take care of it.
>
> Andi

Just chasing up this series.  Did it land anywhere? Were you waiting for 
me to send a v6?

I think I've clarified the SoC naming with Krzysztof so he might like me 
to send a v6 dropping the wildcard rtl9300. But I didn't want to send a 
v6 if v5 was already sitting in a tree somewhere else.

>> ---
>>   drivers/i2c/busses/i2c-rtl9300.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-rtl9300.c b/drivers/i2c/busses/i2c-rtl9300.c
>> index ed9a45a9d803..f0bb0ede79ce 100644
>> --- a/drivers/i2c/busses/i2c-rtl9300.c
>> +++ b/drivers/i2c/busses/i2c-rtl9300.c
>> @@ -318,7 +318,7 @@ static const struct i2c_algorithm rtl9300_i2c_algo = {
>>   	.functionality	= rtl9300_i2c_func,
>>   };
>>   
>> -struct i2c_adapter_quirks rtl9300_i2c_quirks = {
>> +static struct i2c_adapter_quirks rtl9300_i2c_quirks = {
>>   	.flags		= I2C_AQ_NO_CLK_STRETCH,
>>   	.max_read_len	= 16,
>>   	.max_write_len	= 16,
>> -- 
>> 2.46.2
>>