[PATCH v1] bus: mhi: host: Fix typos in the comments

Yan Zhen posted 1 patch 2 months ago
drivers/bus/mhi/host/boot.c     | 4 ++--
drivers/bus/mhi/host/internal.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
[PATCH v1] bus: mhi: host: Fix typos in the comments
Posted by Yan Zhen 2 months ago
Correctly spelled comments make it easier for the reader to understand
the code.

Fix typos:
'Normaly' ==> 'Normally',
'gurantee' ==> 'guarantee',
'guranteed' ==> 'guaranteed'.

Signed-off-by: Yan Zhen <yanzhen@vivo.com>
---
 drivers/bus/mhi/host/boot.c     | 4 ++--
 drivers/bus/mhi/host/internal.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
index dedd29ca8db3..e8c92972f9df 100644
--- a/drivers/bus/mhi/host/boot.c
+++ b/drivers/bus/mhi/host/boot.c
@@ -82,9 +82,9 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
 	 * other cores to shutdown while we're collecting RDDM buffer. After
 	 * returning from this function, we expect the device to reset.
 	 *
-	 * Normaly, we read/write pm_state only after grabbing the
+	 * Normally, we read/write pm_state only after grabbing the
 	 * pm_lock, since we're in a panic, skipping it. Also there is no
-	 * gurantee that this state change would take effect since
+	 * guarantee that this state change would take effect since
 	 * we're setting it w/o grabbing pm_lock
 	 */
 	mhi_cntrl->pm_state = MHI_PM_LD_ERR_FATAL_DETECT;
diff --git a/drivers/bus/mhi/host/internal.h b/drivers/bus/mhi/host/internal.h
index d057e877932e..3134f111be35 100644
--- a/drivers/bus/mhi/host/internal.h
+++ b/drivers/bus/mhi/host/internal.h
@@ -255,7 +255,7 @@ struct mhi_chan {
 	/*
 	 * Important: When consuming, increment tre_ring first and when
 	 * releasing, decrement buf_ring first. If tre_ring has space, buf_ring
-	 * is guranteed to have space so we do not need to check both rings.
+	 * is guaranteed to have space so we do not need to check both rings.
 	 */
 	struct mhi_ring buf_ring;
 	struct mhi_ring tre_ring;
-- 
2.34.1
Re: [PATCH v1] bus: mhi: host: Fix typos in the comments
Posted by Manivannan Sadhasivam 1 month, 3 weeks ago
On Sun, Sep 29, 2024 at 05:03:34PM +0800, Yan Zhen wrote:
> Correctly spelled comments make it easier for the reader to understand
> the code.
> 
> Fix typos:
> 'Normaly' ==> 'Normally',
> 'gurantee' ==> 'guarantee',
> 'guranteed' ==> 'guaranteed'.
> 
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>

Applied to mhi-next!

- Mani

> ---
>  drivers/bus/mhi/host/boot.c     | 4 ++--
>  drivers/bus/mhi/host/internal.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
> index dedd29ca8db3..e8c92972f9df 100644
> --- a/drivers/bus/mhi/host/boot.c
> +++ b/drivers/bus/mhi/host/boot.c
> @@ -82,9 +82,9 @@ static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
>  	 * other cores to shutdown while we're collecting RDDM buffer. After
>  	 * returning from this function, we expect the device to reset.
>  	 *
> -	 * Normaly, we read/write pm_state only after grabbing the
> +	 * Normally, we read/write pm_state only after grabbing the
>  	 * pm_lock, since we're in a panic, skipping it. Also there is no
> -	 * gurantee that this state change would take effect since
> +	 * guarantee that this state change would take effect since
>  	 * we're setting it w/o grabbing pm_lock
>  	 */
>  	mhi_cntrl->pm_state = MHI_PM_LD_ERR_FATAL_DETECT;
> diff --git a/drivers/bus/mhi/host/internal.h b/drivers/bus/mhi/host/internal.h
> index d057e877932e..3134f111be35 100644
> --- a/drivers/bus/mhi/host/internal.h
> +++ b/drivers/bus/mhi/host/internal.h
> @@ -255,7 +255,7 @@ struct mhi_chan {
>  	/*
>  	 * Important: When consuming, increment tre_ring first and when
>  	 * releasing, decrement buf_ring first. If tre_ring has space, buf_ring
> -	 * is guranteed to have space so we do not need to check both rings.
> +	 * is guaranteed to have space so we do not need to check both rings.
>  	 */
>  	struct mhi_ring buf_ring;
>  	struct mhi_ring tre_ring;
> -- 
> 2.34.1
> 

-- 
மணிவண்ணன் சதாசிவம்
Re: [PATCH v1] bus: mhi: host: Fix typos in the comments
Posted by Jeffrey Hugo 1 month, 3 weeks ago
On 9/29/2024 3:03 AM, Yan Zhen wrote:
> Correctly spelled comments make it easier for the reader to understand
> the code.
> 
> Fix typos:
> 'Normaly' ==> 'Normally',
> 'gurantee' ==> 'guarantee',
> 'guranteed' ==> 'guaranteed'.
> 
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>