selftest: hid: add missing run-hid-tools-tests.sh

[PATCH] selftest: hid: add missing run-hid-tools-tests.sh

Posted by Yun Lu 2 months ago

The HID test cases actually run tests using the run-hid-tools-tests.sh
script. However, if installed with "make install", the run-hid-tools-tests.sh
script will not be copied over, resulting in the following error message.

  make -C tools/testing/selftests/ TARGETS=hid install \
  	  INSTALL_PATH=$KSFT_INSTALL_PATH

  cd $KSFT_INSTALL_PATH
  ./run_kselftest.sh -c hid

selftests: hid: hid-core.sh
bash: ./run-hid-tools-tests.sh: No such file or directory

So add the run-hid-tools-tests.sh script to the TEST_FILES in the Makefile.

Signed-off-by: Yun Lu <luyun@kylinos.cn>
---
 tools/testing/selftests/hid/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/hid/Makefile b/tools/testing/selftests/hid/Makefile
index 72be55ac4bdf..38ae31bb07b5 100644
--- a/tools/testing/selftests/hid/Makefile
+++ b/tools/testing/selftests/hid/Makefile
@@ -17,6 +17,8 @@ TEST_PROGS += hid-tablet.sh
 TEST_PROGS += hid-usb_crash.sh
 TEST_PROGS += hid-wacom.sh
 
+TEST_FILES := run-hid-tools-tests.sh
+
 CXX ?= $(CROSS_COMPILE)g++
 
 HOSTPKG_CONFIG := pkg-config
-- 
2.27.0

Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

Posted by Benjamin Tissoires 1 month, 4 weeks ago

On Sep 29 2024, Yun Lu wrote:
> The HID test cases actually run tests using the run-hid-tools-tests.sh
> script. However, if installed with "make install", the run-hid-tools-tests.sh
> script will not be copied over, resulting in the following error message.
> 
>   make -C tools/testing/selftests/ TARGETS=hid install \
>   	  INSTALL_PATH=$KSFT_INSTALL_PATH
> 
>   cd $KSFT_INSTALL_PATH
>   ./run_kselftest.sh -c hid
> 
> selftests: hid: hid-core.sh
> bash: ./run-hid-tools-tests.sh: No such file or directory
> 
> So add the run-hid-tools-tests.sh script to the TEST_FILES in the Makefile.
> 

I assume we probably also want:

Cc: stable@vger.kernel.org

> Signed-off-by: Yun Lu <luyun@kylinos.cn>

Not sure about the timing regarding our next PR to Linus, so in any cases:

Acked-by: Benjamin Tissoires <bentiss@kernel.org>

Cheers,
Benjamin

> ---
>  tools/testing/selftests/hid/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/hid/Makefile b/tools/testing/selftests/hid/Makefile
> index 72be55ac4bdf..38ae31bb07b5 100644
> --- a/tools/testing/selftests/hid/Makefile
> +++ b/tools/testing/selftests/hid/Makefile
> @@ -17,6 +17,8 @@ TEST_PROGS += hid-tablet.sh
>  TEST_PROGS += hid-usb_crash.sh
>  TEST_PROGS += hid-wacom.sh
>  
> +TEST_FILES := run-hid-tools-tests.sh
> +
>  CXX ?= $(CROSS_COMPILE)g++
>  
>  HOSTPKG_CONFIG := pkg-config
> -- 
> 2.27.0
>

Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

Posted by Shuah Khan 1 month, 4 weeks ago

On 9/30/24 02:38, Benjamin Tissoires wrote:
> On Sep 29 2024, Yun Lu wrote:
>> The HID test cases actually run tests using the run-hid-tools-tests.sh
>> script. However, if installed with "make install", the run-hid-tools-tests.sh
>> script will not be copied over, resulting in the following error message.
>>
>>    make -C tools/testing/selftests/ TARGETS=hid install \
>>    	  INSTALL_PATH=$KSFT_INSTALL_PATH
>>
>>    cd $KSFT_INSTALL_PATH
>>    ./run_kselftest.sh -c hid
>>
>> selftests: hid: hid-core.sh
>> bash: ./run-hid-tools-tests.sh: No such file or directory
>>
>> So add the run-hid-tools-tests.sh script to the TEST_FILES in the Makefile.
>>
> 
> I assume we probably also want:
> 
> Cc: stable@vger.kernel.org
> 
>> Signed-off-by: Yun Lu <luyun@kylinos.cn>
> 
> Not sure about the timing regarding our next PR to Linus, so in any cases:
> 
> Acked-by: Benjamin Tissoires <bentiss@kernel.org>

Thank you. This commit appears to be right one for Fixes tag?

Is this the right commit for Fixes tag:

Fixes: commit ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core tests")

Will apply with this tag added to linux-kselftest fixes for next rc
once I get conformation.

thanks,
-- Shuah

Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

Posted by luyun 1 month, 4 weeks ago

在 2024/10/1 04:57, Shuah Khan 写道:
> On 9/30/24 02:38, Benjamin Tissoires wrote:
>> On Sep 29 2024, Yun Lu wrote:
>>> The HID test cases actually run tests using the run-hid-tools-tests.sh
>>> script. However, if installed with "make install", the 
>>> run-hid-tools-tests.sh
>>> script will not be copied over, resulting in the following error 
>>> message.
>>>
>>>    make -C tools/testing/selftests/ TARGETS=hid install \
>>>          INSTALL_PATH=$KSFT_INSTALL_PATH
>>>
>>>    cd $KSFT_INSTALL_PATH
>>>    ./run_kselftest.sh -c hid
>>>
>>> selftests: hid: hid-core.sh
>>> bash: ./run-hid-tools-tests.sh: No such file or directory
>>>
>>> So add the run-hid-tools-tests.sh script to the TEST_FILES in the 
>>> Makefile.
>>>
>>
>> I assume we probably also want:
>>
>> Cc: stable@vger.kernel.org
>>
>>> Signed-off-by: Yun Lu <luyun@kylinos.cn>
>>
>> Not sure about the timing regarding our next PR to Linus, so in any 
>> cases:
>>
>> Acked-by: Benjamin Tissoires <bentiss@kernel.org>
>
> Thank you. This commit appears to be right one for Fixes tag?
>
> Is this the right commit for Fixes tag:
>
> Fixes: commit ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core 
> tests")

Yes,  the run-hid-tools-tests.sh script has been introduced since commit 
ffb85d5c9e80,

but not added to TEST_FILES.

>
> Will apply with this tag added to linux-kselftest fixes for next rc
> once I get conformation.

So should I need to send a v2 patch to add the Fixes and Cc tags?


Thanks and best regards.

--Yun Lu

>
> thanks,
> -- Shuah

Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh

Posted by Shuah Khan 1 month, 4 weeks ago

On 9/30/24 20:43, luyun wrote:
> 
> 在 2024/10/1 04:57, Shuah Khan 写道:
>> On 9/30/24 02:38, Benjamin Tissoires wrote:
>>> On Sep 29 2024, Yun Lu wrote:
>>>> The HID test cases actually run tests using the run-hid-tools-tests.sh
>>>> script. However, if installed with "make install", the run-hid-tools-tests.sh
>>>> script will not be copied over, resulting in the following error message.
>>>>
>>>>    make -C tools/testing/selftests/ TARGETS=hid install \
>>>>          INSTALL_PATH=$KSFT_INSTALL_PATH
>>>>
>>>>    cd $KSFT_INSTALL_PATH
>>>>    ./run_kselftest.sh -c hid
>>>>
>>>> selftests: hid: hid-core.sh
>>>> bash: ./run-hid-tools-tests.sh: No such file or directory
>>>>
>>>> So add the run-hid-tools-tests.sh script to the TEST_FILES in the Makefile.
>>>>
>>>
>>> I assume we probably also want:
>>>
>>> Cc: stable@vger.kernel.org
>>>
>>>> Signed-off-by: Yun Lu <luyun@kylinos.cn>
>>>
>>> Not sure about the timing regarding our next PR to Linus, so in any cases:
>>>
>>> Acked-by: Benjamin Tissoires <bentiss@kernel.org>
>>
>> Thank you. This commit appears to be right one for Fixes tag?
>>
>> Is this the right commit for Fixes tag:
>>
>> Fixes: commit ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core tests")
> 
> Yes,  the run-hid-tools-tests.sh script has been introduced since commit ffb85d5c9e80,
> 
> but not added to TEST_FILES.
> 
>>
>> Will apply with this tag added to linux-kselftest fixes for next rc
>> once I get conformation.
> 
> So should I need to send a v2 patch to add the Fixes and Cc tags?
> 
> 

No need to send v2 - I added the Fixes tag and applied to linux-kselftest fixes
branch for next rc.

thanks,
-- Shuah