usb: gadget: Add check devm_kasprintf() returned value

[PATCH] usb: gadget: Add check devm_kasprintf() returned value

Posted by Charles Han 2 months ago

devm_kasprintf() can return a NULL pointer on failure but this
returned value in ast_vhub_init_dev() is not checked.

Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
 drivers/usb/gadget/udc/aspeed-vhub/dev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/gadget/udc/aspeed-vhub/dev.c b/drivers/usb/gadget/udc/aspeed-vhub/dev.c
index 573109ca5b79..a09f72772e6e 100644
--- a/drivers/usb/gadget/udc/aspeed-vhub/dev.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/dev.c
@@ -548,6 +548,9 @@ int ast_vhub_init_dev(struct ast_vhub *vhub, unsigned int idx)
 	d->vhub = vhub;
 	d->index = idx;
 	d->name = devm_kasprintf(parent, GFP_KERNEL, "port%d", idx+1);
+	if (!d->name)
+		return -ENOMEM;
+
 	d->regs = vhub->regs + 0x100 + 0x10 * idx;
 
 	ast_vhub_init_ep0(vhub, &d->ep0, d);
-- 
2.31.1

Re: [PATCH] usb: gadget: Add check devm_kasprintf() returned value

Posted by Andrew Jeffery 1 month, 4 weeks ago

On Sun, 2024-09-29 at 11:14 +0800, Charles Han wrote:
> devm_kasprintf() can return a NULL pointer on failure but this
> returned value in ast_vhub_init_dev() is not checked.
> 
> Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>

You should consider Greg's bot's reply to your other patch here also:

https://lore.kernel.org/all/2024092910-mobility-waking-758f@gregkh/

Andrew