crypto: qat - remove unused adf_devmgr_get_first

[PATCH] crypto: qat - remove unused adf_devmgr_get_first

Posted by linux@treblig.org 2 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

adf_devmgr_get_first has been unused since commit
4a4b0bad0653 ("crypto: qat - fix crypto_get_instance_node function")

Remove it.

(Build tested only, I don't own the hardware)

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/crypto/intel/qat/qat_common/adf_common_drv.h |  1 -
 drivers/crypto/intel/qat/qat_common/adf_dev_mgr.c    | 10 ----------
 2 files changed, 11 deletions(-)

diff --git a/drivers/crypto/intel/qat/qat_common/adf_common_drv.h b/drivers/crypto/intel/qat/qat_common/adf_common_drv.h
index f7ecabdf7805..eaa6388a6678 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_common_drv.h
+++ b/drivers/crypto/intel/qat/qat_common/adf_common_drv.h
@@ -69,7 +69,6 @@ void adf_devmgr_rm_dev(struct adf_accel_dev *accel_dev,
 		       struct adf_accel_dev *pf);
 struct list_head *adf_devmgr_get_head(void);
 struct adf_accel_dev *adf_devmgr_get_dev_by_id(u32 id);
-struct adf_accel_dev *adf_devmgr_get_first(void);
 struct adf_accel_dev *adf_devmgr_pci_to_accel_dev(struct pci_dev *pci_dev);
 int adf_devmgr_verify_id(u32 id);
 void adf_devmgr_get_num_dev(u32 *num);
diff --git a/drivers/crypto/intel/qat/qat_common/adf_dev_mgr.c b/drivers/crypto/intel/qat/qat_common/adf_dev_mgr.c
index 96ddd1c419c4..34b9f7731c78 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_dev_mgr.c
+++ b/drivers/crypto/intel/qat/qat_common/adf_dev_mgr.c
@@ -276,16 +276,6 @@ void adf_devmgr_rm_dev(struct adf_accel_dev *accel_dev,
 }
 EXPORT_SYMBOL_GPL(adf_devmgr_rm_dev);
 
-struct adf_accel_dev *adf_devmgr_get_first(void)
-{
-	struct adf_accel_dev *dev = NULL;
-
-	if (!list_empty(&accel_table))
-		dev = list_first_entry(&accel_table, struct adf_accel_dev,
-				       list);
-	return dev;
-}
-
 /**
  * adf_devmgr_pci_to_accel_dev() - Get accel_dev associated with the pci_dev.
  * @pci_dev:  Pointer to PCI device.
-- 
2.46.2

Re: [PATCH] crypto: qat - remove unused adf_devmgr_get_first

Posted by Herbert Xu 1 month, 3 weeks ago

On Sun, Sep 29, 2024 at 02:24:41AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> adf_devmgr_get_first has been unused since commit
> 4a4b0bad0653 ("crypto: qat - fix crypto_get_instance_node function")
> 
> Remove it.
> 
> (Build tested only, I don't own the hardware)
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/crypto/intel/qat/qat_common/adf_common_drv.h |  1 -
>  drivers/crypto/intel/qat/qat_common/adf_dev_mgr.c    | 10 ----------
>  2 files changed, 11 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: qat - remove unused adf_devmgr_get_first

Posted by Cabiddu, Giovanni 1 month, 4 weeks ago

On Sun, Sep 29, 2024 at 02:24:41AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> adf_devmgr_get_first has been unused since commit
> 4a4b0bad0653 ("crypto: qat - fix crypto_get_instance_node function")
> 
> Remove it.
> 
> (Build tested only, I don't own the hardware)
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>