The new test case which checks non unique symbol kprobe_non_uniq_symbol.tc 
failed because of missing kernel functionality support from commit 
b022f0c7e404 ("tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols"). 
Backport it and its fix commit to 5.4.y together. Resolved minor context change conflicts.

Andrii Nakryiko (1):
  tracing/kprobes: Fix symbol counting logic by looking at modules as
    well

Francis Laniel (1):
  tracing/kprobes: Return EADDRNOTAVAIL when func matches several
    symbols

 kernel/trace/trace_kprobe.c | 76 +++++++++++++++++++++++++++++++++++++
 kernel/trace/trace_probe.h  |  1 +
 2 files changed, 77 insertions(+)

-- 
2.46.0

On Fri, Sep 27, 2024 at 02:43:57PM -0700, Sherry Yang wrote:
> The new test case which checks non unique symbol kprobe_non_uniq_symbol.tc 
> failed because of missing kernel functionality support from commit 
> b022f0c7e404 ("tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols"). 
> Backport it and its fix commit to 5.4.y together. Resolved minor context change conflicts.
> 
> Andrii Nakryiko (1):
>   tracing/kprobes: Fix symbol counting logic by looking at modules as
>     well
> 
> Francis Laniel (1):
>   tracing/kprobes: Return EADDRNOTAVAIL when func matches several
>     symbols

As per the documentation, we can't take patches for older kernels and
not newer ones, otherwise you will have regressions when you finally
move off this old kernel to a modern one :)

Please resend ALL of the needed backports, not just one specific kernel.
I'm dropping these from my review queue now.

thanks,

greg k-h

Hi Greg,

> On Oct 1, 2024, at 1:11 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Fri, Sep 27, 2024 at 02:43:57PM -0700, Sherry Yang wrote:
>> The new test case which checks non unique symbol kprobe_non_uniq_symbol.tc 
>> failed because of missing kernel functionality support from commit 
>> b022f0c7e404 ("tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols"). 
>> Backport it and its fix commit to 5.4.y together. Resolved minor context change conflicts.
>> 
>> Andrii Nakryiko (1):
>>  tracing/kprobes: Fix symbol counting logic by looking at modules as
>>    well
>> 
>> Francis Laniel (1):
>>  tracing/kprobes: Return EADDRNOTAVAIL when func matches several
>>    symbols
> 
> As per the documentation, we can't take patches for older kernels and
> not newer ones, otherwise you will have regressions when you finally
> move off this old kernel to a modern one :)
> 
> Please resend ALL of the needed backports, not just one specific kernel.
> I'm dropping these from my review queue now.

I have sent the backports to 5.10.y, and Sasha queued them up. Can we get this series in your 5.4.y review queue again?

Sherry

On Fri, Oct 11, 2024 at 04:55:15PM +0000, Sherry Yang wrote:
> Hi Greg,
> 
> > On Oct 1, 2024, at 1:11 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > 
> > On Fri, Sep 27, 2024 at 02:43:57PM -0700, Sherry Yang wrote:
> >> The new test case which checks non unique symbol kprobe_non_uniq_symbol.tc 
> >> failed because of missing kernel functionality support from commit 
> >> b022f0c7e404 ("tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols"). 
> >> Backport it and its fix commit to 5.4.y together. Resolved minor context change conflicts.
> >> 
> >> Andrii Nakryiko (1):
> >>  tracing/kprobes: Fix symbol counting logic by looking at modules as
> >>    well
> >> 
> >> Francis Laniel (1):
> >>  tracing/kprobes: Return EADDRNOTAVAIL when func matches several
> >>    symbols
> > 
> > As per the documentation, we can't take patches for older kernels and
> > not newer ones, otherwise you will have regressions when you finally
> > move off this old kernel to a modern one :)
> > 
> > Please resend ALL of the needed backports, not just one specific kernel.
> > I'm dropping these from my review queue now.
> 
> I have sent the backports to 5.10.y, and Sasha queued them up. Can we get this series in your 5.4.y review queue again?

Please resend them as they are long gone from my queue.

thanks,

greg k-h