ksmbd: Use struct_size() to improve get_file_alternate_info()

[PATCH] ksmbd: Use struct_size() to improve get_file_alternate_info()

Thorsten Blum posted 1 patch 2 months ago

Download mbox

fs/smb/server/smb2pdu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] ksmbd: Use struct_size() to improve get_file_alternate_info()

Posted by Thorsten Blum 2 months ago

Use struct_size() to calculate the output buffer length.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 fs/smb/server/smb2pdu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index 7121266daa02..b45e5b9ad967 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -4887,7 +4887,7 @@ static void get_file_alternate_info(struct ksmbd_work *work,
 	spin_unlock(&dentry->d_lock);
 	file_info->FileNameLength = cpu_to_le32(conv_len);
 	rsp->OutputBufferLength =
-		cpu_to_le32(sizeof(struct smb2_file_alt_name_info) + conv_len);
+		cpu_to_le32(struct_size(file_info, FileName, conv_len));
 }
 
 static int get_file_stream_info(struct ksmbd_work *work,
-- 
2.46.1

Re: [PATCH] ksmbd: Use struct_size() to improve get_file_alternate_info()

Posted by Namjae Jeon 2 months ago

On Fri, Sep 27, 2024 at 11:37 PM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Use struct_size() to calculate the output buffer length.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Applied it to #ksmbd-for-next-next.
Thanks.