[PATCH v2] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example

Rob Herring (Arm) posted 1 patch 2 months ago
.../devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml   | 1 -
1 file changed, 1 deletion(-)
[PATCH v2] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example
Posted by Rob Herring (Arm) 2 months ago
Enabling dtc interrupt_provider check reveals the example is missing
the "interrupt-controller" property as it is a dependency of
"#interrupt-cells". However, the PMIC parent node is not an interrupt
controller at all, so the "#interrupt-cells" is erroneous.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
v2:
 - Drop "#interrupt-cells" rather than add "interrupt-controller"
---
 .../devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml   | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
index 277c47e048b6..a0f9d49ff8fb 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
@@ -60,7 +60,6 @@ examples:
     pmic {
       #address-cells = <1>;
       #size-cells = <0>;
-      #interrupt-cells = <4>;
 
       charger@1000 {
         compatible = "qcom,pmi8998-charger";
-- 
2.45.2
Re: [PATCH v2] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example
Posted by Sebastian Reichel 1 month, 1 week ago
On Thu, 26 Sep 2024 16:37:26 -0500, Rob Herring (Arm) wrote:
> Enabling dtc interrupt_provider check reveals the example is missing
> the "interrupt-controller" property as it is a dependency of
> "#interrupt-cells". However, the PMIC parent node is not an interrupt
> controller at all, so the "#interrupt-cells" is erroneous.
> 
> 

Applied, thanks!

[1/1] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example
      commit: 5d121065a6993e5ab4ccc0c9629241f256d11ad0

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>
Re: [PATCH v2] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example
Posted by Krzysztof Kozlowski 2 months ago
On Thu, Sep 26, 2024 at 04:37:26PM -0500, Rob Herring (Arm) wrote:
> Enabling dtc interrupt_provider check reveals the example is missing
> the "interrupt-controller" property as it is a dependency of
> "#interrupt-cells". However, the PMIC parent node is not an interrupt
> controller at all, so the "#interrupt-cells" is erroneous.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> v2:
>  - Drop "#interrupt-cells" rather than add "interrupt-controller"

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof