[PATCH v7 0/6] ti: k3-am62{a,p}x-sk: add opp frequencies

Dhruva Gole posted 6 patches 2 months ago
arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi         | 10 +++--
arch/arm64/boot/dts/ti/k3-am625.dtsi               |  2 +-
arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi        |  5 +++
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts            |  9 ++++
arch/arm64/boot/dts/ti/k3-am62a7.dtsi              | 51 ++++++++++++++++++++++
.../boot/dts/ti/k3-am62p-j722s-common-wakeup.dtsi  |  5 +++
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts            |  9 ++++
arch/arm64/boot/dts/ti/k3-am62p5.dtsi              | 47 ++++++++++++++++++++
drivers/cpufreq/ti-cpufreq.c                       | 24 +++++++---
9 files changed, 152 insertions(+), 10 deletions(-)
[PATCH v7 0/6] ti: k3-am62{a,p}x-sk: add opp frequencies
Posted by Dhruva Gole 2 months ago
Hello everyone

This series adds in the OPPs for the Cortex-A53s on the AM62Ax and
AM62Px SoC families along with the defining the
WKUP_MMR0_WKUP0_CTRL_MMR0_JTAG_USER_ID which we can use to properly
limit the OPPs available for that variant.

Moreover, it also adds a driver cleanup where we can finally get rid of
the rev_offsets and zero the efuse_offsets as they are now taken from socinfo and
DT efuse node register respectively. This series has been tested on all
devices that it affects and has been confirmed to cause no known regressions.

It also tries to fix the AM625 devicetree syscon nodes, while also ensuring that
within the driver we don't end up breaking the older DT. Prints a warning incase
older DT is detected.

Test logs:
https://gist.github.com/DhruvaG2000/63f5e28636d52787488f776e5bf39498

Changelog:

---
Changes in v7:
- Based on Andrew's comments, re-worded the comment in the driver and also
  used a different approach for finding old DT, this way it's less error prone
  than how things were done in v6.
- Added a warning print when using old DT:
https://gist.github.com/DhruvaG2000/63f5e28636d52787488f776e5bf39498#file-am62x-cpufreq-test-log-old-dt-txt-L220
- Link to v6: https://lore.kernel.org/r/20240925-ti-cpufreq-fixes-v5-v6-0-46f41a903e01@ti.com

Changes in v6:
- Ensure backward compaibility for AM625 DT, by handling the old DT in a special
way inside the cpufreq driver itself. This is based on feedback from Nishanth
where we are not okay to break the old DT working with new kernels.
- Link to v5: https://lore.kernel.org/r/20240924-ti-cpufreq-fixes-v5-v5-0-cbe16b9ddb1b@ti.com

Changes in v5:
- Based on Andrew's review on v4 of "arm64: dts: ti: k3-am62: use opp_efuse_table for opp-table syscon",
	- s/syscon@43000000/bus@43000000/
	- Drop the "reg = <>;" line
- Link to v4: https://lore.kernel.org/all/20240919082809.174589-1-d-gole@ti.com/

Changes in v4:
- Add 2 more patches to this series:
	- Driver cleanup as described above.
	- AM625 DT fixups (Link to v1 of that patch: https://lore.kernel.org/all/20240902093222.2828345-2-d-gole@ti.com/)
- Link to v3: https://lore.kernel.org/all/20240826-opp-v3-0-0934f8309e13@ti.com/

Changes in v3:
- Miscellaneous spelling fixes in commit body
- Link to v2: https://lore.kernel.org/r/20240823-opp-v2-0-e2f67b37c299@ti.com

Changes in v2:
- Expanded on commit descriptions
- Split board file and SoC fdt changes into different patches
- Link to v1: https://lore.kernel.org/r/20240809-opp-v1-0-fea8efeaf963@ti.com

---

Bryan Brattlof (4):
  arm64: dts: ti: k3-am62a: add opp frequencies
  arm64: dts: ti: k3-am62a7-sk: add 1.4ghz opp entry
  arm64: dts: ti: k3-am62p: add opp frequencies
  arm64: dts: ti: k3-am62p5-sk: add 1.4ghz opp entry

Dhruva Gole (2):
  arm64: dts: ti: k3-am62: use opp_efuse_table for opp-table syscon
  cpufreq: ti-cpufreq: Update efuse/rev offsets in AM62 family

 arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi    |  7 ++-
 arch/arm64/boot/dts/ti/k3-am625.dtsi          |  2 +-
 arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi   |  5 ++
 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts       |  9 ++++
 arch/arm64/boot/dts/ti/k3-am62a7.dtsi         | 51 +++++++++++++++++++
 .../dts/ti/k3-am62p-j722s-common-wakeup.dtsi  |  5 ++
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts       |  9 ++++
 arch/arm64/boot/dts/ti/k3-am62p5.dtsi         | 47 +++++++++++++++++
 drivers/cpufreq/ti-cpufreq.c                  |  5 +-
 9 files changed, 134 insertions(+), 6 deletions(-)

base-commit: 55bcd2e0d04c1171d382badef1def1fd04ef66c5
--
2.34.1

---
Bryan Brattlof (4):
      arm64: dts: ti: k3-am62a: add opp frequencies
      arm64: dts: ti: k3-am62a7-sk: add 1.4ghz opp entry
      arm64: dts: ti: k3-am62p: add opp frequencies
      arm64: dts: ti: k3-am62p5-sk: add 1.4ghz opp entry

Dhruva Gole (2):
      arm64: dts: ti: k3-am62: use opp_efuse_table for opp-table syscon
      cpufreq: ti-cpufreq: Update efuse/rev offsets in AM62 family

 arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi         | 10 +++--
 arch/arm64/boot/dts/ti/k3-am625.dtsi               |  2 +-
 arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi        |  5 +++
 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts            |  9 ++++
 arch/arm64/boot/dts/ti/k3-am62a7.dtsi              | 51 ++++++++++++++++++++++
 .../boot/dts/ti/k3-am62p-j722s-common-wakeup.dtsi  |  5 +++
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts            |  9 ++++
 arch/arm64/boot/dts/ti/k3-am62p5.dtsi              | 47 ++++++++++++++++++++
 drivers/cpufreq/ti-cpufreq.c                       | 24 +++++++---
 9 files changed, 152 insertions(+), 10 deletions(-)
---
base-commit: 55bcd2e0d04c1171d382badef1def1fd04ef66c5
change-id: 20240924-ti-cpufreq-fixes-v5-dbb3e5056b6c

Best regards,
-- 
Dhruva Gole <d-gole@ti.com>
Re: [PATCH v7 0/6] ti: k3-am62{a,p}x-sk: add opp frequencies
Posted by Nishanth Menon 2 months ago
On 14:04-20240926, Dhruva Gole wrote:
[...]

> Bryan Brattlof (4):
>   arm64: dts: ti: k3-am62a: add opp frequencies
>   arm64: dts: ti: k3-am62a7-sk: add 1.4ghz opp entry
>   arm64: dts: ti: k3-am62p: add opp frequencies
>   arm64: dts: ti: k3-am62p5-sk: add 1.4ghz opp entry
> 
> Dhruva Gole (2):
>   arm64: dts: ti: k3-am62: use opp_efuse_table for opp-table syscon
>   cpufreq: ti-cpufreq: Update efuse/rev offsets in AM62 family

Please drop the dt patches from the series - they are completely
un-related. just fix the driver for compatibility and we can attack the
am625 cpufreq support fixup separately. AM62a/62p etc are independent of
this completely - those need to go to the DT maintainer separately

am625: Just post the driver fixups for backward compatibility and get it
merged prior to dt fixup.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
Re: [PATCH v7 0/6] ti: k3-am62{a,p}x-sk: add opp frequencies
Posted by Dhruva Gole 1 month, 4 weeks ago
On Sep 27, 2024 at 08:40:03 -0500, Nishanth Menon wrote:
> On 14:04-20240926, Dhruva Gole wrote:
> [...]
> 
> > Bryan Brattlof (4):
> >   arm64: dts: ti: k3-am62a: add opp frequencies
> >   arm64: dts: ti: k3-am62a7-sk: add 1.4ghz opp entry
> >   arm64: dts: ti: k3-am62p: add opp frequencies
> >   arm64: dts: ti: k3-am62p5-sk: add 1.4ghz opp entry
> > 
> > Dhruva Gole (2):
> >   arm64: dts: ti: k3-am62: use opp_efuse_table for opp-table syscon
> >   cpufreq: ti-cpufreq: Update efuse/rev offsets in AM62 family
> 
> Please drop the dt patches from the series - they are completely
> un-related. just fix the driver for compatibility and we can attack the
> am625 cpufreq support fixup separately. AM62a/62p etc are independent of
> this completely - those need to go to the DT maintainer separately

OK, will drop them out and post them later on to the TI maintainers.

> 
> am625: Just post the driver fixups for backward compatibility and get it
> merged prior to dt fixup.
> 

Got it, I'll incorporate your suggestion on the driver patch and post it
independently. Then post the DT fixups later.

Thanks for all the inputs!

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated