dt-bindings: usb: cypress,cypd4226: Drop Tegra specific GPIO defines

[PATCH] dt-bindings: usb: cypress,cypd4226: Drop Tegra specific GPIO defines

Posted by Rob Herring (Arm) 1 year, 4 months ago

The Tegra GPIO define is a problem for the magic code which extracts
the examples and fixes up the interrupt provider. This was partially
worked around by putting #interrupt-cells in the parent. However,
that's incomplete and causes a warning when dtc "interrupt_provider"
check is enabled. Just drop the Tegra specific define and simplify
the example.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
index 89fc9a434d05..0620d82508c1 100644
--- a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
+++ b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
@@ -61,18 +61,15 @@ additionalProperties: false
 
 examples:
   - |
-    #include <dt-bindings/gpio/tegra194-gpio.h>
     #include <dt-bindings/interrupt-controller/arm-gic.h>
     i2c {
       #address-cells = <1>;
       #size-cells = <0>;
-      #interrupt-cells = <2>;
 
       typec@8 {
         compatible = "cypress,cypd4226";
         reg = <0x08>;
-        interrupt-parent = <&gpio_aon>;
-        interrupts = <TEGRA194_AON_GPIO(BB, 2) IRQ_TYPE_LEVEL_LOW>;
+        interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
         firmware-name = "nvidia,jetson-agx-xavier";
         #address-cells = <1>;
         #size-cells = <0>;
-- 
2.45.2

Re: [PATCH] dt-bindings: usb: cypress,cypd4226: Drop Tegra specific GPIO defines

Posted by Conor Dooley 1 year, 4 months ago

On Wed, Sep 25, 2024 at 12:34:48PM -0500, Rob Herring (Arm) wrote:
> The Tegra GPIO define is a problem for the magic code which extracts
> the examples and fixes up the interrupt provider. This was partially
> worked around by putting #interrupt-cells in the parent. However,
> that's incomplete and causes a warning when dtc "interrupt_provider"
> check is enabled. Just drop the Tegra specific define and simplify
> the example.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---

Right, there's no need to have a tegra specific thing here at all, its
just an example..
Acked-by: Conor Dooley <conor.dooley@microchip.com>


>  Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> index 89fc9a434d05..0620d82508c1 100644
> --- a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> +++ b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> @@ -61,18 +61,15 @@ additionalProperties: false
>  
>  examples:
>    - |
> -    #include <dt-bindings/gpio/tegra194-gpio.h>
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
>      i2c {
>        #address-cells = <1>;
>        #size-cells = <0>;
> -      #interrupt-cells = <2>;
>  
>        typec@8 {
>          compatible = "cypress,cypd4226";
>          reg = <0x08>;
> -        interrupt-parent = <&gpio_aon>;
> -        interrupts = <TEGRA194_AON_GPIO(BB, 2) IRQ_TYPE_LEVEL_LOW>;
> +        interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
>          firmware-name = "nvidia,jetson-agx-xavier";
>          #address-cells = <1>;
>          #size-cells = <0>;
> -- 
> 2.45.2
>