dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property

[PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property

Posted by Rob Herring (Arm) 2 months ago

The Freescale MU-MSI is an MSI provider, not an interrupt provider, so
drop the "interrupt-controller" property. This fixes dtc "interrupt_provider"
warning.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
If this is not correct, then #interrupt-cells needs to be added.
---
 .../devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml  | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
index 799ae5c3e32a..b5282c857f44 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
@@ -62,8 +62,6 @@ properties:
       - const: processor-a-side
       - const: processor-b-side
 
-  interrupt-controller: true
-
   msi-controller: true
 
   "#msi-cells":
@@ -73,7 +71,6 @@ required:
   - compatible
   - reg
   - interrupts
-  - interrupt-controller
   - msi-controller
   - "#msi-cells"
 
@@ -88,7 +85,6 @@ examples:
         compatible = "fsl,imx6sx-mu-msi";
         msi-controller;
         #msi-cells = <0>;
-        interrupt-controller;
         reg = <0x5d270000 0x10000>,     /* A side */
               <0x5d300000 0x10000>;     /* B side */
         reg-names = "processor-a-side", "processor-b-side";
-- 
2.45.2

Re: [PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property

Posted by Conor Dooley 2 months ago

On Wed, Sep 25, 2024 at 12:34:38PM -0500, Rob Herring (Arm) wrote:
> The Freescale MU-MSI is an MSI provider, not an interrupt provider, so
> drop the "interrupt-controller" property. This fixes dtc "interrupt_provider"
> warning.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> If this is not correct, then #interrupt-cells needs to be added.

Seems it is correct, per Frank.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Re: [PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property

Posted by Frank Li 2 months ago

On Wed, Sep 25, 2024 at 12:34:38PM -0500, Rob Herring (Arm) wrote:
> The Freescale MU-MSI is an MSI provider, not an interrupt provider, so
> drop the "interrupt-controller" property. This fixes dtc "interrupt_provider"
> warning.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
> If this is not correct, then #interrupt-cells needs to be added.
> ---
>  .../devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml  | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
> index 799ae5c3e32a..b5282c857f44 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
> @@ -62,8 +62,6 @@ properties:
>        - const: processor-a-side
>        - const: processor-b-side
>
> -  interrupt-controller: true
> -
>    msi-controller: true
>
>    "#msi-cells":
> @@ -73,7 +71,6 @@ required:
>    - compatible
>    - reg
>    - interrupts
> -  - interrupt-controller
>    - msi-controller
>    - "#msi-cells"
>
> @@ -88,7 +85,6 @@ examples:
>          compatible = "fsl,imx6sx-mu-msi";
>          msi-controller;
>          #msi-cells = <0>;
> -        interrupt-controller;
>          reg = <0x5d270000 0x10000>,     /* A side */
>                <0x5d300000 0x10000>;     /* B side */
>          reg-names = "processor-a-side", "processor-b-side";
> --
> 2.45.2
>