[PATCH v6 0/2] Minor fixes error handling of perf stat

Levi Yun posted 2 patches 2 months ago
tools/perf/builtin-stat.c | 11 ++++++++++-
tools/perf/util/evlist.c  | 14 +++++++++++++-
tools/perf/util/evlist.h  |  1 +
3 files changed, 24 insertions(+), 2 deletions(-)
[PATCH v6 0/2] Minor fixes error handling of perf stat
Posted by Levi Yun 2 months ago
This patchset fixes two issues that were seen when running
  "perf stat -r" with perf_event_paranoid=3

   1. failed with Too many open files.
     $ perf stat -r 1044 -- false
     ...
     failed to create 'go' pipe: Too many open files
     failed to prepare workload: Too many open files
     ...

   2. repating error message
     $ perf stat -r 1044 -- false
     Error:
     Access to performance monitoring and observability operations is limited.
     ...
     (repating with same error message 1044 times).
v6:
  - check cork_fd with >= 0

v5:
  - add error handling label.

v4:
  - Move comments to run_perf_stat().

v3:
  - Fix comments.

v2:
  - Add some comments.

Levi Yun (2):
  perf stat: Close cork_fd when create_perf_stat_counter() failed
  perf stat: Stop repeating when ref_perf_stat() returns -1

 tools/perf/builtin-stat.c | 11 ++++++++++-
 tools/perf/util/evlist.c  | 14 +++++++++++++-
 tools/perf/util/evlist.h  |  1 +
 3 files changed, 24 insertions(+), 2 deletions(-)

--
LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}
Re: [PATCH v6 0/2] Minor fixes error handling of perf stat
Posted by Namhyung Kim 2 months ago
On Wed, 25 Sep 2024 14:20:20 +0100, Levi Yun wrote:

> This patchset fixes two issues that were seen when running
>   "perf stat -r" with perf_event_paranoid=3
> 
>    1. failed with Too many open files.
>      $ perf stat -r 1044 -- false
>      ...
>      failed to create 'go' pipe: Too many open files
>      failed to prepare workload: Too many open files
>      ...
> 
> [...]

Applied to perf-tools-next, thanks!

Best regards,
Namhyung