[PATCH v1] atm: Fix typo in the comment

Yan Zhen posted 1 patch 2 months ago
drivers/atm/fore200e.c |  2 +-
drivers/atm/fore200e.h |  4 ++--
drivers/atm/he.h       |  2 +-
drivers/atm/idt77252.h |  4 ++--
drivers/atm/iphase.c   |  4 ++--
drivers/atm/iphase.h   |  4 ++--
drivers/atm/lanai.c    | 10 +++++-----
drivers/atm/nicstar.h  |  2 +-
8 files changed, 16 insertions(+), 16 deletions(-)
[PATCH v1] atm: Fix typo in the comment
Posted by Yan Zhen 2 months ago
Correctly spelled comments make it easier for the reader to understand
the code.

Fix typos:
'behing' ==> 'being',
'useable' ==> 'usable',
'arry' ==> 'array',
'receieve' ==> 'receive',
'desriptor' ==> 'descriptor',
'varients' ==> 'variants',
'recevie' ==> 'receive',
'Decriptor' ==> 'Descriptor',
'Lable' ==> 'Label',
'transmiting' ==> 'transmitting',
'correspondance' ==> 'correspondence',
'claculation' ==> 'calculation',
'everone' ==> 'everyone',
'contruct' ==> 'construct'.


Signed-off-by: Yan Zhen <yanzhen@vivo.com>
---
 drivers/atm/fore200e.c |  2 +-
 drivers/atm/fore200e.h |  4 ++--
 drivers/atm/he.h       |  2 +-
 drivers/atm/idt77252.h |  4 ++--
 drivers/atm/iphase.c   |  4 ++--
 drivers/atm/iphase.h   |  4 ++--
 drivers/atm/lanai.c    | 10 +++++-----
 drivers/atm/nicstar.h  |  2 +-
 8 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
index cb00f8244e41..fa60a68cbf49 100644
--- a/drivers/atm/fore200e.c
+++ b/drivers/atm/fore200e.c
@@ -152,7 +152,7 @@ fore200e_irq_itoa(int irq)
 }
 
 
-/* allocate and align a chunk of memory intended to hold the data behing exchanged
+/* allocate and align a chunk of memory intended to hold the data being exchanged
    between the driver and the adapter (using streaming DVMA) */
 
 static int
diff --git a/drivers/atm/fore200e.h b/drivers/atm/fore200e.h
index 5d95fe9fd836..8be31fe38ff7 100644
--- a/drivers/atm/fore200e.h
+++ b/drivers/atm/fore200e.h
@@ -570,7 +570,7 @@ typedef struct chunk {
     u32   align_size;    /* length of aligned chunk         */
 } chunk_t;
 
-#define dma_size align_size             /* DMA useable size */
+#define dma_size align_size             /* DMA usable size */
 
 
 /* host resident receive buffer */
@@ -612,7 +612,7 @@ typedef struct host_txq {
     int                   head;                           /* head of tx queue                       */
     int                   tail;                           /* tail of tx queue                       */
     struct chunk          tpd;                            /* array of tpds                          */
-    struct chunk          status;                         /* arry of completion status              */
+    struct chunk          status;                         /* array of completion status             */
     int                   txing;                          /* number of pending PDUs in tx queue     */
 } host_txq_t;
 
diff --git a/drivers/atm/he.h b/drivers/atm/he.h
index f3f53674ef3f..ee6bd0704b38 100644
--- a/drivers/atm/he.h
+++ b/drivers/atm/he.h
@@ -788,7 +788,7 @@ struct he_vcc
 #define TSR14_DELETE		(1<<31)
 #define TSR14_ABR_CLOSE		(1<<16)
 
-/* 2.7.1 per connection receieve state registers */
+/* 2.7.1 per connection receive state registers */
 
 #define RSR0_START_PDU	(1<<10)
 #define RSR0_OPEN_CONN	(1<<6)
diff --git a/drivers/atm/idt77252.h b/drivers/atm/idt77252.h
index b059d31364dd..2b42561b6fbc 100644
--- a/drivers/atm/idt77252.h
+++ b/drivers/atm/idt77252.h
@@ -349,8 +349,8 @@ struct idt77252_dev
         struct tsq_info		tsq;		/* Transmit Status Queue */
         struct rsq_info		rsq;		/* Receive Status Queue */
 
-	struct pci_dev		*pcidev;	/* PCI handle (desriptor) */
-	struct atm_dev		*atmdev;	/* ATM device desriptor */
+	struct pci_dev		*pcidev;	/* PCI handle (descriptor) */
+	struct atm_dev		*atmdev;	/* ATM device descriptor */
 
 	void __iomem		*membase;	/* SAR's memory base address */
 	unsigned long		srambase;	/* SAR's sram  base address */
diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index d213adcefe33..198a75a012d4 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -18,7 +18,7 @@
       
       Modified from an incomplete driver for Interphase 5575 1KVC 1M card which 
       was originally written by Monalisa Agrawal at UNH. Now this driver 
-      supports a variety of varients of Interphase ATM PCI (i)Chip adapter 
+      supports a variety of variants of Interphase ATM PCI (i)Chip adapter
       card family (See www.iphase.com/products/ClassSheet.cfm?ClassID=ATM) 
       in terms of PHY type, the size of control memory and the size of 
       packet memory. The following are the change log and history:
@@ -1284,7 +1284,7 @@ static void rx_dle_intr(struct atm_dev *dev)
  
   /* free all the dles done, that is just update our own dle read pointer   
 	- do we really need to do this. Think not. */  
-  /* DMA is done, just get all the recevie buffers from the rx dma queue 
+  /* DMA is done, just get all the receive buffers from the rx dma queue
 	and push them up to the higher layer protocol. Also free the desc  
 	associated with the buffer. */  
   dle = iadev->rx_dle_q.read;  
diff --git a/drivers/atm/iphase.h b/drivers/atm/iphase.h
index 2f5f8875cbd1..aec5d27ed2e6 100644
--- a/drivers/atm/iphase.h
+++ b/drivers/atm/iphase.h
@@ -568,7 +568,7 @@ struct rx_buf_desc {
 /* These memory maps are actually offsets from the segmentation and reassembly  RAM base addresses */  
   
 /* Segmentation Control Memory map */  
-#define TX_DESC_BASE	0x0000	/* Buffer Decriptor Table */ 
+#define TX_DESC_BASE	0x0000	/* Buffer Descriptor Table */
 #define TX_COMP_Q	0x1000	/* Transmit Complete Queue */  
 #define PKT_RDY_Q	0x1400	/* Packet Ready Queue */  
 #define CBR_SCHED_TABLE	0x1800	/* CBR Table */  
@@ -934,7 +934,7 @@ enum ia_suni {
 	SUNI_TPOP_ARB_PRTL	= 0x114, /* TPOP Arbitrary Pointer LSB       */
 	SUNI_TPOP_ARB_PRTM	= 0x118, /* TPOP Arbitrary Pointer MSB       */
 	SUNI_TPOP_RESERVED2	= 0x11c, /* TPOP Reserved                    */
-	SUNI_TPOP_PATH_SIG	= 0x120, /* TPOP Path Signal Lable           */
+	SUNI_TPOP_PATH_SIG	= 0x120, /* TPOP Path Signal Label           */
 	SUNI_TPOP_PATH_STATUS	= 0x124, /* TPOP Path Status                 */
 					 /* Reserved (6)                     */
 	SUNI_RACP_CS		= 0x140, /* RACP Control/Status              */
diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c
index 32d7aa141d96..1aa6161437b1 100644
--- a/drivers/atm/lanai.c
+++ b/drivers/atm/lanai.c
@@ -135,7 +135,7 @@
 /* TODO: make above a module load-time option */
 
 /*
- * When allocating an AAL0 transmiting buffer, how many cells should fit.
+ * When allocating an AAL0 transmitting buffer, how many cells should fit.
  * Remember we'll end up with a PAGE_SIZE of them anyway, so this isn't
  * really critical
  */
@@ -217,7 +217,7 @@ struct lanai_dev;			/* Forward declaration */
 
 /*
  * This is the card-specific per-vcc data.  Note that unlike some other
- * drivers there is NOT a 1-to-1 correspondance between these and
+ * drivers there is NOT a 1-to-1 correspondence between these and
  * atm_vcc's - each one of these represents an actual 2-way vcc, but
  * an atm_vcc can be 1-way and share with a 1-way vcc in the other
  * direction.  To make it weirder, there can even be 0-way vccs
@@ -603,7 +603,7 @@ enum lanai_vcc_offset {
 #define     RXMODE_AAL5		  (2)		/*   AAL5, intr. each PDU */
 #define     RXMODE_AAL5_STREAM	  (3)		/*   AAL5 w/o per-PDU intr */
 	vcc_rxaddr2		= 0x04,	/* Location2 */
-	vcc_rxcrc1		= 0x08,	/* RX CRC claculation space */
+	vcc_rxcrc1		= 0x08,	/* RX CRC calculation space */
 	vcc_rxcrc2		= 0x0C,
 	vcc_rxwriteptr		= 0x10, /* RX writeptr, plus bits: */
 #define   RXWRITEPTR_LASTEFCI	 (0x00002000)	/* Last PDU had EFCI bit */
@@ -618,7 +618,7 @@ enum lanai_vcc_offset {
 #define   TXADDR1_SET_SIZE(x) ((x)*0x0000100)	/* size of TX buffer */
 #define   TXADDR1_ABR		 (0x00008000)	/* use ABR (doesn't work) */
 	vcc_txaddr2		= 0x24,	/* Location2 */
-	vcc_txcrc1		= 0x28,	/* TX CRC claculation space */
+	vcc_txcrc1		= 0x28,	/* TX CRC calculation space */
 	vcc_txcrc2		= 0x2C,
 	vcc_txreadptr		= 0x30, /* TX Readptr, plus bits: */
 #define   TXREADPTR_GET_PTR(x) ((x)&0x01FFF)
@@ -756,7 +756,7 @@ static void lanai_shutdown_rx_vci(const struct lanai_vcc *lvcc)
  * Unfortunately the lanai needs us to wait until all the data
  * drains out of the buffer before we can dealloc it, so this
  * can take awhile -- up to 370ms for a full 128KB buffer
- * assuming everone else is quiet.  In theory the time is
+ * assuming everyone else is quiet.  In theory the time is
  * boundless if there's a CBR VCC holding things up.
  */
 static void lanai_shutdown_tx_vci(struct lanai_dev *lanai,
diff --git a/drivers/atm/nicstar.h b/drivers/atm/nicstar.h
index 1b7f1dfc1735..f4a703730166 100644
--- a/drivers/atm/nicstar.h
+++ b/drivers/atm/nicstar.h
@@ -332,7 +332,7 @@ typedef struct ns_rcte {
 
 #define NS_RCT_ENTRY_SIZE 4	/* Number of dwords */
 
-   /* NOTE: We could make macros to contruct the first word of the RCTE,
+   /* NOTE: We could make macros to construct the first word of the RCTE,
       but that doesn't seem to make much sense... */
 
 /*
-- 
2.34.1
Re: [PATCH v1] atm: Fix typo in the comment
Posted by Simon Horman 2 months ago
On Wed, Sep 25, 2024 at 06:57:07PM +0800, Yan Zhen wrote:
> Correctly spelled comments make it easier for the reader to understand
> the code.
> 
> Fix typos:
> 'behing' ==> 'being',
> 'useable' ==> 'usable',
> 'arry' ==> 'array',
> 'receieve' ==> 'receive',
> 'desriptor' ==> 'descriptor',
> 'varients' ==> 'variants',
> 'recevie' ==> 'receive',
> 'Decriptor' ==> 'Descriptor',
> 'Lable' ==> 'Label',
> 'transmiting' ==> 'transmitting',
> 'correspondance' ==> 'correspondence',
> 'claculation' ==> 'calculation',
> 'everone' ==> 'everyone',
> 'contruct' ==> 'construct'.
> 
> 
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>

Hi,

I am curious to know which tree is this based on?
I don't seem to be able to apply it to net-next, linux-net,
or Linus's tree.
Re: [PATCH v1] atm: Fix typo in the comment
Posted by yanzhen 2 months ago
在 2024/9/26 4:05, Simon Horman 写道:
> On Wed, Sep 25, 2024 at 06:57:07PM +0800, Yan Zhen wrote:
>> Correctly spelled comments make it easier for the reader to understand
>> the code.
>>
>> Fix typos:
>> 'behing' ==> 'being',
>> 'useable' ==> 'usable',
>> 'arry' ==> 'array',
>> 'receieve' ==> 'receive',
>> 'desriptor' ==> 'descriptor',
>> 'varients' ==> 'variants',
>> 'recevie' ==> 'receive',
>> 'Decriptor' ==> 'Descriptor',
>> 'Lable' ==> 'Label',
>> 'transmiting' ==> 'transmitting',
>> 'correspondance' ==> 'correspondence',
>> 'claculation' ==> 'calculation',
>> 'everone' ==> 'everyone',
>> 'contruct' ==> 'construct'.
>>
>>
>> Signed-off-by: Yan Zhen <yanzhen@vivo.com>
> Hi,
>
> I am curious to know which tree is this based on?
> I don't seem to be able to apply it to net-next, linux-net,
> or Linus's tree.
I apologize, I may not have generated the patch based on the latest 
branch. Is the net-next branch currently closed? Should I wait for it to 
reopen before submitting?
Re: [PATCH v1] atm: Fix typo in the comment
Posted by Simon Horman 2 months ago
On Fri, Sep 27, 2024 at 04:22:19PM +0800, yanzhen wrote:
> 
> 在 2024/9/26 4:05, Simon Horman 写道:
> > On Wed, Sep 25, 2024 at 06:57:07PM +0800, Yan Zhen wrote:
> > > Correctly spelled comments make it easier for the reader to understand
> > > the code.
> > > 
> > > Fix typos:
> > > 'behing' ==> 'being',
> > > 'useable' ==> 'usable',
> > > 'arry' ==> 'array',
> > > 'receieve' ==> 'receive',
> > > 'desriptor' ==> 'descriptor',
> > > 'varients' ==> 'variants',
> > > 'recevie' ==> 'receive',
> > > 'Decriptor' ==> 'Descriptor',
> > > 'Lable' ==> 'Label',
> > > 'transmiting' ==> 'transmitting',
> > > 'correspondance' ==> 'correspondence',
> > > 'claculation' ==> 'calculation',
> > > 'everone' ==> 'everyone',
> > > 'contruct' ==> 'construct'.
> > > 
> > > 
> > > Signed-off-by: Yan Zhen <yanzhen@vivo.com>
> > Hi,
> > 
> > I am curious to know which tree is this based on?
> > I don't seem to be able to apply it to net-next, linux-net,
> > or Linus's tree.
> I apologize, I may not have generated the patch based on the latest branch.
> Is the net-next branch currently closed? Should I wait for it to reopen
> before submitting?

Yes, net-next is currently closed.
And yes, I think it would be best to wait for it to reopen.
I expect that will happen next week.

-- 
pw-bot: defer