[PATCH v3] Documentation: kgdb: Correct parameter error

Changhuang Liang posted 1 patch 2 months ago
Documentation/dev-tools/kgdb.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v3] Documentation: kgdb: Correct parameter error
Posted by Changhuang Liang 2 months ago
Module kgdb had been converted to debug_core since commit c433820971ff
("Move kernel/kgdb.c to kernel/debug/debug_core.c") be added, so let's
correct the module parameter path.

Fixes: c433820971ff ("Move kernel/kgdb.c to kernel/debug/debug_core.c")
Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---

Hi,

v3: I wrote a error change log in v2. Now fix it.

 Documentation/dev-tools/kgdb.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
index f83ba2601e55..a87a58e6509a 100644
--- a/Documentation/dev-tools/kgdb.rst
+++ b/Documentation/dev-tools/kgdb.rst
@@ -329,7 +329,7 @@ ways to activate this feature.

 2. Use sysfs before configuring an I/O driver::

-	echo 1 > /sys/module/kgdb/parameters/kgdb_use_con
+	echo 1 > /sys/module/debug_core/parameters/kgdb_use_con

 .. note::

--
2.25.1
Re: [PATCH v3] Documentation: kgdb: Correct parameter error
Posted by Daniel Thompson 1 month, 4 weeks ago
On Wed, Sep 25, 2024 at 03:07:42AM -0700, Changhuang Liang wrote:
> Module kgdb had been converted to debug_core since commit c433820971ff
> ("Move kernel/kgdb.c to kernel/debug/debug_core.c") be added, so let's
> correct the module parameter path.
>
> Fixes: c433820971ff ("Move kernel/kgdb.c to kernel/debug/debug_core.c")
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>

@Jon: Do you want me to hoover this up or will you take it? If you are
happy to grab it then feel free to treat my Rb: as an Acked-by: too!


Daniel.


> ---
>
> Hi,
>
> v3: I wrote a error change log in v2. Now fix it.
>
>  Documentation/dev-tools/kgdb.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
> index f83ba2601e55..a87a58e6509a 100644
> --- a/Documentation/dev-tools/kgdb.rst
> +++ b/Documentation/dev-tools/kgdb.rst
> @@ -329,7 +329,7 @@ ways to activate this feature.
>
>  2. Use sysfs before configuring an I/O driver::
>
> -	echo 1 > /sys/module/kgdb/parameters/kgdb_use_con
> +	echo 1 > /sys/module/debug_core/parameters/kgdb_use_con
>
>  .. note::
>
> --
> 2.25.1
Re: [PATCH v3] Documentation: kgdb: Correct parameter error
Posted by Jonathan Corbet 1 month, 4 weeks ago
Daniel Thompson <daniel.thompson@linaro.org> writes:

> On Wed, Sep 25, 2024 at 03:07:42AM -0700, Changhuang Liang wrote:
>> Module kgdb had been converted to debug_core since commit c433820971ff
>> ("Move kernel/kgdb.c to kernel/debug/debug_core.c") be added, so let's
>> correct the module parameter path.
>>
>> Fixes: c433820971ff ("Move kernel/kgdb.c to kernel/debug/debug_core.c")
>> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
>> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> @Jon: Do you want me to hoover this up or will you take it? If you are
> happy to grab it then feel free to treat my Rb: as an Acked-by: too!

Sure, I can grab it in a bit.

Thanks,

jon